From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 806DCA04B5; Sun, 1 Nov 2020 11:26:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCA6AAC8D; Sun, 1 Nov 2020 11:26:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id F1EA6AA31 for ; Sun, 1 Nov 2020 11:26:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604226394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m0V3I1CRUG+FFoLn3XH7R7NW4egtbd8mCuKM/WXYpDg=; b=ZRTzyOajMY7M8TTStynWh8l06N3UngC2yBnly4vl031d2FuoPzCctmbNatBuwSw5Mbve3x ssK0UoFkF7zzNi7HUkPw7oxi49AJdaetgPqO4/y8G2PbabScRE6nYM3C8p22TQDiO1vPjX McTBu6jZ6eftbC6Z2EaeOxPG78uMkOM= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-fXl03JrFNhyQmCVnCWf1rQ-1; Sun, 01 Nov 2020 05:26:33 -0500 X-MC-Unique: fXl03JrFNhyQmCVnCWf1rQ-1 Received: by mail-vs1-f71.google.com with SMTP id b73so3643688vsd.1 for ; Sun, 01 Nov 2020 02:26:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=m0V3I1CRUG+FFoLn3XH7R7NW4egtbd8mCuKM/WXYpDg=; b=G5kCgIoz07puocDs+YM2Vy55zr+OJ3AwGDXD3NhUgp1l8MOiiFYs1bTq4gQ7NSTadl SMB+FiAF7sy1aDYm8NZkZ7YOU2qWythZyzTdzWwcyYDGU33xIJUz0DuBEgcyotVophFr 7S98cZYlACJrN2NZcEfzXgh4/yTUFnEb5NVAf4xDYR8BBpgeMOvg0EYGxeoHKcDlA8QT k2coxklrGAIBNhmJD/TmowQXJLVbqRosW0H/27hje+RqQ4yPyBsPtdLzQwfUmg3/Krwy oyRfCd7BBzGDhTMxjeNkCjMecgq9wz3d6h6Z5jdDU9iGqLquTQkrAPFmBGzf1bBG+J3R MT0Q== X-Gm-Message-State: AOAM533oZYpSbCtf+Qq4O4ckOVO9pvbXQJ2fAwBjd6el2rY91sXpS+H1 NsLvvW50IphqqEJ7Z8tsO1kgBvv0j6VC26kWLMHLgJwwSRrVK141w3MByGBZxzQRvNNjrqnyCAk bvcZL7RpJ0ZMC2kFDB8s= X-Received: by 2002:a1f:1889:: with SMTP id 131mr10665034vky.20.1604226392590; Sun, 01 Nov 2020 02:26:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUn0EDUtL3kubYmaZ/XmWbWZAUqaF83hFIuh1BC16yi+9Zo8AX5DuZBXu0LtcHSaSxCunWOYDcPjpiF+5JIy4= X-Received: by 2002:a1f:1889:: with SMTP id 131mr10665027vky.20.1604226392276; Sun, 01 Nov 2020 02:26:32 -0800 (PST) MIME-Version: 1.0 References: <20201026052105.1561859-1-thomas@monjalon.net> <16204738.pLQXvH3U5b@thomas> <5960b0cf-eb7a-af00-ae6a-86ad5e5db6eb@intel.com> <2336246.PS5YtoHrA8@thomas> In-Reply-To: <2336246.PS5YtoHrA8@thomas> From: David Marchand Date: Sun, 1 Nov 2020 11:26:21 +0100 Message-ID: To: Thomas Monjalon , Ferruh Yigit , Jiawen Wu Cc: Jian Wang , dev , Bruce Richardson , Olivier Matz , Andrew Rybchenko , Akhil Goyal , Jerin Jacob Kollanukkaran Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon wrote= : > > The new txgbe driver in the next-net is also using =E2=80=98udata64=E2= =80=99, that also needs to > > be updated. cc'ed txgbe maintainer. > > That's a pity it did not take into account the deprecation notice. > What kind of hack is it used for? > Can it be simply removed to allow quick merging of the PMD? +1 for removing. It seems to be a provision for future features, as this field is simply passed to an internal function that does not use it. $ git grep -C 2 udata drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c- txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, drivers/net/txgbe/txgbe_rxtx.c: tx_offload, &tx_pkt->udata64); drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c- txe->last_id =3D tx= _last; $ git grep -C 2 txgbe_set_xmit_ctx drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c-static inline void drivers/net/txgbe/txgbe_rxtx.c:txgbe_set_xmit_ctx(struct txgbe_tx_queue *tx= q, drivers/net/txgbe/txgbe_rxtx.c- volatile struct txgbe_tx_ctx_desc *ctx_txd, drivers/net/txgbe/txgbe_rxtx.c- uint64_t ol_flags, union txgbe_tx_offload tx_offload, -- drivers/net/txgbe/txgbe_rxtx.c- } drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c: txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, drivers/net/txgbe/txgbe_rxtx.c- tx_offload, &tx_pkt->udata64); drivers/net/txgbe/txgbe_rxtx.c- $ git grep -w mdata drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c: __rte_unused uint64_t *mdata) --=20 David Marchand