From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com,
thomas@monjalon.net, pbhagavatula@marvell.com,
ndabilpuram@marvell.com
Subject: Re: [PATCH v3 00/16] replace __atomic operations returning new value
Date: Tue, 25 Apr 2023 11:10:42 +0200 [thread overview]
Message-ID: <CAJFAV8xwCSdkBndbRC9rDMQtqDA6ybidhXWSfYrnfYn_+zd2-g@mail.gmail.com> (raw)
In-Reply-To: <1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com>
On Mon, Mar 20, 2023 at 8:01 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with
> __atomic_fetch_{add,and,or,sub,xor} intrinsics where the new value
> is used.
>
> This series is being separated from the other similar series in
> an effort to reduce the chance of mistakes being spotted in review
> since the usages in this case consume the returned / new value.
>
> v3:
> * incorporate Reviewed-by and Acked-by received so far
> * rebase series on -rc3 to get a fresh CI run
>
> v2:
> * remove unnecessary casts of signed to unsigned arguments when
> using generic __atomic builtins.
> * remove inappropriate cast of signed negative value on addend.
>
> Tyler Retzlaff (16):
> app/test: use previous value atomic fetch operations
> common/cnxk: use previous value atomic fetch operations
> common/mlx5: use previous value atomic fetch operations
> drivers/event: use previous value atomic fetch operations
> net/af_xdp: use previous value atomic fetch operations
> net/cnxk: use previous value atomic fetch operations
> net/cxgbe: use previous value atomic fetch operations
> net/iavf: use previous value atomic fetch operations
> net/mlx5: use previous value atomic fetch operations
> net/octeontx: use previous value atomic fetch operations
> raw/ifpga: use previous value atomic fetch operations
> bbdev: use previous value atomic fetch operations
> eal: use previous value atomic fetch operations
> ipsec: use previous value atomic fetch operations
> mbuf: use previous value atomic fetch operations
> rcu: use previous value atomic fetch operations
>
> app/test/test_ring_perf.c | 2 +-
> drivers/common/cnxk/roc_ae.c | 2 +-
> drivers/common/cnxk/roc_ae_fpm_tables.c | 2 +-
> drivers/common/cnxk/roc_npa.c | 2 +-
> drivers/common/mlx5/linux/mlx5_nl.c | 2 +-
> drivers/common/mlx5/mlx5_common_mr.c | 8 ++++----
> drivers/common/mlx5/mlx5_common_utils.c | 8 ++++----
> drivers/event/cnxk/cnxk_tim_worker.h | 2 +-
> drivers/event/dsw/dsw_event.c | 4 ++--
> drivers/event/octeontx/timvf_worker.h | 2 +-
> drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++--
> drivers/net/cnxk/cn10k_tx.h | 4 ++--
> drivers/net/cxgbe/clip_tbl.c | 2 +-
> drivers/net/cxgbe/mps_tcam.c | 2 +-
> drivers/net/iavf/iavf_vchnl.c | 8 ++++----
> drivers/net/mlx5/linux/mlx5_verbs.c | 2 +-
> drivers/net/mlx5/mlx5.c | 4 ++--
> drivers/net/mlx5/mlx5_flow.c | 8 ++++----
> drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------
> drivers/net/mlx5/mlx5_flow_hw.c | 14 +++++++-------
> drivers/net/mlx5/mlx5_hws_cnt.c | 4 ++--
> drivers/net/mlx5/mlx5_rxq.c | 6 +++---
> drivers/net/mlx5/mlx5_txq.c | 2 +-
> drivers/net/octeontx/octeontx_ethdev.c | 2 +-
> drivers/raw/ifpga/ifpga_rawdev.c | 2 +-
> lib/bbdev/rte_bbdev.c | 4 ++--
> lib/eal/include/generic/rte_rwlock.h | 8 ++++----
> lib/eal/ppc/include/rte_atomic.h | 16 ++++++++--------
> lib/ipsec/ipsec_sqn.h | 2 +-
> lib/mbuf/rte_mbuf.h | 12 ++++++------
> lib/rcu/rte_rcu_qsbr.h | 2 +-
> 31 files changed, 77 insertions(+), 77 deletions(-)
>
LGTM.
Series applied, thanks.
--
David Marchand
prev parent reply other threads:[~2023-04-25 9:10 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 22:15 [PATCH 00/16] use " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 02/16] common/cnxk: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 03/16] common/mlx5: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 04/16] drivers/event: " Tyler Retzlaff
2023-03-13 7:02 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-03-10 22:15 ` [PATCH 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 06/16] net/cnxk: " Tyler Retzlaff
2023-03-13 6:45 ` [EXT] " Nithin Kumar Dabilpuram
2023-03-10 22:15 ` [PATCH 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 08/16] net/iavf: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 09/16] net/mlx5: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 10/16] net/octeontx: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 12/16] bbdev: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 13/16] eal: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 14/16] ipsec: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 15/16] mbuf: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 16/16] rcu: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 00/16] replace __atomic operations returning new value Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 02/16] common/cnxk: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 03/16] common/mlx5: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 04/16] drivers/event: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 06/16] net/cnxk: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 08/16] net/iavf: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 09/16] net/mlx5: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 10/16] net/octeontx: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 12/16] bbdev: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 13/16] eal: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 14/16] ipsec: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 15/16] mbuf: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 16/16] rcu: " Tyler Retzlaff
2023-03-16 10:03 ` [PATCH v2 00/16] replace __atomic operations returning new value Bruce Richardson
2023-03-16 15:25 ` Thomas Monjalon
2023-03-16 16:17 ` Tyler Retzlaff
2023-04-18 18:11 ` Tyler Retzlaff
2023-03-20 10:24 ` Ruifeng Wang
2023-03-20 19:00 ` [PATCH v3 " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 02/16] common/cnxk: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 03/16] common/mlx5: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 04/16] drivers/event: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 06/16] net/cnxk: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 08/16] net/iavf: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 09/16] net/mlx5: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 10/16] net/octeontx: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 12/16] bbdev: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 13/16] eal: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 14/16] ipsec: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 15/16] mbuf: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 16/16] rcu: " Tyler Retzlaff
2023-04-25 9:10 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xwCSdkBndbRC9rDMQtqDA6ybidhXWSfYrnfYn_+zd2-g@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).