From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0036E429E9; Tue, 25 Apr 2023 11:10:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08877410D0; Tue, 25 Apr 2023 11:10:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0F9F440395 for ; Tue, 25 Apr 2023 11:10:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682413856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uq4bCkphjEl3fCHuvvsos9eD5NlvibE0OP7S/M1XbK4=; b=RzcKhjJpBHYMy2LKXyb1IvCyTTXiQ0JlSEG/BCM7yHw9sYyi4lbpWa2m3zCcX6zFujHrmn CbmnEN5BQvitF4YRxj0aK9Rgx2KGgtE2LcmNEwyDBzDan+2nKhsRU1lZJ4cF7PyjWLkBD4 G6KNnb1PxAN2mdqtupOAsl7iYzNtGOo= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-237-1GUxXEYXPLGL1bqUQAkhEQ-1; Tue, 25 Apr 2023 05:10:55 -0400 X-MC-Unique: 1GUxXEYXPLGL1bqUQAkhEQ-1 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-51b12187312so5615261a12.2 for ; Tue, 25 Apr 2023 02:10:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682413854; x=1685005854; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uq4bCkphjEl3fCHuvvsos9eD5NlvibE0OP7S/M1XbK4=; b=RG55uQ/9XC/eqs0aaK0SlshjUALyC6qDxRHHvTCASySmNYWJHk0qjzdYBngXf04uFA RnEI3xjfca9xrjWHI9SbR4m5z4aeiWrOhAk1Qe+n1BjzClYEzTFbU6knwX72EoEH6RCV OKB94puYmJCWFac/EdDS1HnzKjnRNwGl45PRsbhUT0C5rqx+pfSHNM4i/AciYWVPva8b sr3GiuSlym/+KVbZT9TZpwpadbyDQfrcN1lk2MLN/L9BS2by3TsI9f6ohdzNaAzYVB5Y Ztb76wVFXFTjhIbbnVszvirm8h5fFI1qGkU0aOSOtf8JJOTSoqAKsK7alu+d5nDZJFPi Ud7w== X-Gm-Message-State: AAQBX9dXfiHZV4beQVZUwnYiNacLIPFYBrF+TIsp9vXaCP3iN6DGk6UX E0iwKPeQEfYUc0brcQzEIqjyKxPpUQhQed4a0+St6NrAdPexcz7nxB48hY59Xds69Fi+yCW4Ltb XK/2G31CWu+zLkZ5B6K0= X-Received: by 2002:a17:903:1106:b0:1a9:2e10:4028 with SMTP id n6-20020a170903110600b001a92e104028mr21504689plh.24.1682413854296; Tue, 25 Apr 2023 02:10:54 -0700 (PDT) X-Google-Smtp-Source: AKy350aVBA5hBYb53+h5p8EGYuldt30d+AUURBSa53LX6NCfM6vaiSCfd0Vg/IjKuqXSQbuy2tvv5W3100uS8rTALk0= X-Received: by 2002:a17:903:1106:b0:1a9:2e10:4028 with SMTP id n6-20020a170903110600b001a92e104028mr21504672plh.24.1682413854034; Tue, 25 Apr 2023 02:10:54 -0700 (PDT) MIME-Version: 1.0 References: <1678486530-20688-1-git-send-email-roretzla@linux.microsoft.com> <1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1679338836-21321-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 25 Apr 2023 11:10:42 +0200 Message-ID: Subject: Re: [PATCH v3 00/16] replace __atomic operations returning new value To: Tyler Retzlaff Cc: dev@dpdk.org, Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net, pbhagavatula@marvell.com, ndabilpuram@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 20, 2023 at 8:01=E2=80=AFPM Tyler Retzlaff wrote: > > This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with > __atomic_fetch_{add,and,or,sub,xor} intrinsics where the new value > is used. > > This series is being separated from the other similar series in > an effort to reduce the chance of mistakes being spotted in review > since the usages in this case consume the returned / new value. > > v3: > * incorporate Reviewed-by and Acked-by received so far > * rebase series on -rc3 to get a fresh CI run > > v2: > * remove unnecessary casts of signed to unsigned arguments when > using generic __atomic builtins. > * remove inappropriate cast of signed negative value on addend. > > Tyler Retzlaff (16): > app/test: use previous value atomic fetch operations > common/cnxk: use previous value atomic fetch operations > common/mlx5: use previous value atomic fetch operations > drivers/event: use previous value atomic fetch operations > net/af_xdp: use previous value atomic fetch operations > net/cnxk: use previous value atomic fetch operations > net/cxgbe: use previous value atomic fetch operations > net/iavf: use previous value atomic fetch operations > net/mlx5: use previous value atomic fetch operations > net/octeontx: use previous value atomic fetch operations > raw/ifpga: use previous value atomic fetch operations > bbdev: use previous value atomic fetch operations > eal: use previous value atomic fetch operations > ipsec: use previous value atomic fetch operations > mbuf: use previous value atomic fetch operations > rcu: use previous value atomic fetch operations > > app/test/test_ring_perf.c | 2 +- > drivers/common/cnxk/roc_ae.c | 2 +- > drivers/common/cnxk/roc_ae_fpm_tables.c | 2 +- > drivers/common/cnxk/roc_npa.c | 2 +- > drivers/common/mlx5/linux/mlx5_nl.c | 2 +- > drivers/common/mlx5/mlx5_common_mr.c | 8 ++++---- > drivers/common/mlx5/mlx5_common_utils.c | 8 ++++---- > drivers/event/cnxk/cnxk_tim_worker.h | 2 +- > drivers/event/dsw/dsw_event.c | 4 ++-- > drivers/event/octeontx/timvf_worker.h | 2 +- > drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++-- > drivers/net/cnxk/cn10k_tx.h | 4 ++-- > drivers/net/cxgbe/clip_tbl.c | 2 +- > drivers/net/cxgbe/mps_tcam.c | 2 +- > drivers/net/iavf/iavf_vchnl.c | 8 ++++---- > drivers/net/mlx5/linux/mlx5_verbs.c | 2 +- > drivers/net/mlx5/mlx5.c | 4 ++-- > drivers/net/mlx5/mlx5_flow.c | 8 ++++---- > drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------ > drivers/net/mlx5/mlx5_flow_hw.c | 14 +++++++------- > drivers/net/mlx5/mlx5_hws_cnt.c | 4 ++-- > drivers/net/mlx5/mlx5_rxq.c | 6 +++--- > drivers/net/mlx5/mlx5_txq.c | 2 +- > drivers/net/octeontx/octeontx_ethdev.c | 2 +- > drivers/raw/ifpga/ifpga_rawdev.c | 2 +- > lib/bbdev/rte_bbdev.c | 4 ++-- > lib/eal/include/generic/rte_rwlock.h | 8 ++++---- > lib/eal/ppc/include/rte_atomic.h | 16 ++++++++-------- > lib/ipsec/ipsec_sqn.h | 2 +- > lib/mbuf/rte_mbuf.h | 12 ++++++------ > lib/rcu/rte_rcu_qsbr.h | 2 +- > 31 files changed, 77 insertions(+), 77 deletions(-) > LGTM. Series applied, thanks. --=20 David Marchand