From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A58C1A046B for ; Sat, 29 Jun 2019 18:39:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49DA737B0; Sat, 29 Jun 2019 18:39:45 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 5E43F25D9 for ; Sat, 29 Jun 2019 18:39:44 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id m8so6155839vsj.0 for ; Sat, 29 Jun 2019 09:39:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OKlf5Zogu6brQ9OVsfAqect/tWYf4MujuuTu6/gSteI=; b=q9c69r3e9OB1PFhMeiBPL8+4OioF9EfOOBV2Yh4QVV0VFZsQ90zkdpqkZoNJxB96tx gfYcDnuAVEPsn3AEO7+MeNMpjyzKfefxRsaT/O2gX+lGF/Hg4SDAVQ3kIVMKb2nPnSNz sZDx8HPgHa5cmrLlTB7oGvFt8J0QmzMYeFmiH/KOLZ2m0FcZuYjR2dU1gghvTJj6mbYo dqxV5KbLe64P4/llrY4XiPjnPiWVE06D2annFUOUYM8XI7ppJqq9dSe+ftgDvB1jdmCG /2difkw0+8jXJGQ9r1E1Y6f4liJgPPnLvRoMpxgs0POIBKynVps7ah4E23Fa5Ffn0Jx5 tinw== X-Gm-Message-State: APjAAAWMqF7Gh0cn7Xw5SkyQYN/XZ9keDuWyFHafQpkblkQNDnAuXdiB lHOGc7Y1JOJEueZoDjK18+V+4tc5f/qlh8PjHQlZ5w== X-Google-Smtp-Source: APXvYqxRUnMgqtxgfokBdyVEAvvwAdpql1DdOvVTGBpuovrJ0kXvnlM2oysYu6JxZdbRDUhsCtoaHJcsc/MlG+s0QPw= X-Received: by 2002:a67:f998:: with SMTP id b24mr9748074vsq.180.1561826383765; Sat, 29 Jun 2019 09:39:43 -0700 (PDT) MIME-Version: 1.0 References: <1561635235-22238-1-git-send-email-david.marchand@redhat.com> <1561809533-6545-1-git-send-email-david.marchand@redhat.com> <1561809533-6545-11-git-send-email-david.marchand@redhat.com> <3633624.cieMKMvx7x@xps> In-Reply-To: <3633624.cieMKMvx7x@xps> From: David Marchand Date: Sat, 29 Jun 2019 18:39:32 +0200 Message-ID: To: Thomas Monjalon , Aaron Conole , Michael Santana Cc: dev , Neil Horman , Adrien Mazarguil , Stephen Hemminger Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 10/10] enforce __rte_experimental at the start of symbol declarations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Jun 29, 2019 at 6:14 PM Thomas Monjalon wrote: > 29/06/2019 13:58, David Marchand: > > Special mention for rte_mbuf_data_addr_default(): > > > > There is either a bug or a (not yet understood) issue with gcc. > > gcc won't drop this inline when unused and rte_mbuf_data_addr_default() > > calls rte_mbuf_buf_addr() which itself is experimental. > > This results in a build warning when not accepting experimental apis > > from sources just including rte_mbuf.h. > > > > For this specific case, we hide the call to rte_mbuf_buf_addr() under > > the ALLOW_EXPERIMENTAL_API flag. > [...] > > -static inline char * __rte_experimental > > -rte_mbuf_data_addr_default(struct rte_mbuf *mb) > > +__rte_experimental > > +static inline char * > > +rte_mbuf_data_addr_default(struct rte_mbuf *mb __rte_unused) > > { > > + /* gcc complains about calling this experimental function even > > + * when not using it. Hide it with ALLOW_EXPERIMENTAL_API. > > + */ > > +#ifdef ALLOW_EXPERIMENTAL_API > > return rte_mbuf_buf_addr(mb, mb->pool) + RTE_PKTMBUF_HEADROOM; > > +#else > > + return NULL; > > +#endif > > } > > Doxygen is confused by having __rte_unused at the end: > > lib/librte_mbuf/rte_mbuf.h:876: warning: > argument 'mb' of command @param is not found in the argument list > of > rte_mbuf_data_addr_default(struct rte_mbuf *mb __rte_unused) > lib/librte_mbuf/rte_mbuf.h:889: warning: > The following parameters of > rte_mbuf_data_addr_default(struct rte_mbuf *mb __rte_unused) > are not documented: > parameter '__rte_unused' > > I move __rte_unused at the beginning while merging. > Indeed. Thanks for catching and fixing. Consequently, could we have the documentation (html only?) generated in the CI if it is not too time consuming. WDYT Aaron, Michael? -- David Marchand