From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6506042A5B; Thu, 4 May 2023 10:02:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1230241144; Thu, 4 May 2023 10:02:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 08C04410DC for ; Thu, 4 May 2023 10:02:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683187364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ODSUX9ayptaCuTjrHdJLl73e7B9lC+zf8uUfSh+1nw=; b=eIN0pAW6s4HgBOLSZu21VMuiVZDOUbNsodYieDt3Y9RQdcG74nQHoKgvmtds9ivwFcBBHy 8B8X0fOI8fqYusLWC2oedK4E7McgpaYMriplRTO1BGb2Eb4wqSHJ+DSaFMi0r5BvQ/T1Ei oDeF1rmsA2SatJH9ZURDFEWDZ90yUAo= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-DuzAHD8oNl2HDQWVCLNt8Q-1; Thu, 04 May 2023 04:02:43 -0400 X-MC-Unique: DuzAHD8oNl2HDQWVCLNt8Q-1 Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-6437c45318aso133717b3a.2 for ; Thu, 04 May 2023 01:02:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683187362; x=1685779362; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2ODSUX9ayptaCuTjrHdJLl73e7B9lC+zf8uUfSh+1nw=; b=GFTwAv2Vn6FnMg4d2n7Vh7RoWqi6d1ATqsRYcRg5Uo9DI6kksL+21cxgvgmXNvIO6n dD2XnHei7kif/AMV4qqHWpu4ARQva3zabVd8Pz0YGPmyM7RO8ECvmM5W3pwBQrJcEKao Z4EdxKb4NjSAzokAU0AsHXfgijqiuZl5XYQ0vQ1K1+QCnl5zy83j6Ip2EDK0qOKPPfS+ EYQtVlpNmsdXVISF6k2Vm9jH/+01SWFL3q5fwZWV6+M+8pJAO/lehtJCslUcCzd8K0Fc 54fZH6ftLiEOSLRKWwXKoBzN+S0JtcEHM9yGZjZ6ubU0V0pXXItct4VLRt9ij4HD7+0F BQDA== X-Gm-Message-State: AC+VfDx/49KaGqXZ2bRAZYVjEPZV2kIbgWeVU1IazBgw/8sEomoVmTCu d9pR5cmDIXyLt+wvYkcfDc7hcjpRMgEv72FZ2KvqVfTPQRv0q/NFvAVV8c5lexF2w/FUC7fgum5 ygNLZywFpcSxjN7M6SOo= X-Received: by 2002:a05:6a20:438c:b0:f6:8d47:17f5 with SMTP id i12-20020a056a20438c00b000f68d4717f5mr1638559pzl.11.1683187362289; Thu, 04 May 2023 01:02:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5U2VeCd5mI4nD58fz2DPtEYPU89J2g2v5zCG+5R/NR1sExCiJLRdIV/MzA3shSaZrreyMxGYqTrHXYAt1Ezi4= X-Received: by 2002:a05:6a20:438c:b0:f6:8d47:17f5 with SMTP id i12-20020a056a20438c00b000f68d4717f5mr1638537pzl.11.1683187361986; Thu, 04 May 2023 01:02:41 -0700 (PDT) MIME-Version: 1.0 References: <20230213113156.385482-1-tduszynski@marvell.com> <20230216175502.3164820-1-tduszynski@marvell.com> In-Reply-To: <20230216175502.3164820-1-tduszynski@marvell.com> From: David Marchand Date: Thu, 4 May 2023 10:02:30 +0200 Message-ID: Subject: Re: [PATCH v11 0/4] add support for self monitoring To: Tomasz Duszynski Cc: dev@dpdk.org, roretzla@linux.microsoft.com, Ruifeng.Wang@arm.com, bruce.richardson@intel.com, jerinj@marvell.com, mattias.ronnblom@ericsson.com, mb@smartsharesystems.com, thomas@monjalon.net, zhoumin@loongson.cn, Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tomasz, On Thu, Feb 16, 2023 at 6:55=E2=80=AFPM Tomasz Duszynski wrote: > > This series adds self monitoring support i.e allows to configure and > read performance measurement unit (PMU) counters in runtime without > using perf utility. This has certain advantages when application runs on > isolated cores running dedicated tasks. > > Events can be read directly using rte_pmu_read() or using dedicated > tracepoint rte_eal_trace_pmu_read(). The latter will cause events to be > stored inside CTF file. > > By design, all enabled events are grouped together and the same group > is attached to lcores that use self monitoring funtionality. > > Events are enabled by names, which need to be read from standard > location under sysfs i.e > > /sys/bus/event_source/devices/PMU/events > > where PMU is a core pmu i.e one measuring cpu events. As of today > raw events are not supported. > > Tomasz Duszynski (4): > lib: add generic support for reading PMU events > pmu: support reading ARM PMU events in runtime > pmu: support reading Intel x86_64 PMU events in runtime > eal: add PMU support to tracing library There are still some pending comments on this series and it can't be merged until they get sorted out. I noted two points : - Konstantin asked for better explanations in the implementation. - He also pointed out at using this feature with non EAL lcores. Could you work on this so we can consider this series for v23.07? Thank you. --=20 David Marchand