From: David Marchand <david.marchand@redhat.com>
To: john.mcnamara@intel.com, Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, ktraynor@redhat.com, ian.stokes@intel.com,
stable@dpdk.org, Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Mingjin Ye <mingjinx.ye@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH] net/iavf: fix application reset callback calls
Date: Thu, 1 Feb 2024 09:58:10 +0100 [thread overview]
Message-ID: <CAJFAV8xx-dSz6eOVa9vN23bp+G_fVX9RrEMQTBmVDNKezYAgfA@mail.gmail.com> (raw)
In-Reply-To: <20240117115410.3984237-1-david.marchand@redhat.com>
On Wed, Jan 17, 2024 at 12:54 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Don't trigger an application reset callback if the port is not started.
>
> Bugzilla ID: 1337
> Fixes: 675a104e2e94 ("net/iavf: fix abnormal disable HW interrupt")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
I am withdrawing this patch.
As I mentionned in the bugzilla, this patch is probably introducing races.
I don't have the time/expertise to look deeper into this driver, and
it does not seem like Intel will invest in fixing this.
Fyi, I sent a patch on the ethdev API recommending not to use locks in
application event callbacks.
Reviews welcome.
Thanks.
--
David Marchand
prev parent reply other threads:[~2024-02-01 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 11:54 David Marchand
2024-02-01 8:58 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xx-dSz6eOVa9vN23bp+G_fVX9RrEMQTBmVDNKezYAgfA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ian.stokes@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
--cc=mingjinx.ye@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).