From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF57AA09FF; Wed, 6 Jan 2021 10:06:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A579C160893; Wed, 6 Jan 2021 10:06:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id A36CC160892 for ; Wed, 6 Jan 2021 10:06:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609923994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2wgiap5VdEMA+/kW6H7H4rAeVrKQb7Bvx5+Vwt4x6iQ=; b=DB1t0TBnCltoLSHgiUv9LfGZGAahELr7Um4r4ATPj0Vze8plml3Pc/6rgAv7OBNWt9AvdY pADT48ZbEkxUe1YdK2oAURJo9X+6ZjCambKOR4J1wWQvUka4/Bik4bWuoCIX7A1BQCdSo3 7NldGJd8qwA8f7j6ynZvIAUSdE8X914= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-59JMm4XoMsWspbOM2W_-yA-1; Wed, 06 Jan 2021 04:06:32 -0500 X-MC-Unique: 59JMm4XoMsWspbOM2W_-yA-1 Received: by mail-vk1-f199.google.com with SMTP id h63so1177020vkh.8 for ; Wed, 06 Jan 2021 01:06:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2wgiap5VdEMA+/kW6H7H4rAeVrKQb7Bvx5+Vwt4x6iQ=; b=I2ZRYNaVD1LjQf0n3wpPjt/Ef7o2KjD4JL8fTVGuqFQDQfFNuBTL6Jl6HQJ1kbmNvH EJGBwxKFuIXawdoWKSBh1NrmJwIMsg+WiNq06UoIGtA2NGYZjiQl4YtzawPtWMDl2XW9 5XTBdH4CYM+WlyDK/FCHPHU9JcADEA8yWrfiUC7WV15dVYklcsY6Hp9E2/vnQ4IqvFFK HIKbGfa/9Lv5biyZ9jUm7ojAlMnyFJJBs28fE0bzQLoW4n3paoVoVnnOqDPBu2SxPtgM htBoGl8oQnEkTjnJizHhKKlSnipb4MexUReXl+NbpD1rjH2gt2gNpWOdGm1ThqLLciJi BFUw== X-Gm-Message-State: AOAM530x74Ts0H4q/icBTlohWD7EtZeOMfsYbjPW6S3cFz2ligA6m62v oKS3CG2xMMJoikJSVozYmqdIXxTFjAYty/30qvHWNw80xToMSDDxVU14Hfsh7HBwCTQQuK689GG MNkPx28V68gk1lk++A8Y= X-Received: by 2002:a1f:3246:: with SMTP id y67mr2478072vky.9.1609923992307; Wed, 06 Jan 2021 01:06:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1loF1VYWY5ZHclIgGJhVPitm34YS31vFoKG8b8kLJtWTBHTESWBSYQ/jZG7gcBjeiUHfjVud5migLIjCmrL8= X-Received: by 2002:a1f:3246:: with SMTP id y67mr2478063vky.9.1609923992162; Wed, 06 Jan 2021 01:06:32 -0800 (PST) MIME-Version: 1.0 References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-9-maxime.coquelin@redhat.com> In-Reply-To: <20201220211405.313012-9-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 6 Jan 2021 10:06:21 +0100 Message-ID: To: Maxime Coquelin , Ray Kinsella , Thomas Monjalon Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 08/40] net/virtio: force IOVA as VA mode for Virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Dec 20, 2020 at 10:14 PM Maxime Coquelin wrote: > diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c > index 1f1f63a1a5..f4775ff141 100644 > --- a/drivers/net/virtio/virtio_user_ethdev.c > +++ b/drivers/net/virtio/virtio_user_ethdev.c > @@ -663,6 +663,17 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev) > char *mac_addr = NULL; > int ret = -1; > > + /* > + * ToDo 1: Implement detection mechanism at vdev bus level as PCI, but > + * it implies API breakage. Extending rte_vdev_driver to implement this detection would be an ABI breakage. This is a driver-only API (rte_vdev_driver is only used by the vdev bus and drivers afaics). Doing this is allowed as per my understanding of the ABI policy which guarantees ABI stability for applications. We do not guarantee this stability for OOT drivers. -- David Marchand