From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73A47A04B1; Wed, 23 Sep 2020 09:35:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58CBA1C2AA; Wed, 23 Sep 2020 09:35:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 0FB4D1C211 for ; Wed, 23 Sep 2020 09:35:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600846507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FE8RtivvATHL2j67Fl1ez97ZKZN+ZAWb8trfmeMAVxk=; b=aGQH6zIPVIrp5GVlO2UfpoJWKTABW4nR5fzzvNN5Eb6Fr61QbQwo95IV8Kw5z+jleara+c JMrw9t9MdgrLhVlK/RjoAeObPozxdQN647sdwFmEL2biq7RnAA0xbgRgId9SKtPTvRxfBU s7KIKly81lDpJHhrl/9HYSASDAbDBzk= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-NOkkV5t7PumAumeAyMKbFg-1; Wed, 23 Sep 2020 03:34:39 -0400 X-MC-Unique: NOkkV5t7PumAumeAyMKbFg-1 Received: by mail-vs1-f71.google.com with SMTP id b9so5691899vsd.13 for ; Wed, 23 Sep 2020 00:34:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FE8RtivvATHL2j67Fl1ez97ZKZN+ZAWb8trfmeMAVxk=; b=MaZ0cqQAvH6UbK2Uy4seTrHegLWTAABr0cun/zrVsEQvlUw5pBu8J+oS1m+GzU8re5 pBp/inVN/m81uHqEqu6d0Hk7+UeGnMZNtw1CGuHbpScF/pU0ULk14GqDL/DUcJ7luHto HFp3NMnBeJU5hwBvbNy6Ge2wwbU6Vr0YJHV6pk+vbocibhktRjys/qsagQBkUdbrAmcv XvHYHpX3rphqHc5RwkfYikqR30z7Ilu3x24Wielr53I2PQ0zM0kPpE6IVlZNVfV/u9Ix lKlp90ovxgnRiOlU+Vz/Xo+rDDNg4Rw86/IlM9dKCbXxs8MKLaqYew9NKcZRtzYKtt5C K1Vg== X-Gm-Message-State: AOAM530IGx9r7X0jgNd9CrV7aoFZ79Ph5jJCWI6SZOGMZbead/rMcMNR YV4RcW/qPQoH1+1F+WvuEJmWeoo6wpXKWTmgPe+e66o5Wr0huNuUdlMdTKIzkrzXb9UowUGYbKK 5BvRH82YU5kxmEPicMT8= X-Received: by 2002:ab0:20a:: with SMTP id 10mr5247855uas.86.1600846478583; Wed, 23 Sep 2020 00:34:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUCJA0Gr2tx97gTJUxtLi/9GmImX/cysCYkBvDmK0fFxjV3vuEwRaBgQniPb3rAPcCYt77LbHk8x35/pNr8HQ= X-Received: by 2002:ab0:20a:: with SMTP id 10mr5247840uas.86.1600846478348; Wed, 23 Sep 2020 00:34:38 -0700 (PDT) MIME-Version: 1.0 References: <20200708092435.9776-1-alvinx.zhang@intel.com> <3033441.08XpM1RNeG@thomas> In-Reply-To: <3033441.08XpM1RNeG@thomas> From: David Marchand Date: Wed, 23 Sep 2020 09:34:27 +0200 Message-ID: To: Thomas Monjalon , "Zhang, AlvinX" , "Burakov, Anatoly" Cc: dev , Beilei Xing , Jeff Guo , "Yigit, Ferruh" , Bruce Richardson , Qian Xu , "Mcnamara, John" , Tal Shnaiderman , Raslan , Asaf Penso Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix mmap PCI resource X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 10, 2020 at 12:08 PM Thomas Monjalon wrote: > > It took me some time to understand this code... > > Anyway, we have a regression in the librte_pci. > > This is where the fix should be. > > Yes, I am going to send a fix. > > > We can cleanup this code later. > > Yes please, this function isn't understandable and lack of comments. > Anatoly please? Now that the workaround on the pci mapping API has been reverted, we are back with this issue. https://bugs.dpdk.org/show_bug.cgi?id=539 Volunteer(s) to fix and clean this code? Thanks. -- David Marchand