From: David Marchand <david.marchand@redhat.com>
To: Akhil Goyal <gakhil@marvell.com>
Cc: dev <dev@dpdk.org>, Anoob Joseph <anoobj@marvell.com>,
Matan Azrad <matan@nvidia.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Rosen Xu <rosen.xu@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Ray Kinsella <mdr@ashroe.eu>, Dodji Seketeli <dodji@redhat.com>
Subject: Re: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly
Date: Tue, 8 Feb 2022 10:27:35 +0100 [thread overview]
Message-ID: <CAJFAV8xxfHEYPPVk2gZn0OmRsToQbSWrAs1kzMEC-cymQfkZoA@mail.gmail.com> (raw)
In-Reply-To: <CO6PR18MB4484FD6F14CF0693B82C067FD82D9@CO6PR18MB4484.namprd18.prod.outlook.com>
On Tue, Feb 8, 2022 at 10:19 AM Akhil Goyal <gakhil@marvell.com> wrote:
>
> > Hello Akhil,
> >
> >
> > On Fri, Feb 4, 2022 at 11:14 PM Akhil Goyal <gakhil@marvell.com> wrote:
> > >
> > > A new option is added in IPsec to enable and attempt reassembly
> > > of inbound packets.
> >
> > First, about extending this structure.
> >
> > Copying the header:
> >
> > /** Reserved bit fields for future extension
> > *
> > * User should ensure reserved_opts is cleared as it may change in
> > * subsequent releases to support new options.
> > *
> > * Note: Reduce number of bits in reserved_opts for every new option.
> > */
> > uint32_t reserved_opts : 18;
> >
> > I did not follow the introduction of the reserved_opts field, but
> > writing this comment in the API only is weak.
> > Why can't the rte_security API enforce reserved_opts == 0 (like in
> > rte_security_session_create)?
> >
> This was discussed here.
> http://patches.dpdk.org/project/dpdk/patch/20211008204516.3497060-3-gakhil@marvell.com/
> rte_security_ipsec_sa_options is being used at multiple places as listed below in abiignore.
> Checking a particular field in each of the API does not make sense to me.
It's strange to me that a user may pass this structure as input in
multiple functions.
But if it's how the security lib works, ok.
>
> >
> >
> > >
> > > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > > Change-Id: I6f66f0b5a659550976a32629130594070cb16cb1
> > ^^^
> > Internal tag, please remove.
> >
> Yes, missed that will remove.
> >
> > > ---
> > > devtools/libabigail.abignore | 14 ++++++++++++++
> > > lib/security/rte_security.h | 12 +++++++++++-
> > > 2 files changed, 25 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> > > index 4b676f317d..3bd39042e8 100644
> > > --- a/devtools/libabigail.abignore
> > > +++ b/devtools/libabigail.abignore
> > > @@ -11,3 +11,17 @@
> > > ; Ignore generated PMD information strings
> > > [suppress_variable]
> > > name_regexp = _pmd_info$
> > > +
> > > +; Ignore fields inserted in place of reserved_opts of
> > rte_security_ipsec_sa_options
> > > +[suppress_type]
> > > + name = rte_ipsec_sa_prm
> > > + name = rte_security_ipsec_sa_options
> > > + has_data_member_inserted_between = {offset_of(reserved_opts), end}
> > > +
> > > +[suppress_type]
> > > + name = rte_security_capability
> > > + has_data_member_inserted_between = {offset_of(reserved_opts),
> > (offset_of(reserved_opts) + 18)}
> > > +
> > > +[suppress_type]
> > > + name = rte_security_session_conf
> > > + has_data_member_inserted_between = {offset_of(reserved_opts),
> > (offset_of(reserved_opts) + 18)}
> >
> > Now, about the suppression rule, I don't understand the intention of
> > those 3 rules.
> >
> > I would simply suppress modifications (after reserved_opts) to the
> > rte_security_ipsec_sa_options struct.
> > Like:
> >
> > ; Ignore fields inserted in place of reserved_opts of
> > rte_security_ipsec_sa_options
> > [suppress_type]
> > name = rte_security_ipsec_sa_options
> > has_data_member_inserted_between = {offset_of(reserved_opts), end}
> >
> I tried this in the first place but abi check was complaining in other structures which included
> rte_security_ipsec_sa_options. So I had to add suppression for those as well.
> Can you try at your end?
I tried before suggesting, and it works with a single rule on this structure.
I'm using libabigail current master, which version are you using so I
can try with the same?
--
David Marchand
next prev parent reply other threads:[~2022-02-08 9:27 UTC|newest]
Thread overview: 184+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 10:02 [dpdk-dev] [PATCH] RFC: ethdev: add reassembly offload Akhil Goyal
2021-08-23 10:18 ` Andrew Rybchenko
2021-08-29 13:14 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-09-21 19:59 ` Thomas Monjalon
2021-09-07 8:47 ` [dpdk-dev] " Ferruh Yigit
2021-09-08 10:29 ` [dpdk-dev] [EXT] " Anoob Joseph
2021-09-13 6:56 ` Xu, Rosen
2021-09-13 7:22 ` Andrew Rybchenko
2021-09-14 5:14 ` Anoob Joseph
2021-09-08 6:34 ` [dpdk-dev] " Xu, Rosen
2021-09-08 6:36 ` Xu, Rosen
2022-01-03 15:08 ` [PATCH 0/8] ethdev: introduce IP " Akhil Goyal
2022-01-03 15:08 ` [PATCH 1/8] " Akhil Goyal
2022-01-11 16:03 ` Ananyev, Konstantin
2022-01-22 7:38 ` Andrew Rybchenko
2022-01-30 16:53 ` [EXT] " Akhil Goyal
2022-01-03 15:08 ` [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Akhil Goyal
2022-01-11 16:09 ` Ananyev, Konstantin
2022-01-11 18:54 ` Akhil Goyal
2022-01-12 10:22 ` Ananyev, Konstantin
2022-01-12 10:32 ` Akhil Goyal
2022-01-12 10:48 ` Ananyev, Konstantin
2022-01-12 11:06 ` Akhil Goyal
2022-01-13 13:31 ` Akhil Goyal
2022-01-13 14:41 ` Ananyev, Konstantin
2022-01-03 15:08 ` [PATCH 3/8] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-01-11 17:04 ` Ananyev, Konstantin
2022-01-11 18:44 ` Akhil Goyal
2022-01-12 10:30 ` Ananyev, Konstantin
2022-01-12 10:59 ` Akhil Goyal
2022-01-13 22:29 ` Ananyev, Konstantin
2022-01-13 13:18 ` Akhil Goyal
2022-01-13 14:36 ` Ananyev, Konstantin
2022-01-13 15:04 ` Akhil Goyal
2022-01-03 15:08 ` [PATCH 4/8] security: add IPsec option for " Akhil Goyal
2022-01-03 15:08 ` [PATCH 5/8] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 0/4] app/test: add inline IPsec and reassembly cases Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 1/4] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 2/4] app/test: add IP reassembly case with no frags Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 3/4] app/test: add IP reassembly cases with multiple fragments Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 4/4] app/test: add IP reassembly negative cases Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 0/4] app/test: add inline IPsec and reassembly cases Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 1/4] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 2/4] app/test: add IP reassembly case with no frags Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 3/4] app/test: add IP reassembly cases with multiple fragments Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 4/4] app/test: add IP reassembly negative cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 00/10] app/test: add inline IPsec and reassembly cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 01/10] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 02/10] test/security: add inline inbound IPsec cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 03/10] test/security: add combined mode inline " Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 04/10] test/security: add inline IPsec reassembly cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 05/10] test/security: add more inline IPsec functional cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 06/10] test/security: add ESN and anti-replay cases for inline Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Akhil Goyal
2022-04-19 8:58 ` Thomas Monjalon
2022-04-19 10:14 ` [EXT] " Akhil Goyal
2022-04-19 10:19 ` Anoob Joseph
2022-04-19 10:37 ` Thomas Monjalon
2022-04-19 10:39 ` Anoob Joseph
2022-04-19 10:47 ` Thomas Monjalon
2022-04-19 12:27 ` Akhil Goyal
2022-04-19 15:41 ` Ray Kinsella
2022-04-20 13:51 ` Akhil Goyal
2022-09-24 13:57 ` [PATCH v5 0/3] Add and test IPsec SA expiry events Akhil Goyal
2022-09-24 13:57 ` [PATCH v5 1/3] ethdev: add IPsec SA expiry event subtypes Akhil Goyal
2022-09-24 14:02 ` Akhil Goyal
2022-09-26 14:02 ` Thomas Monjalon
2022-09-27 18:44 ` [EXT] " Akhil Goyal
2022-09-24 13:57 ` [PATCH v5 2/3] test/security: add inline IPsec SA soft expiry cases Akhil Goyal
2022-09-24 13:57 ` [PATCH v5 3/3] test/security: add inline IPsec SA hard " Akhil Goyal
2022-09-26 17:07 ` [PATCH v6 0/3] Add and test IPsec SA expiry events Akhil Goyal
2022-09-26 17:07 ` [PATCH v6 1/3] ethdev: add IPsec SA expiry event subtypes Akhil Goyal
2022-09-26 17:07 ` [PATCH v6 2/3] test/security: add inline IPsec SA soft expiry cases Akhil Goyal
2022-09-26 17:07 ` [PATCH v6 3/3] test/security: add inline IPsec SA hard " Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 08/10] test/security: add inline IPsec SA soft " Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 09/10] test/security: add inline IPsec SA hard " Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 10/10] test/security: add inline IPsec IPv6 flow label cases Akhil Goyal
2022-04-18 3:44 ` Anoob Joseph
2022-04-18 3:55 ` Akhil Goyal
2022-04-25 12:38 ` [PATCH v4 00/10] app/test: add inline IPsec and reassembly cases Poczatek, Jakub
2022-04-27 15:10 ` [PATCH v5 0/7] " Akhil Goyal
2022-04-27 15:10 ` [PATCH v5 1/7] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-04-27 15:44 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 2/7] test/security: add inline inbound IPsec cases Akhil Goyal
2022-04-27 15:44 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 3/7] test/security: add combined mode inline " Akhil Goyal
2022-04-27 15:45 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 4/7] test/security: add inline IPsec reassembly cases Akhil Goyal
2022-04-27 15:45 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 5/7] test/security: add more inline IPsec functional cases Akhil Goyal
2022-04-27 15:46 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 6/7] test/security: add ESN and anti-replay cases for inline Akhil Goyal
2022-04-27 15:46 ` Zhang, Roy Fan
2022-04-28 5:25 ` Anoob Joseph
2022-04-27 15:10 ` [PATCH v5 7/7] test/security: add inline IPsec IPv6 flow label cases Akhil Goyal
2022-04-27 15:46 ` Zhang, Roy Fan
2022-04-27 15:42 ` [PATCH v5 0/7] app/test: add inline IPsec and reassembly cases Zhang, Roy Fan
2022-05-13 7:31 ` [PATCH v6 " Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 1/7] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 2/7] test/security: add inline inbound IPsec cases Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 3/7] test/security: add combined mode inline " Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 4/7] test/security: add inline IPsec reassembly cases Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 5/7] test/security: add more inline IPsec functional cases Akhil Goyal
2022-05-13 7:32 ` [PATCH v6 6/7] test/security: add ESN and anti-replay cases for inline Akhil Goyal
2022-05-13 7:32 ` [PATCH v6 7/7] test/security: add inline IPsec IPv6 flow label cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 0/7] app/test: add inline IPsec and reassembly cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 1/7] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 2/7] test/security: add inline inbound IPsec cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 3/7] test/security: add combined mode inline " Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 4/7] test/security: add inline IPsec reassembly cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 5/7] test/security: add more inline IPsec functional cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 6/7] test/security: add ESN and anti-replay cases for inline Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 7/7] test/security: add inline IPsec IPv6 flow label cases Akhil Goyal
2022-05-24 8:05 ` [PATCH v7 0/7] app/test: add inline IPsec and reassembly cases Anoob Joseph
2022-05-24 9:38 ` Akhil Goyal
2022-01-03 15:08 ` [PATCH 6/8] app/test: add IP reassembly case with no frags Akhil Goyal
2022-01-03 15:08 ` [PATCH 7/8] app/test: add IP reassembly cases with multiple fragments Akhil Goyal
2022-01-03 15:08 ` [PATCH 8/8] app/test: add IP reassembly negative cases Akhil Goyal
2022-01-06 9:51 ` [PATCH 0/8] ethdev: introduce IP reassembly offload David Marchand
2022-01-06 9:54 ` [EXT] " Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 0/4] " Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 1/4] " Akhil Goyal
2022-01-20 16:45 ` Stephen Hemminger
2022-01-20 17:11 ` [EXT] " Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 2/4] ethdev: add dev op to set/get IP reassembly configuration Akhil Goyal
2022-01-22 8:17 ` Andrew Rybchenko
2022-01-30 16:30 ` [EXT] " Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 3/4] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 4/4] security: add IPsec option for " Akhil Goyal
2022-01-30 17:59 ` [PATCH v3 0/4] ethdev: introduce IP reassembly offload Akhil Goyal
2022-01-30 17:59 ` [PATCH v3 1/4] " Akhil Goyal
2022-02-01 14:11 ` Ferruh Yigit
2022-02-02 10:57 ` [EXT] " Akhil Goyal
2022-02-02 14:05 ` Ferruh Yigit
2022-01-30 17:59 ` [PATCH v3 2/4] ethdev: add dev op to set/get IP reassembly configuration Akhil Goyal
2022-01-30 17:59 ` [PATCH v3 3/4] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-02-01 14:11 ` Ferruh Yigit
2022-02-02 9:13 ` [EXT] " Akhil Goyal
2022-01-30 17:59 ` [PATCH v3 4/4] security: add IPsec option for " Akhil Goyal
2022-02-01 14:12 ` Ferruh Yigit
2022-02-02 9:15 ` [EXT] " Akhil Goyal
2022-02-02 14:04 ` Ferruh Yigit
2022-02-01 14:10 ` [PATCH v3 0/4] ethdev: introduce IP reassembly offload Ferruh Yigit
2022-02-02 9:05 ` [EXT] " Akhil Goyal
2022-02-04 22:13 ` [PATCH v4 0/3] " Akhil Goyal
2022-02-04 22:13 ` [PATCH v4 1/3] " Akhil Goyal
2022-02-04 22:20 ` Akhil Goyal
2022-02-07 13:53 ` Ferruh Yigit
2022-02-07 14:36 ` [EXT] " Akhil Goyal
2022-02-04 22:13 ` [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-02-07 13:58 ` Ferruh Yigit
2022-02-07 14:20 ` [EXT] " Akhil Goyal
2022-02-07 14:56 ` Ferruh Yigit
2022-02-07 16:20 ` Akhil Goyal
2022-02-07 16:41 ` Ferruh Yigit
2022-02-07 17:17 ` Akhil Goyal
2022-02-07 17:23 ` Stephen Hemminger
2022-02-07 17:28 ` Ferruh Yigit
2022-02-07 18:01 ` Stephen Hemminger
2022-02-07 18:28 ` [EXT] " Akhil Goyal
2022-02-07 19:08 ` Stephen Hemminger
2022-02-07 17:29 ` Akhil Goyal
2022-02-04 22:13 ` [PATCH v4 3/3] security: add IPsec option for " Akhil Goyal
2022-02-08 9:01 ` David Marchand
2022-02-08 9:18 ` [EXT] " Akhil Goyal
2022-02-08 9:27 ` David Marchand [this message]
2022-02-08 10:45 ` Akhil Goyal
2022-02-08 13:19 ` Akhil Goyal
2022-02-08 19:55 ` David Marchand
2022-02-08 20:01 ` Akhil Goyal
2022-02-08 20:11 ` [PATCH v5 0/3] ethdev: introduce IP reassembly offload Akhil Goyal
2022-02-08 20:11 ` [PATCH v5 1/3] " Akhil Goyal
2022-02-08 20:11 ` [PATCH v5 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-02-08 20:11 ` [PATCH v5 3/3] security: add IPsec option for " Akhil Goyal
2022-02-08 22:20 ` [PATCH v6 0/3] ethdev: introduce IP reassembly offload Akhil Goyal
2022-02-08 22:20 ` [PATCH v6 1/3] " Akhil Goyal
2022-02-10 8:54 ` Ferruh Yigit
2022-02-10 10:08 ` Andrew Rybchenko
2022-02-10 10:20 ` Ferruh Yigit
2022-02-10 10:30 ` Ferruh Yigit
2022-02-08 22:20 ` [PATCH v6 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-02-10 8:54 ` Ferruh Yigit
2022-02-08 22:20 ` [PATCH v6 3/3] security: add IPsec option for " Akhil Goyal
2022-02-10 8:54 ` [PATCH v6 0/3] ethdev: introduce IP reassembly offload Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xxfHEYPPVk2gZn0OmRsToQbSWrAs1kzMEC-cymQfkZoA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=ferruh.yigit@intel.com \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
--cc=radu.nicolau@intel.com \
--cc=rosen.xu@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).