From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55BA0A10DA for ; Sat, 3 Aug 2019 11:51:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 32A6A1C1C6; Sat, 3 Aug 2019 11:51:45 +0200 (CEST) Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com [209.85.222.68]) by dpdk.org (Postfix) with ESMTP id 824001C1B9 for ; Sat, 3 Aug 2019 11:51:43 +0200 (CEST) Received: by mail-ua1-f68.google.com with SMTP id v18so30583988uad.12 for ; Sat, 03 Aug 2019 02:51:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H6qWZuscix+SZWPLFzaty28RnMOQhwA9j5YeMwFTre0=; b=LpSzciaXLVq1Qt/1HSLVt10nOodEt9M3bANJ098kGoHgsQdkLWYynWYMnbXjYZrgmm PgyIu9usl1q350bpqD8KSgM700jYfoOjKYmTqObkHn7Spdm7wFiGDqU59haFCDdLb37v WEjmhoKI8l+GRGPB/c0t0UEWx4ItCUDkE8+c0mBuBMs5rdn+XC2rf6iY6aujGrLpUWhS FyjRjSzPLzsQieOZ/ECROwJ+H/udBT1AwoQNnIZSff1WmH/UNJxOnp2fR5htQz6My2pN 6L9IV0UfSZSk7VfW7Z9rQlVsUpqhLaUiiELMcqebbLp9NoykFcGYWmx4KQOhCIuVVOtK SO4g== X-Gm-Message-State: APjAAAUXMuVulxrwPQ2B2g2m7mW9ykvq3sW8b7Wa4CXFcjX1ir8goxwP knTY3AtcIoSwcszWsHZ/fI1TauYCXPe712fHdYH4Tw== X-Google-Smtp-Source: APXvYqziu0BXBjBEwChyrGCL4MYMKRHWurX3JmqW2huk9YH6LdsNceGLeXOwYL5d70juOzmfL/hVvq10RiaATQybh1w= X-Received: by 2002:ab0:6198:: with SMTP id h24mr24100415uan.41.1564825902768; Sat, 03 Aug 2019 02:51:42 -0700 (PDT) MIME-Version: 1.0 References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> <2288744.0SrN437FYt@xps> In-Reply-To: <2288744.0SrN437FYt@xps> From: David Marchand Date: Sat, 3 Aug 2019 11:51:31 +0200 Message-ID: To: Thomas Monjalon Cc: dpdk stable , dev , Aaron Conole , Michael Santana Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 2, 2019 at 10:57 PM Thomas Monjalon wrote: > > 01/08/2019 14:27, David Marchand: > > The memory tests currently check that, for normal mode (not legacy mode), > > there is no memory left behind when exiting. > > I think this is the real bug: > we are checking a behaviour that we cannot achieve currently. > > > The problem is that if a ethdev port is allocated when scanning pci > > devices (even if the driver probe fails like when you have a virtio > > management interface attached to the kernel), on exit, dpdk won't free > > the associated memory since ethdev never frees the ethdev memzone. > > As you said in this thread, we could think about how to free it properly > in a future release. > For 19.08, I would suggest to disable the test with a comment > explaining the reason. For 19.08, as long as we test shared builds in the CI, then it just "works", because the net drivers are not loaded. No net driver, no ethdev leak ;-) -- David Marchand