From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 8F59C2B86 for ; Thu, 16 May 2019 10:28:44 +0200 (CEST) Received: by mail-vk1-f194.google.com with SMTP id d7so800733vkf.1 for ; Thu, 16 May 2019 01:28:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Q2925grd1uRpvUemGepYM7TxrG9TqHIFQpzW0KhlFw=; b=Ekoxy5FArC9v/7W6RmN2PjbV1bnQpaSzA93h9jfavVTi0oROk70P9eehdnbcfTWNpZ ovSQ+CSkulIUIHbtV6P6KcwUAXqp7dwRJcXxLutVa8wlWRFWoLr6Jy6UmX2AzTHCWH7Y zCIRjwVyt297oyXKX9tcRf4KN31LCCbHADmNE94E9N1GJTlFjb7silSTogWWtxiAx441 /jH1NYTD8gQpEnoIQ9AgjfdxRxzta/+gFHk8BtE+AqSzKUxM/Q9qHdyIGHC+KhLFkUXn +5bxx/heX7qrdCk+TwhBzl52UMYN44VPo9WUvuhrG2KQwgmaIBpaSW5yruBXIeqaQUuV WKsA== X-Gm-Message-State: APjAAAVeh/lFWCdNs36vm8tDrpfnL+Djfb/0HxTRoSwI6xC3ssd2jqRr /6QhBLGnR7m4oPsFTuZv/TM2/WEQmgb8SFEsB65VmQ== X-Google-Smtp-Source: APXvYqwhveWLqRKr7ax2kIU7y6em2D4IXiC4ZdRWUeWtKUcCCPy590ai+RX8eqIUHkRS3FAKMFDmuOYSImpSem/99IQ= X-Received: by 2002:a1f:a54f:: with SMTP id o76mr20549017vke.86.1557995323042; Thu, 16 May 2019 01:28:43 -0700 (PDT) MIME-Version: 1.0 References: <1557990898-79349-1-git-send-email-yogev@cgstowernetworks.com> In-Reply-To: <1557990898-79349-1-git-send-email-yogev@cgstowernetworks.com> From: David Marchand Date: Thu, 16 May 2019 10:28:31 +0200 Message-ID: To: Yogev Chaimovich Cc: "yongwang@vmware.com" , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 May 2019 08:28:44 -0000 On Thu, May 16, 2019 at 9:10 AM Yogev Chaimovich wrote: I am not sure this is the right fix but I don't know this driver so I will let Yong comment on this. On the form, please, have a look at the recommandations for submitting patches: http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body Coverity issue: 323479 > Fixes: 30f77abe net/vmxnet3: support stats reset > Here, we would expect the Fixes: line as: Fixes: 30f77abecd38 ("net/vmxnet3: support stats reset") > Cc: stable@dpdk.org > > Signed-off-by: yogev ch > Iiuc, your sob line should be: Signed-off-by: Yogev Chaimovich --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c > b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index f54536b..c465996 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct > rte_pci_device *pci_dev) > { > unsigned int i; > struct vmxnet3_hw *hw = dev->data->dev_private; > - struct UPT1_TxStats txStats; > - struct UPT1_RxStats rxStats; > + struct UPT1_TxStats txStats = {0}; > + struct UPT1_RxStats rxStats = {0}; > > VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS); > > -- > 1.9.1 > > -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B1B4AA00E6 for ; Thu, 16 May 2019 10:28:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C3145B1E; Thu, 16 May 2019 10:28:45 +0200 (CEST) Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id 8F59C2B86 for ; Thu, 16 May 2019 10:28:44 +0200 (CEST) Received: by mail-vk1-f194.google.com with SMTP id d7so800733vkf.1 for ; Thu, 16 May 2019 01:28:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5Q2925grd1uRpvUemGepYM7TxrG9TqHIFQpzW0KhlFw=; b=Ekoxy5FArC9v/7W6RmN2PjbV1bnQpaSzA93h9jfavVTi0oROk70P9eehdnbcfTWNpZ ovSQ+CSkulIUIHbtV6P6KcwUAXqp7dwRJcXxLutVa8wlWRFWoLr6Jy6UmX2AzTHCWH7Y zCIRjwVyt297oyXKX9tcRf4KN31LCCbHADmNE94E9N1GJTlFjb7silSTogWWtxiAx441 /jH1NYTD8gQpEnoIQ9AgjfdxRxzta/+gFHk8BtE+AqSzKUxM/Q9qHdyIGHC+KhLFkUXn +5bxx/heX7qrdCk+TwhBzl52UMYN44VPo9WUvuhrG2KQwgmaIBpaSW5yruBXIeqaQUuV WKsA== X-Gm-Message-State: APjAAAVeh/lFWCdNs36vm8tDrpfnL+Djfb/0HxTRoSwI6xC3ssd2jqRr /6QhBLGnR7m4oPsFTuZv/TM2/WEQmgb8SFEsB65VmQ== X-Google-Smtp-Source: APXvYqwhveWLqRKr7ax2kIU7y6em2D4IXiC4ZdRWUeWtKUcCCPy590ai+RX8eqIUHkRS3FAKMFDmuOYSImpSem/99IQ= X-Received: by 2002:a1f:a54f:: with SMTP id o76mr20549017vke.86.1557995323042; Thu, 16 May 2019 01:28:43 -0700 (PDT) MIME-Version: 1.0 References: <1557990898-79349-1-git-send-email-yogev@cgstowernetworks.com> In-Reply-To: <1557990898-79349-1-git-send-email-yogev@cgstowernetworks.com> From: David Marchand Date: Thu, 16 May 2019 10:28:31 +0200 Message-ID: To: Yogev Chaimovich Cc: "yongwang@vmware.com" , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: uninitialized variable fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190516082831.M2WXGMN9hdl7DodKo758g9GIWNmLBvr88ah-byMq__k@z> On Thu, May 16, 2019 at 9:10 AM Yogev Chaimovich wrote: I am not sure this is the right fix but I don't know this driver so I will let Yong comment on this. On the form, please, have a look at the recommandations for submitting patches: http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body Coverity issue: 323479 > Fixes: 30f77abe net/vmxnet3: support stats reset > Here, we would expect the Fixes: line as: Fixes: 30f77abecd38 ("net/vmxnet3: support stats reset") > Cc: stable@dpdk.org > > Signed-off-by: yogev ch > Iiuc, your sob line should be: Signed-off-by: Yogev Chaimovich --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c > b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index f54536b..c465996 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -1132,8 +1132,8 @@ static int eth_vmxnet3_pci_remove(struct > rte_pci_device *pci_dev) > { > unsigned int i; > struct vmxnet3_hw *hw = dev->data->dev_private; > - struct UPT1_TxStats txStats; > - struct UPT1_RxStats rxStats; > + struct UPT1_TxStats txStats = {0}; > + struct UPT1_RxStats rxStats = {0}; > > VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS); > > -- > 1.9.1 > > -- David Marchand