From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B649A00BE; Wed, 29 Apr 2020 10:17:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B0201D960; Wed, 29 Apr 2020 10:17:22 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 758591D95F for ; Wed, 29 Apr 2020 10:17:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588148240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PpBIpC2AcToCMoYosNkhTSh3BWOqdPWJ5zRKCZPugLs=; b=FnRVCorCNakB+PxbfqDRqa4puDvOIcAxAt3Q1PER3inRxiE+y0wW6JAqnCxyj6c6pxlejH GtRUAuouAFMbyL82N5O43ZKpLmrKcKmqYqoym61bjMpP4z8bfgodFqekqpgS/nxNje7nqy QlFCTNmMOOVoYvW9dbP7RY+VNwVJgw0= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-118-vAU7pVuGPUahN203codSFw-1; Wed, 29 Apr 2020 04:17:19 -0400 X-MC-Unique: vAU7pVuGPUahN203codSFw-1 Received: by mail-ua1-f71.google.com with SMTP id w1so966480uaq.0 for ; Wed, 29 Apr 2020 01:17:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QH2RiR1T25L7z8iG2lE8Bn17yRnDspjCtrPwpCnv2f0=; b=ubYAmM0ZqvuIOa+cPQx96i5JVKOQ/BwN5lWjn9qwrvGOua0BNjpSwBB0D0/C8Cnea9 mll1im3aVQWtIGQcKR5isCab8kZ0Rg00veNZHtU/NPrWKVqAAYd+qPbD6qB4fOc+2CJl 6nvlm+1/uJmDUIuz3wkSsMLRNZzntPSWDEhhWjaBmafp0T9WwFm6gs630HW89rIEYPTj EYwo6XceUJOTRpmzxSrCJ87qkoMmmvktls2fqtJqNBWLBZLtSpycM3CB6xuhsU2tinsF +U6QS5kfXs5JIxxeZ6+gvQnHCn6LdZNKzs9RrsaczSjMkmnbKd/z60EtZwMxrZ5RwTkz 6wjQ== X-Gm-Message-State: AGi0PuZSXBN6aNbUaROflvbumfdwcX3dKFyuBdgL8Evd9Ou0ukshH+LB ZzEYwrn2Wj2wOcwbkJ6T7ST7HbKxY5jSTvXwLcQWkRJ/hBNu+BXpczN8aqiBOS7KNpjgVcJJGNV Wd18hw1iTkysyVzfVsVQ= X-Received: by 2002:ab0:485:: with SMTP id 5mr23707329uaw.86.1588148238700; Wed, 29 Apr 2020 01:17:18 -0700 (PDT) X-Google-Smtp-Source: APiQypJ3dqUPs6YoKtIZ0MXyjkpvbGKelU1s7Y23gUMPAHfas0oXkgsUxlUuTQaJ8uAB4GFWCbPUeel4lhH39h4muPU= X-Received: by 2002:ab0:485:: with SMTP id 5mr23707316uaw.86.1588148238427; Wed, 29 Apr 2020 01:17:18 -0700 (PDT) MIME-Version: 1.0 References: <1588060706-27316-1-git-send-email-orika@mellanox.com> In-Reply-To: <1588060706-27316-1-git-send-email-orika@mellanox.com> From: David Marchand Date: Wed, 29 Apr 2020 10:17:07 +0200 Message-ID: To: Ori Kam Cc: Thomas Monjalon , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , David Christensen , dev , "Yigit, Ferruh" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 28, 2020 at 9:59 AM Ori Kam wrote: > > The AltiVec header file breaks boolean type. [1] [2] > > Currently the workaround was located only in mlx5 device. > Adding the trace module caused this issue to appear again, due to > order of includes, it keeps overriding the local fix. > > This patch solves this issue by resetting the bool type, immediately > after it is being changed. With this patch applied, there are still a few remaining spots as mentioned by David C. I see rte_vect.h too. $ git grep -w altivec.h MAINTAINERS:F: examples/l3fwd/*altivec.h drivers/net/i40e/i40e_rxtx_vec_altivec.c:#include drivers/net/mlx5/mlx5_rxtx_vec_altivec.h:#include drivers/net/virtio/virtio_rxtx_simple_altivec.c:#include lib/librte_eal/ppc/include/rte_altivec.h:/* To include altivec.h, GCC version must be >=3D 4.8 */ lib/librte_eal/ppc/include/rte_altivec.h:#include lib/librte_eal/ppc/include/rte_vect.h:#include > diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h b/lib/librte_eal/ppc= /include/rte_memcpy.h > index 25311ba..d234e21 100644 > --- a/lib/librte_eal/ppc/include/rte_memcpy.h > +++ b/lib/librte_eal/ppc/include/rte_memcpy.h > @@ -8,13 +8,12 @@ > > #include > #include > -/*To include altivec.h, GCC version must >=3D 4.8 */ > -#include Why move the inclusion under the __cplusplus check? > > #ifdef __cplusplus > extern "C" { > #endif > > +#include "rte_altivec.h" > #include "generic/rte_memcpy.h" > > static inline void > -- > 1.8.3.1 > Thanks. --=20 David Marchand