From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F699A04E0; Thu, 28 Nov 2019 12:02:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F07B2B96; Thu, 28 Nov 2019 12:02:57 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id BA1F2293C for ; Thu, 28 Nov 2019 12:02:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574938975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RElOE6bAR573Wz7eVF3o1Z7D4/0Caofj4Ka1MxIK0kQ=; b=TDML0Zad79Qae2DIUu0zRliDlXFRee9hjk51/5uiAUP3QTznzBPC9ueK+CAFyRGvFeBtwJ 1Fe9U4w5TKicucWF32JAsm/EkxpV8zlt66RbAEADwbBQO4elWx5Z7uGe+NdgXS+VDDDi9q 2gMImvebruHVBZ4Lt5BXfLgSfK1LFiE= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-LfuJih3ZN961PyCjyAwudA-1; Thu, 28 Nov 2019 06:02:52 -0500 Received: by mail-ua1-f72.google.com with SMTP id x2so4641155uaj.21 for ; Thu, 28 Nov 2019 03:02:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RElOE6bAR573Wz7eVF3o1Z7D4/0Caofj4Ka1MxIK0kQ=; b=socHz4ilh72q4tk2KfNmn9A6xwebZ9Ezq6ezmLS/UsfmFwaDOTi1DdYzm4yvrWsgUX /WoPxxg2StyHSZ85hJrZXuB8dlha5ql5g6hv5SgHWRiycaKWAgX+wmGWEcGf4em6ONF9 mznPeLoRVSNDBwWr8QyZI1it438uD8sZFvdgxi+uaOLiprQxt5rHjW/IBdyHBArsQpRf psVkrUxKEMtyVwanR7r48SSaoI2SJPTdMhC8DjVAk7LAJg6cPAC84l0QpfkqjeUcYFCi 75LgCdh/ePPOoK7TTrlU+zceEUi+E3cSXnojDQy05u3xYwtyD8abYt6xQivOCLCtC/IJ aUeA== X-Gm-Message-State: APjAAAUXl1fXqXifID4G9VleoEmkCCrLm7uxE1EgzyW7J+d+gZDPAqp1 frYZSox23umSOJD7iV3H0kUDehUzohFWNF70YHgXS/1gkGnVUIaY5rQ+el8gTeofczyfwjm6OjU HQywstCef3WSOOjRHZHs= X-Received: by 2002:a67:b303:: with SMTP id a3mr196116vsm.141.1574938971296; Thu, 28 Nov 2019 03:02:51 -0800 (PST) X-Google-Smtp-Source: APXvYqyfdMDkNrW4sJbxGV9/dGGXeKTfSeofY7mR7YPJAHisgPxLmMYGUBhz/41esrhs1bPKTy2ZjbnPkdwiBiyOdo0= X-Received: by 2002:a67:b303:: with SMTP id a3mr196085vsm.141.1574938970748; Thu, 28 Nov 2019 03:02:50 -0800 (PST) MIME-Version: 1.0 References: <20191120160009.46270-1-ferruh.yigit@intel.com> <20191120172227.42798-1-ferruh.yigit@intel.com> In-Reply-To: From: David Marchand Date: Thu, 28 Nov 2019 12:02:39 +0100 Message-ID: To: Andrew Rybchenko Cc: Vamsi Attunuru , Jerin Jacob , Ferruh Yigit , John McNamara , Marko Kovacevic , dev , Kiran Kumar K , Igor Ryzhov , Thomas Monjalon X-MC-Unique: LfuJih3ZN961PyCjyAwudA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 28, 2019 at 11:45 AM Andrew Rybchenko wrote: > > On 11/21/19 1:30 AM, David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:28 PM David Marchand > > wrote: > >> On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit = wrote: > >>> A build error reported related to the selected > >>> 'get_user_pages_remote()' kernel API: > >>> > >>> .../kernel/linux/kni/kni_dev.h:113:8: > >>> error: too few arguments to function =E2=80=98get_user_pages_remote= =E2=80=99 > >>> ret =3D get_user_pages_remote(tsk, tsk->mm, iova, 1 > >>> ^~~~~~~~~~~~~~~~~~~~~ > >>> > >>> Currently there are three version of the 'get_user_pages_remote()' > >>> supported, based on kernel version > >>> < 4.9, =3D 4.9, > 4.9 > >>> > >>> These version based checks are not working fine with the distro kerne= ls > >>> which is the cause of reported build error. The error reported by the > >>> kernel version 4.8, but it is using API defined in > 4.9. > >>> > >>> To be able to take control of this, and possible more, related build > >>> error, increasing the minimum supported kernel version for iova=3Dva = with > >>> KNI to kernel version 4.9. > >>> > >>> This leaves us with single version of the kernel API and more > >>> manageable. > >>> > >>> Signed-off-by: Ferruh Yigit > > Reviewed-by: David Marchand > > > > We need this change to fix compilation issues for -rc3. > > Applied, thanks. > > The build is still broken on Debian 9 stretch which has Linux 4.9.189, > but corresponding function still has no the last argument. > It looks like requirements should be bumped to >=3D4.10.0. It came with: 5b56d49fc31d - mm: add locked parameter to get_user_pages_remote() (2 years, 11 months ago) $ git describe --contains 5b56d49fc31d v4.10-rc1~110^2~56 The check on > 4.9.0 is wrong, it should be >=3D 4.10.0 yes. --=20 David Marchand