DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Sunil Kumar Kori <skori@marvell.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
	Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>,
	 dpdk stable <stable@dpdk.org>,
	Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] eal: fix log message print for regex
Date: Fri, 13 Mar 2020 10:46:26 +0100	[thread overview]
Message-ID: <CAJFAV8xzTVDsFr05WzzVTd3DYaMkygASFSqXnLJha3U5k8wMww@mail.gmail.com> (raw)
In-Reply-To: <CALBAE1NEcmQABkf5FOPbzUdZyLfgMKvvrfDtnk06==RC=WiJyA@mail.gmail.com>

On Mon, Mar 9, 2020 at 8:08 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Mon, Mar 9, 2020 at 11:47 AM Sunil Kumar Kori <skori@marvell.com> wrote:
> >
> > If user passes log-level eal parameter to enable log level based on regex
> > then in case of error message is being printed for pattern match instead of
> > regex. Following is the warning message thrown:
> >
> > Compiling C object 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_options.c.o'.
> > In function ‘eal_parse_log_level’,
> >    inlined from ‘eal_parse_common_option’ at ../lib/librte_eal/common/eal_common_options.c:1418:7:
> > ../lib/librte_eal/common/eal_common_options.c:1053:4: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
> >  1053 |    fprintf(stderr, "cannot set log level %s,%d\n",
> >       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >  1054 |     pattern, priority);
> >       |     ~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> > Acked-by: David Marchand <david.marchand@redhat.com>
>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>

I did not reproduce this with this format-overflow flag...
Anyway, applied.


-- 
David Marchand


      reply	other threads:[~2020-03-13  9:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27  8:25 [dpdk-dev] [PATCH] " Sunil Kumar Kori
2020-02-27 10:57 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-02-27 11:02   ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-03-03  9:55     ` David Marchand
2020-03-09  6:15 ` [dpdk-dev] [PATCH v2 1/1] " Sunil Kumar Kori
2020-03-09  6:17 ` Sunil Kumar Kori
2020-03-09  7:08   ` Jerin Jacob
2020-03-13  9:46     ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xzTVDsFr05WzzVTd3DYaMkygASFSqXnLJha3U5k8wMww@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinjacobk@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=skori@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).