From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAAC9A0567; Fri, 13 Mar 2020 10:46:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AAB1E1C00E; Fri, 13 Mar 2020 10:46:41 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 94D521BFFF for ; Fri, 13 Mar 2020 10:46:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584092800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QhyXRkhbXKhq70FtjIv1cChXqaMqv4ApnsQpC9jucnw=; b=RAvLqfk2KbWwQ+E+1TVcDKyuVYtnR/HyuEva0vWQj9jrlztyCtXZe0c1RzFt1LFXiTxk05 n8t2CG2L3h5BwLwQpecnYSBe7LDKV7sggx/27Y7wJK/KJx1NPZ5S15WbQU+iwCmTJ99dDh kt5qv0uFnVDET9Uq7gG8JntYOIYCd4I= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-256-6avC8itlPwqOt7Mria90Tg-1; Fri, 13 Mar 2020 05:46:38 -0400 X-MC-Unique: 6avC8itlPwqOt7Mria90Tg-1 Received: by mail-vk1-f200.google.com with SMTP id g26so3511552vkk.12 for ; Fri, 13 Mar 2020 02:46:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QhyXRkhbXKhq70FtjIv1cChXqaMqv4ApnsQpC9jucnw=; b=Nn6WdrNAah3bXiifnlh/zUJra27Q4eLLLxl3O0Io6OKAMhVLR+jeSaiiQkhmbszpUt XG7JjyCofhp9sLfKKRk2aZmrmsRjQS5jje/2/h/iAK+5/kx6ymhHSpC3qEArVKN75PbJ KQjjIoKv9f0Cgh9HpWFiIdDJAOeguFQZZ0gPjp9v8KfQjau4oa1TnWokOFxeZuU1tftI uNHldxqr3yNkWSV8o23hsZ3XJTfJ19D9mzyi8KVvSJxKQsG3qlBZ+vFFMnMKzIvspXN2 KYg6nhFDOgP0rlN09G6o/y9C2Iu/qnjQMwFqcQ3LOeThDXe7Sh0BkFGLRAKw69wo7rKm RtsA== X-Gm-Message-State: ANhLgQ2Muw31aRFqxFo8ToBC6unW4wVfume2wqnOg+PdVS8wyh9k6dxw N84i+Qureb9m3uZ6aIcpYBrUOHEjW2PYDlh+J8pD8EBFwjFL3SzUb2td0w2fuwQvMDAk3pH7DvQ pdEflsAX/+vTQOh2ZH24= X-Received: by 2002:a1f:9d8a:: with SMTP id g132mr8311980vke.39.1584092798017; Fri, 13 Mar 2020 02:46:38 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtjTupoN7xJ3rcvxE9xSAVdnmQf5MgZPrjk6/f8xIJHQA1nKD8PdoszzN1Gn4KvFDoOuC59bDyVSspyznOyBAQ= X-Received: by 2002:a1f:9d8a:: with SMTP id g132mr8311970vke.39.1584092797790; Fri, 13 Mar 2020 02:46:37 -0700 (PDT) MIME-Version: 1.0 References: <20200227082506.25349-1-skori@marvell.com> <20200309061723.19732-1-skori@marvell.com> In-Reply-To: From: David Marchand Date: Fri, 13 Mar 2020 10:46:26 +0100 Message-ID: To: Sunil Kumar Kori Cc: Olivier Matz , Thomas Monjalon , dpdk-dev , dpdk stable , Jerin Jacob X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 1/1] eal: fix log message print for regex X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 9, 2020 at 8:08 AM Jerin Jacob wrote: > > On Mon, Mar 9, 2020 at 11:47 AM Sunil Kumar Kori wrot= e: > > > > If user passes log-level eal parameter to enable log level based on reg= ex > > then in case of error message is being printed for pattern match instea= d of > > regex. Following is the warning message thrown: > > > > Compiling C object 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_comm= on_options.c.o'. > > In function =E2=80=98eal_parse_log_level=E2=80=99, > > inlined from =E2=80=98eal_parse_common_option=E2=80=99 at ../lib/lib= rte_eal/common/eal_common_options.c:1418:7: > > ../lib/librte_eal/common/eal_common_options.c:1053:4: warning: =E2=80= =98%s=E2=80=99 directive argument is null [-Wformat-overflow=3D] > > 1053 | fprintf(stderr, "cannot set log level %s,%d\n", > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 1054 | pattern, priority); > > | ~~~~~~~~~~~~~~~~~~ > > > > Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing"= ) > > Cc: stable@dpdk.org > > > > Signed-off-by: Sunil Kumar Kori > > Acked-by: David Marchand > > Reviewed-by: Jerin Jacob I did not reproduce this with this format-overflow flag... Anyway, applied. --=20 David Marchand