From: David Marchand <david.marchand@redhat.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: "Wang, Yipeng1" <yipeng1.wang@intel.com>,
Byron Marohn <byron.marohn@intel.com>, dev <dev@dpdk.org>,
techboard@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,
David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] efd: change data type of parameter
Date: Tue, 14 Sep 2021 09:10:51 +0200 [thread overview]
Message-ID: <CAJFAV8xz_XQRNMDZZbX0MQ87-pU=29p3cdxcSpcH2eSw8W=6oQ@mail.gmail.com> (raw)
In-Reply-To: <20210910165346.807715-1-pablo.de.lara.guarch@intel.com>
On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara
<pablo.de.lara.guarch@intel.com> wrote:
>
> rte_efd_create() function was using uint8_t for a socket bitmask,
> for one of its parameters.
> This limits the maximum of NUMA sockets to be 8.
> Changing to to uint64_t increases it to 64, which should be
> more future-proof.
Cc: ppc maintainer, since I think powerX servers have non contiguous
NUMA sockets.
>
> Coverity issue: 366390
> Fixes: 56b6ef874f8 ("efd: new Elastic Flow Distributor library")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>
> This fix requires an API breakage and therefore it is not
> a good candidate for backporting (besides, it is a very low impact bug).
> Hence, I am not CC'ing stable.
This is an unannounced breakage for a stable API.
Cc: techboard + Ray for awareness.
>
> ---
>
> lib/efd/rte_efd.c | 2 +-
> lib/efd/rte_efd.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c
> index 77f46809f8..68a2378e88 100644
> --- a/lib/efd/rte_efd.c
> +++ b/lib/efd/rte_efd.c
> @@ -495,7 +495,7 @@ efd_search_hash(struct rte_efd_table * const table,
>
> struct rte_efd_table *
> rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,
> - uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket)
> + uint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket)
> {
> struct rte_efd_table *table = NULL;
> uint8_t *key_array = NULL;
> diff --git a/lib/efd/rte_efd.h b/lib/efd/rte_efd.h
> index c2be4c09ae..d3d7befd0c 100644
> --- a/lib/efd/rte_efd.h
> +++ b/lib/efd/rte_efd.h
> @@ -139,7 +139,7 @@ typedef uint16_t efd_hashfunc_t;
> */
> struct rte_efd_table *
> rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len,
> - uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket);
> + uint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket);
>
> /**
> * Releases the resources from an EFD table
> --
> 2.25.1
>
--
David Marchand
next prev parent reply other threads:[~2021-09-14 7:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 16:53 Pablo de Lara
2021-09-13 18:18 ` Mcnamara, John
2021-09-14 7:10 ` David Marchand [this message]
2021-09-14 10:49 ` Kinsella, Ray
2021-09-14 18:20 ` David Christensen
2021-09-17 12:56 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2021-09-20 19:30 ` David Christensen
2021-09-28 14:18 ` De Lara Guarch, Pablo
2021-09-28 13:58 ` [dpdk-dev] [PATCH v4] " Pablo de Lara
2021-09-28 15:52 ` David Christensen
2021-09-29 7:51 ` De Lara Guarch, Pablo
2021-09-29 17:41 ` David Christensen
2021-09-29 18:13 ` Wang, Yipeng1
2021-10-01 14:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xz_XQRNMDZZbX0MQ87-pU=29p3cdxcSpcH2eSw8W=6oQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=byron.marohn@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=mdr@ashroe.eu \
--cc=pablo.de.lara.guarch@intel.com \
--cc=techboard@dpdk.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).