From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCEE3A0C47; Tue, 14 Sep 2021 09:11:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52380410DC; Tue, 14 Sep 2021 09:11:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 1A0584068F for ; Tue, 14 Sep 2021 09:11:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631603467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=arEDT2UvfTyFSy883FN/zZrqBLGo3CBhP76uo1IvDrg=; b=eRaNnbTfQA+xAbSfZ8rErJxdIKWXcFNg4j3cC0CgWIsdmQL5cJKECGpYplG4+vsGpx/m0t ibx3X6el+xwnIb2Ytonc1Ln3iFp6Iy0zgAUJl+2DB87YwIaJW3YsOXmIOCR8iNg0DvwQ+f Cgm4BFwSEPYlxLBnxvcrkWTFYa+Jr94= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-1bG9UsXmNmqnhjvevszBCQ-1; Tue, 14 Sep 2021 03:11:04 -0400 X-MC-Unique: 1bG9UsXmNmqnhjvevszBCQ-1 Received: by mail-lf1-f72.google.com with SMTP id bp18-20020a056512159200b003eb84833c98so4012728lfb.14 for ; Tue, 14 Sep 2021 00:11:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=arEDT2UvfTyFSy883FN/zZrqBLGo3CBhP76uo1IvDrg=; b=hpVsh+32js9dZnwLHW6L7ulla2WwWS0T+fLfBhlU0VveNnSdG2CifHw+9cxPAto7VO jMmv+qilcf0aAW+KSbXFA5dKRzNCoMdkYnmWTst3Wof2IrcsO+szE712b/fm5xcLrMji FFq87APB/yWLgNeSFKQjjPmwaedO3FMZNmhVcsvqH8+dq0DWCu1i/Cg7/5xB4BO+KK45 HKRu0KT0XzU1moLXPUgeMP60fEVmWyEd0iXKmpKroOdYLTkgbCsGc/18wV701u04xK/S 8EfXBzBMKZCxmkxx3wZktYdnEd5Q0Yn4qAiHvXip/bpkujbfWAZiKDRR+CAigJu/Yj6T Q3yg== X-Gm-Message-State: AOAM531+6FTh0RFVMdkvMLRRbTwwaoJMIPzLuSWbR7sI5CqgFJSZuR/X Gqfm/3TL913XhAzBMqto6s76oAo8sIMbheaNBjQt2YTvWC5sx2ADX4kS7dW4Zez/RyaP4JyPNlY VfpJXhvZFiyQIQrxBjWI= X-Received: by 2002:a2e:a230:: with SMTP id i16mr13948337ljm.333.1631603462588; Tue, 14 Sep 2021 00:11:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTv1ovgrRPzMGIOTsDSfK6pLYH/WyiwJjuJFUnTokw53ALKxKQJ9rKuqbYjGY8vi4eZ6ONJ8SRUCZQNDnZWYs= X-Received: by 2002:a2e:a230:: with SMTP id i16mr13948327ljm.333.1631603462377; Tue, 14 Sep 2021 00:11:02 -0700 (PDT) MIME-Version: 1.0 References: <20210910165346.807715-1-pablo.de.lara.guarch@intel.com> In-Reply-To: <20210910165346.807715-1-pablo.de.lara.guarch@intel.com> From: David Marchand Date: Tue, 14 Sep 2021 09:10:51 +0200 Message-ID: To: Pablo de Lara Cc: "Wang, Yipeng1" , Byron Marohn , dev , techboard@dpdk.org, Ray Kinsella , David Christensen Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] efd: change data type of parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara wrote: > > rte_efd_create() function was using uint8_t for a socket bitmask, > for one of its parameters. > This limits the maximum of NUMA sockets to be 8. > Changing to to uint64_t increases it to 64, which should be > more future-proof. Cc: ppc maintainer, since I think powerX servers have non contiguous NUMA sockets. > > Coverity issue: 366390 > Fixes: 56b6ef874f8 ("efd: new Elastic Flow Distributor library") > > Signed-off-by: Pablo de Lara > --- > > This fix requires an API breakage and therefore it is not > a good candidate for backporting (besides, it is a very low impact bug). > Hence, I am not CC'ing stable. This is an unannounced breakage for a stable API. Cc: techboard + Ray for awareness. > > --- > > lib/efd/rte_efd.c | 2 +- > lib/efd/rte_efd.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c > index 77f46809f8..68a2378e88 100644 > --- a/lib/efd/rte_efd.c > +++ b/lib/efd/rte_efd.c > @@ -495,7 +495,7 @@ efd_search_hash(struct rte_efd_table * const table, > > struct rte_efd_table * > rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len, > - uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket) > + uint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket) > { > struct rte_efd_table *table = NULL; > uint8_t *key_array = NULL; > diff --git a/lib/efd/rte_efd.h b/lib/efd/rte_efd.h > index c2be4c09ae..d3d7befd0c 100644 > --- a/lib/efd/rte_efd.h > +++ b/lib/efd/rte_efd.h > @@ -139,7 +139,7 @@ typedef uint16_t efd_hashfunc_t; > */ > struct rte_efd_table * > rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len, > - uint8_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket); > + uint64_t online_cpu_socket_bitmask, uint8_t offline_cpu_socket); > > /** > * Releases the resources from an EFD table > -- > 2.25.1 > -- David Marchand