From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68FE0A046B; Thu, 9 Jan 2020 15:09:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39F0D1DDD7; Thu, 9 Jan 2020 15:09:11 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id AC70C1DDBD for ; Thu, 9 Jan 2020 15:09:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578578949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y8SLQ+H+6y6QF3Drv+yrQnvtTV7+w3khEtrQv+1aGDM=; b=HphgHSqjkbQc9YGudXKiUqzQLEVsJmT4Lzl9K4iHqKlLUdMCAGEUFgD6EEGj+VocIEGHI4 B/8gZNFTjra3J2ZtHqxlTyuRholfoDB4HiN1fW7mdzBD741Vh8VXff350d8EfAUOB8MAby mzOyqRr5GpfXkW7NSDMFmmtUQizAc90= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142--RHGKcxXPjejzbGfffsK5g-1; Thu, 09 Jan 2020 09:09:08 -0500 Received: by mail-ua1-f71.google.com with SMTP id o13so1455602uad.7 for ; Thu, 09 Jan 2020 06:09:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HRMTp6ujQ9p0+cCy0CRT3PSmjjjtMxkriKaVwCoJodM=; b=gEbi6Y1qmqt+vNi6d+9YYMbRQ7k8iYqPaK6MiY2sAV41RgLJ6we1Niw8YH25wqH0Fo 1fR+2xvicgtnM+wovs0KNWXGP/zuqP32w7XCYQj85xus6ffe4uoVQyQSrflkBsONuDRO 70WoN2sVwrqKpz0oHfn+TfY0eQansjg+s4a0xEObsn5nDhH2zNicduZNi/bMrwSA8fX8 dGBNhxbQCPo4c3wEa/Y2C6co26RhO2t3qukF7TC22W7SBqPtAs6lUVS+nyp4zGi+dPGE IGO+mORNL6J0tjKOrUSDTsjha7MYGwmaKH+60pEdJ1soRN/kEI9tzzRhlZ8xTXnq5n7x hoCA== X-Gm-Message-State: APjAAAWg7dV8Uo7mQ14K7mzGhnlGTKOGOF0EeyVSc9ijSlEVmRmcXbK9 dkw4IQJ2HnSw1npig907aaYrFfl5FJEBK24jmoT1Azrf7e0fDDy80XBA5/Duntd7LxKiFuEABZx khhdPAFRhMqkaUEl9gOI= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr5868631vsm.180.1578578947338; Thu, 09 Jan 2020 06:09:07 -0800 (PST) X-Google-Smtp-Source: APXvYqwxg62E1XBwD9YzUCuUXNe8szzXpK/w4bCYE4Ks3IfRtpSMRh0iGg/l8uOyGrxJhC4RSSG6zGA+yeLn2va1mW8= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr5868603vsm.180.1578578946969; Thu, 09 Jan 2020 06:09:06 -0800 (PST) MIME-Version: 1.0 References: <20200109125916.32073-1-david.marchand@redhat.com> <20200109130900.GB248@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200109130900.GB248@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 9 Jan 2020 15:08:55 +0100 Message-ID: To: David Marchand Cc: dev , Luca Boccassi , Aaron Conole , dpdk stable , Thomas Monjalon , Ranjit Menon , Jeff Shaw , Pallavi Kadam , Harini Ramakrishnan , Bruce Richardson X-MC-Unique: -RHGKcxXPjejzbGfffsK5g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] build: fix libm detection in meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 9, 2020 at 2:09 PM Bruce Richardson wrote: > > On Thu, Jan 09, 2020 at 01:59:15PM +0100, David Marchand wrote: > > Using version 0.47.1, meson is unable to find the math library in Travi= s > > for the 32bits job. > > Quite surprisingly, this problem is not seen with the 64bits jobs. > > > > Switching to 0.48.0, the problem disappears. > > > > But we should pass 'm' to find_library instead of 'libm' anyway. > > > > Fixes: 98edcbb5ab2f ("eal/windows: introduce Windows support") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > > config/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/config/meson.build b/config/meson.build > > index 01911ecf9..28a57f56f 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -115,7 +115,7 @@ add_project_link_arguments('-pthread', language: 'c= ') > > dpdk_extra_ldflags +=3D '-pthread' > > > > # on some OS, maths functions are in a separate library > > -if cc.find_library('libm', required : false).found() > > +if cc.find_library('m', required : false).found() > > # some libs depend on maths lib > > add_project_link_arguments('-lm', language: 'c') > > dpdk_extra_ldflags +=3D '-lm' > > -- > > 2.23.0 > Acked-by: Bruce Richardson Series applied. --=20 David Marchand