From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61558A057F; Tue, 22 Nov 2022 09:52:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52CD042D45; Tue, 22 Nov 2022 09:52:09 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 855C2427EB for ; Tue, 22 Nov 2022 09:52:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669107127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V+T9C1AKBG5mOv9P5Ueqidg2VD+r33huEfBpF4+Y2Fw=; b=LD/c9ux9nEB9FgKBw4vEyUI32PHVyLEV+fuZ265BVRwRsJXL3qlcxeC3QQM1X4CtjZUjpW xzh9FJjpD+VeFRR9VrGONp0qj//aqfv3y/MoMwASvBNQEcSCCfnfrA4rZ+5la0Xh647+R/ TPN2hEh0JAQK82mgZgZPop61HIzDDSs= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-278-RZFVhpqdN3WQL7AoRosM5Q-1; Tue, 22 Nov 2022 03:52:05 -0500 X-MC-Unique: RZFVhpqdN3WQL7AoRosM5Q-1 Received: by mail-pl1-f197.google.com with SMTP id f12-20020a170902ce8c00b0018928092ec9so3169916plg.22 for ; Tue, 22 Nov 2022 00:52:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V+T9C1AKBG5mOv9P5Ueqidg2VD+r33huEfBpF4+Y2Fw=; b=FgCYg7F9CwW1XvDQv5jDW5A7gCNyeApeYPOalBVB8JcXlCng7YnHtPHYuSFDZGS3Tu NVCgKwpjrQKwdL+8Ce/gdyUgmnHLYOCVEqVQXivcDfVBCIB3RMeHHTnRcRy+mQouDh29 U14x6wQgSBBHjQLVX9Z3BZ2j/I9AOyE3F27sGvF/J49Ippogf96WpwmNyriOkxkOXfpf XH90GWD/0rOm6G56ECffvzij2s8gHZKojqbrMpl5dROoS+FPyJVMH/JFeLk5IkofN/hj asl3shvvxEKOT/p+SFzjrLloexueGJBu8iPe77yhRuz8tEdiIqMxPEdxRbJi/UBfZEws Pz7w== X-Gm-Message-State: ANoB5pkF3aCNSAMdovy65JV0ELOs3CWTaKBpzyHHeOjuQm5mMvuOnCVI HGM/GtLTF9LGdUgyimkNR73+FQwy0JQGvI19Qt02G5qUkJOB+i3GvriX8Ny8qDqF/SBSDz/uRhr +MuSfh7WKKbckh++H/bM= X-Received: by 2002:a63:110e:0:b0:477:86c1:640d with SMTP id g14-20020a63110e000000b0047786c1640dmr3945640pgl.223.1669107124671; Tue, 22 Nov 2022 00:52:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf45TEe2U8fZXX3xHCXUuFrsGoe6uILApT+HGpb1ZeWIBr1Mongl2cdrAlakR0pMPhjTahTs5eESHUFYthK8e/4= X-Received: by 2002:a63:110e:0:b0:477:86c1:640d with SMTP id g14-20020a63110e000000b0047786c1640dmr3945626pgl.223.1669107124430; Tue, 22 Nov 2022 00:52:04 -0800 (PST) MIME-Version: 1.0 References: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com> <20221121195327.GA24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7452459.EvYhyI6sBW@thomas> <20221121224856.GB24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20221121224856.GB24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Tue, 22 Nov 2022 09:51:53 +0100 Message-ID: Subject: Re: [PATCH] ring: build with global includes To: Tyler Retzlaff , Thomas Monjalon Cc: Bruce Richardson , Konstantin Ananyev , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff wrote: > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > 21/11/2022 22:27, Konstantin Ananyev: > > > From: Tyler Retzlaff > > > > e.g. i don't see. > > > > > > > > deps += ['eal'] > > > > > > > > is the dependency on eal the library or just eal headers? because if it > > > > is header only it is equivalent to telemetry i think? > > > > > > rte_ring.c uses bunch of EAL functions: > > > rte_zmalloc, rte_memzone_*, rte_log*, rte_mcfg*, etc. > > > > I think deps += ['eal'] is missing in ring meson file. > > i guess that's what i'm kind of getting at... if it was there then the > patch i submitted is not required since depending on eal would drag in > global_inc. It is implicitly added, via lib/meson.build: First eal is parsed before a lot of other components: libraries = [ 'kvargs', # eal depends on kvargs 'telemetry', # basic info querying 'eal', # everything depends on eal 'ring', Then, there is: # eal is standard dependency once built if dpdk_conf.has('RTE_LIB_EAL') deps += ['eal'] endif -- David Marchand