Re: [PATCH] eal/ppc: support ASan

[David Marchand <david.marchand@redhat.com>]

On Mon, Nov 15, 2021 at 7:41 PM David Christensen
<drc@linux.vnet.ibm.com> wrote:
>
> Add support for Address Sanitizer (ASan) for PPC/POWER architecture.
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
>  config/meson.build             | 2 +-
>  doc/guides/prog_guide/asan.rst | 4 ++--
>  lib/eal/common/malloc_elem.h   | 2 ++
>  3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/config/meson.build b/config/meson.build
> index 3f5912fce7..ba433af7d9 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -433,7 +433,7 @@ if get_option('b_sanitize') == 'address' or get_option('b_sanitize') == 'address
>          dpdk_extra_ldflags += '-lasan'
>      endif
>
> -    if is_linux and arch_subdir in ['x86', 'arm'] and dpdk_conf.get('RTE_ARCH_64')
> +    if is_linux and arch_subdir in ['x86', 'arm', 'ppc'] and dpdk_conf.get('RTE_ARCH_64')

Now that all supported 64-bits arches can have ASan, we can remove the
check on arch_subdir.


>          dpdk_conf.set10('RTE_MALLOC_ASAN', true)
>      endif
>  endif
> diff --git a/doc/guides/prog_guide/asan.rst b/doc/guides/prog_guide/asan.rst
> index 28b2382fc7..7c1b59cfea 100644
> --- a/doc/guides/prog_guide/asan.rst
> +++ b/doc/guides/prog_guide/asan.rst
> @@ -32,8 +32,8 @@ Example::
>    - If the program is tested using cmdline, you may need to execute the
>      "stty echo" command when an error occurs.
>
> -ASan is aware of DPDK memory allocations, thanks to added instrumentation.
> -This is enabled on x86_64 and arm64 at the moment.
> +ASan is aware of DPDK memory allocations, thanks to added instrumentation, and
> +is enabled on x86_64, arm64, and PPC64 architectures.

is enabled for 64-bits architectures on Linux.



>  Other architectures may have to define ASAN_SHADOW_OFFSET.
>
>  Example heap-buffer-overflow error
> diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h
> index b982c83f70..15d8ba7af2 100644
> --- a/lib/eal/common/malloc_elem.h
> +++ b/lib/eal/common/malloc_elem.h
> @@ -112,6 +112,8 @@ malloc_elem_cookies_ok(const struct malloc_elem *elem)
>  #define ASAN_SHADOW_OFFSET    0x00007fff8000
>  #elif defined(RTE_ARCH_ARM64)
>  #define ASAN_SHADOW_OFFSET    0x001000000000
> +#elif defined(RTE_ARCH_PPC_64)
> +#define ASAN_SHADOW_OFFSET    0x020000000000
>  #endif
>
>  #define ASAN_SHADOW_GRAIN_SIZE 8
> --
> 2.27.0
>

Thanks.

-- 
David Marchand