From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F0EFA0350; Tue, 30 Jun 2020 14:04:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E05111BE9E; Tue, 30 Jun 2020 14:04:42 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 54BB91B75C for ; Tue, 30 Jun 2020 14:04:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593518680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P+lyMMcsJ+p8ND98yIZwSRTTkAEij+N3a/wDeYPSeMk=; b=F2O+lk5PvbktexCZavz6xAplnzjl0fPwFLsE6DfbzDZVmbH6+zmGPT8rifgr2zSRmZM9lQ ee7hKu5qLE1mTtnWeTRBFKdlpKW9mUhyimFUnOaGasGtn12EGFZU8IXszrbpvvQSxwXp+H OKgYWDo8dQWoDFIU2Adq+hjyj3EaWcY= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-VCwrj4_jOFazthRf79hpgA-1; Tue, 30 Jun 2020 08:04:36 -0400 X-MC-Unique: VCwrj4_jOFazthRf79hpgA-1 Received: by mail-vs1-f71.google.com with SMTP id m23so5901801vsk.6 for ; Tue, 30 Jun 2020 05:04:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P+lyMMcsJ+p8ND98yIZwSRTTkAEij+N3a/wDeYPSeMk=; b=iFIJuKOt0rt900/vHPWny6wG8kxKA+Og7mwCCKCp8MhW8GOmXMylh4KExN5zIZGfJj 7qAt++Ulj9dwk08qWBA5RKEDJYSIbTmJwO2K7Re/UgtWJkEWIMmagvP44BcPwipymD07 Tia5ODpRBZGsFO2nw8TNkL6Q2bUO5eH6GYZf0Y0934y6NCrB95f72CIKNRXx0k8SLAxY vmjkrSzvblouiMBD9DmlHx56337gUdIWAexuKNnnaSKhlancK6JXzNVuEUBrSrWKKkRk Lne3lg2LbvagHPHVAI80MXNRp7eA+Elw/tvKdRWvbPe36d8lJYx1bwfkooUyIK3fQTPh un7A== X-Gm-Message-State: AOAM531gtUy1e55tkZ+qXQPaQ2Vowd361WaOaHs+pIrCECh0MHjKKiqv iQFbM4PMY6RpNwFkm5pt2EKCLmzK0PWPOU0h5s/58KaICgjwZmEur3ZnbqaXkCXM4YfcjSVLsRm mHRoonBs6Vd0szgNdYRg= X-Received: by 2002:a9f:27e6:: with SMTP id b93mr13837206uab.126.1593518676439; Tue, 30 Jun 2020 05:04:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeHVVc51GsIdGpxsgu34Gv9U952jusB5VA296EBs6HjbZmtfRlHEuGFOUnitTh1HSnnYpkqQt3CMvWgbhGozs= X-Received: by 2002:a9f:27e6:: with SMTP id b93mr13837170uab.126.1593518676185; Tue, 30 Jun 2020 05:04:36 -0700 (PDT) MIME-Version: 1.0 References: <20200610144506.30505-1-david.marchand@redhat.com> <20200626144736.11011-1-david.marchand@redhat.com> <20200626144736.11011-4-david.marchand@redhat.com> <20200630093739.GC5869@platinum> In-Reply-To: <20200630093739.GC5869@platinum> From: David Marchand Date: Tue, 30 Jun 2020 14:04:24 +0200 Message-ID: To: Olivier Matz Cc: dev , Jerin Jacob , Bruce Richardson , Ray Kinsella , Thomas Monjalon , Andrew Rybchenko , Kevin Traynor , Ian Stokes , Ilya Maximets , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 3/9] eal: introduce thread init helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 30, 2020 at 11:37 AM Olivier Matz wrote: > > > > +void > > +rte_thread_init(unsigned int lcore_id, rte_cpuset_t *cpuset) > > +{ > > + /* set the lcore ID in per-lcore memory area */ > > + RTE_PER_LCORE(_lcore_id) = lcore_id; > > + > > + /* acquire system unique id */ > > + rte_gettid(); > > If I understand properly, rte_gettid() is now also called for control > thread. I don't think this behavior change can break anything, but it may > be good to highlight it in the commit log. Control thread could not use recursive locks before, because this rte_gettid() was missing. Worth mentioning yes. -- David Marchand