From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A74FA0C53; Wed, 3 Nov 2021 14:51:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13F49426E1; Wed, 3 Nov 2021 14:51:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id DCD16426DD for ; Wed, 3 Nov 2021 14:51:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635947470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ru+Ow2ACsr3vYoSsEGQr55txQqfHTlUdac6gJjk33hc=; b=gcr76Xvnx9VvnOCt1WYysuZ8P17zeWXSy7NjVCx4PhXzx9QecN4OWF2DlF+Ygqh3PKCWbO SqRe2idCOBPtiGj68woNaw339UF8OIhKxKalSF1ygmcB9HAS1X/n6e+EM0ZFKYZ8Op2mw5 uM9cylIMDKc4bzsz1VKOJvJ4t4JyC0o= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-N7vyg4gLMu2ZwDvou4D0ww-1; Wed, 03 Nov 2021 09:51:08 -0400 X-MC-Unique: N7vyg4gLMu2ZwDvou4D0ww-1 Received: by mail-lj1-f197.google.com with SMTP id f9-20020a05651c160900b00217e6a3ec32so1118890ljq.1 for ; Wed, 03 Nov 2021 06:51:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ru+Ow2ACsr3vYoSsEGQr55txQqfHTlUdac6gJjk33hc=; b=2lY2DEGB54hn285GNMdQ/vML5HV3LloilGDBKjQdjVzSsf6mGFZsj63QgNH0J0Uvds 9QJLUv0mkWT+aVWXvRrai50qM1X7Ehh97gUczC+yJm1cASQsVpZ8JOexZ2kDGgFHSt7o 0b3zGEzUPGvnvnZWIjnowmO0mqerkZOke5AEdF5dPejStum/OOM3Ju4wv9YFILOnAOtB K7n/afOufSJwX+H1vXyZ+VlbMPtRRqetrPShqeQCbd2BF9OEIQ9HugCGEddGCnPClyVi pnmXM17Y5whxpciwcVKZWDYMf0TjponLB+SQYJVImwZHpGP84kZoPjtIaIk+N8fqoWGQ BLvw== X-Gm-Message-State: AOAM53040FRrGziMGzcoT+3CIljPOLusDIm6X4k6zde/I8orEbcZBNj6 f7M/8bcu/yo28Fl3j9l4nabnaTFrowi6yLtEvekLpywKNfGSpUkOHm4GapH9SuMRV3cl08YZ6an Q1uylEq5HXTAMKxS9s74= X-Received: by 2002:a2e:b6d3:: with SMTP id m19mr11344196ljo.297.1635947466661; Wed, 03 Nov 2021 06:51:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLqNT23xefI5qZk5jZc362yyyJaCgGJu8SkUgZETj3GqaZ0R5vS7aXd/ocqjFAjkpZius8dshKC2We4slI+E0= X-Received: by 2002:a2e:b6d3:: with SMTP id m19mr11344178ljo.297.1635947466480; Wed, 03 Nov 2021 06:51:06 -0700 (PDT) MIME-Version: 1.0 References: <20211103105155.3556048-1-radu.nicolau@intel.com> <20211103115618.3559996-1-radu.nicolau@intel.com> <2503525.8RzHhxm8q0@thomas> In-Reply-To: From: David Marchand Date: Wed, 3 Nov 2021 14:50:54 +0100 Message-ID: To: Akhil Goyal Cc: Thomas Monjalon , Radu Nicolau , dev , Declan Doherty , "Hemant Agrawal (OSS)" , Anoob Joseph , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 3, 2021 at 2:45 PM Akhil Goyal wrote: > > > On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon > > wrote: > > > > > > 03/11/2021 12:56, Radu Nicolau: > > > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > > > will be defined in multiple compilation units and this can trigger a > > > > linker error on particular environments. In order to fix this the > > > > core_statistics definition was moved out of the header file. > > > > > > So it is not fixing compilation, > > > as we would never apply a patch which would completely break > > compilation. > > > I would say (in the title) that it moves global variable from header file. > > > > > > > Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet > > statistics") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Radu Nicolau > > > > I guess it has to do with series: > > https://patchwork.dpdk.org/project/dpdk/list/?series=20174 > > Yes this series initiated the issue, applying both the patch and the series now > On next-crypto It means a patch of this series broke compilation, and this fix here should be squashed in it. -- David Marchand