From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 490C5A0521; Tue, 3 Nov 2020 10:20:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2ED85C826; Tue, 3 Nov 2020 10:20:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 64432C822 for ; Tue, 3 Nov 2020 10:20:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604395212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HT+/7AdotjKMDcSxPqjURZ1umNXaYBUiooqvYUup/Rs=; b=G2YGnhCPkVt6zNsavIgx49YlxCOzcVV6tuzjcHR0Tk2Ct9cn08GAxsBMw8q1Vgha9CZFD/ TJfa6MwXqKpF4PqML11kSS2kPxGioitGHDf2C7yi6kzQ8TcXhTbWM6LL0kyVe9+jOUycKY MNBBzvAZhF5sGv1UBi/YLM3R0WuVQPA= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-333-s3sFmN68NyqkgNa4KaKtnQ-1; Tue, 03 Nov 2020 04:20:09 -0500 X-MC-Unique: s3sFmN68NyqkgNa4KaKtnQ-1 Received: by mail-vk1-f197.google.com with SMTP id z198so701289vkd.9 for ; Tue, 03 Nov 2020 01:20:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HT+/7AdotjKMDcSxPqjURZ1umNXaYBUiooqvYUup/Rs=; b=ujhgdCKHwuz3O+ezOQNJ+jTj2DzTNigm3pUH4WTg2UNetH354M+WdWxf/GVKeCIn1k HRcSWWwZy1kdv3tQu8Sss7LkWf2G7HwERKDKQ6h2LEzu34DaywFaMicW5EFEIkD+7rxm 358M9M+q9xFPDVaZsKFkjrEUb5wXwNt3R+5RT3TcbIVKivbCAjIwsmIMP4Q9caiTvad9 Qdbvr9JBL+ZOPjhUDh5EN5egyVyBWSBZUqDbwjUxdrbbdGl7eviqefww0byNlpguQv+1 3pkstwRSxoqOrwQMFAsow1lu0QYoLQ+gVLbn7bzdqbE7CT7x9QEr+A24xwMenqUH4njr YyXA== X-Gm-Message-State: AOAM532jySU65Hb+fmBJ4TSpklHI+qaUW+RZEgBRImvCSY2LVV4NYhWV /ae844ObglXxLdWVPDGLss0B7lttYcrHcmUT2XE6D40VW3Df5oRAi8I6tcDwLQUmW/rXC0l7LDA 0VUwriqiRYOgXKu8OoZ0= X-Received: by 2002:a67:2fca:: with SMTP id v193mr17755677vsv.18.1604395208649; Tue, 03 Nov 2020 01:20:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJyXfViUKoZoYY8eg0pN+gPSS+WB3jW+sjUnhCajXzBYmX9xLX3RolYxdxfM6ypWGaGBEdfJ8yghatYaqEiofIw= X-Received: by 2002:a67:2fca:: with SMTP id v193mr17755663vsv.18.1604395208441; Tue, 03 Nov 2020 01:20:08 -0800 (PST) MIME-Version: 1.0 References: <20201102174507.1085128-1-bruce.richardson@intel.com> <4495149.WBtOTWmHy8@thomas> <2238783.mFnA29xreC@thomas> In-Reply-To: <2238783.mFnA29xreC@thomas> From: David Marchand Date: Tue, 3 Nov 2020 10:19:57 +0100 Message-ID: To: Thomas Monjalon Cc: Bruce Richardson , dev , Guy Kaneti , Luca Boccassi , Rosen Xu , Andrew Rybchenko Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > 03/11/2020 09:19, David Marchand: > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > > > -name = 'octeontx2_regex' > > > > > > But it is not the same? > > > > > > The name will default to "octeontx2", which is fine. > > > But the fmt_name should not take this default. > > > I believe fmt_name should be "octeontx2_regex" as I did in my patch. > > > > fmt_name is only for maintaining config compat. > > This driver is new to 20.11. > > We can drop fmt_name too. > > If we don't set fmt_name, it defaults to "name", "octeontx2" here. > What is the consequence in compat definitions? $ git reset --hard origin/main HEAD is now at 30cf171352 app/regex: add job context $ ninja-build -C build >/dev/null 2>&1 && ls -rt build/drivers/*regex*octeo*.so.21.0 |tail -1; grep OCTEONTX2 build/rte_build_config.h |grep REG build/drivers/librte_regex_octeontx2_regex.so.21.0 #define RTE_LIBRTE_OCTEONTX2_REGEX_PMD 1 #define RTE_REGEX_OCTEONTX2_REGEX 1 $ git reset --hard origin/main HEAD is now at 30cf171352 app/regex: add job context $ git pw patch apply 81961 Applying: regex/octeontx2: fix driver name $ ninja-build -C build >/dev/null 2>&1 && ls -rt build/drivers/*regex*octeo*.so.21.0 |tail -1; grep OCTEONTX2 build/rte_build_config.h |grep REG build/drivers/librte_regex_octeontx2.so.21.0 #define RTE_LIBRTE_OCTEONTX2_REGEX_PMD 1 #define RTE_REGEX_OCTEONTX2 1 $ git reset --hard origin/main HEAD is now at 30cf171352 app/regex: add job context $ git pw patch apply --no-deps 83425 Applying: regex/octeontx2: fix unnecessary name override $ ninja-build -C build >/dev/null 2>&1 && ls -rt build/drivers/*regex*octeo*.so.21.0 |tail -1; grep OCTEONTX2 build/rte_build_config.h |grep REG build/drivers/librte_regex_octeontx2.so.21.0 #define RTE_REGEX_OCTEONTX2 1 -- David Marchand