From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F0B041C5F; Fri, 10 Feb 2023 12:04:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C969042670; Fri, 10 Feb 2023 12:04:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7300340EE6 for ; Fri, 10 Feb 2023 12:04:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676027096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8dRq025k5UMqs/ibExL0pKofrgKQrXbS30sKxbDobh8=; b=MedZcjeLoyHRSRSSoC4TA8lvmagI1j+/qaKirEdjcyvGHXRrmPgcIlJQendM/4un2APQti 2Zt00Wfrnh8gED2IRvCSVSBY06jpphfCHAEvleXcIciuEvO/8NURHlbL86BEYkfu5gbGOk Ms9024CSHRMfwG5Av27ymizK4r0afSU= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-83-ZRTjlpWEMiCOwoNbFXvI3Q-1; Fri, 10 Feb 2023 06:04:54 -0500 X-MC-Unique: ZRTjlpWEMiCOwoNbFXvI3Q-1 Received: by mail-pj1-f70.google.com with SMTP id s24-20020a17090aa11800b00230ffd3f340so2305140pjp.9 for ; Fri, 10 Feb 2023 03:04:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8dRq025k5UMqs/ibExL0pKofrgKQrXbS30sKxbDobh8=; b=0BdtLvhRGSs2P4C+4KgW9D4P55nM+LZpQR5a+1AYo8svYszIzY+tj8aFwiWTtgiqbd fc5FlLTfeg6J06hs9egVLsJjtWmMYgzDXNMhKmmV2icEw9O4K+oDT4VQydESv6BvBIM7 1dmGVS6d2JkPhXdm3OagcNzEyezAdJ4W8DxRYxmY7jNMRSpEto7OYBADxqEKAoqJ+gMI v8IyDwwaEeZmT+3EzQFoqQAYGu95VXOkHg6f/sk0LSSOgm1RPScdJRmJYf9D+iYLz3f9 kpbIDOwL9mQimhz1UCnAZjOQNuChsQQguIn8fC8JH4YfDpkP1Hk9VlzOwshLOvfE1+lc 3yMQ== X-Gm-Message-State: AO0yUKUH+e+74wOQPuqUW7oInxhM5lOzFGhQwa6aooamh1atbY9sx4JX uPDsI5LKFKOKprfI9jgUkhTvp1hwR4nrsQ4axxlB3fF1xRLIcVKeB99jTpVfb1KqmQbCLfVTUE1 sr+cv26UAMJwz04hiImI= X-Received: by 2002:a63:954c:0:b0:4f2:8007:5e1f with SMTP id t12-20020a63954c000000b004f280075e1fmr2790262pgn.58.1676027093620; Fri, 10 Feb 2023 03:04:53 -0800 (PST) X-Google-Smtp-Source: AK7set+o0sA4jnDKjut+dvxJph/6g1Bnu4ZpZoSAK+p/bHJiDs8TdIqtj42tdoTWSx9NKCUL7eC6eYcCcEhJxXrFBi4= X-Received: by 2002:a63:954c:0:b0:4f2:8007:5e1f with SMTP id t12-20020a63954c000000b004f280075e1fmr2790257pgn.58.1676027093334; Fri, 10 Feb 2023 03:04:53 -0800 (PST) MIME-Version: 1.0 References: <20230103185732.2007210-1-ashish.sadanandan@gmail.com> <20230109015239.3956876-1-ashish.sadanandan@gmail.com> In-Reply-To: From: David Marchand Date: Fri, 10 Feb 2023 12:04:41 +0100 Message-ID: Subject: Re: [PATCH v4 1/1] eal/linux: reject mountpt not parent of --huge-dir To: Ashish Sadanandan Cc: John Levon , dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 16, 2023 at 7:26 PM Ashish Sadanandan wrote: > On Wed, Jan 11, 2023 at 5:11 AM John Levon wrote: >> On Sun, Jan 08, 2023 at 06:52:39PM -0700, Ashish Sadanandan wrote: >> >> > The code added for allowing --huge-dir to specify hugetlbfs >> > sub-directories has a bug where it incorrectly matches mounts that >> > contain a prefix of the specified --huge-dir. >> > >> > Fixes: 24d5a1ce6b85 ("eal/linux: allow hugetlbfs sub-directories") >> > Cc: john.levon@nutanix.com >> > Cc: stable@dpdk.org >> > Signed-off-by: Ashish Sadanandan >> >> Reviewed-by: John Levon >> >> thanks >> john > > > Thanks for reviewing again, John. Do I need to CC anyone else to get this committed or any other steps I need to follow? I was hoping to get this merged into 22.11 stable branch too. You already did what was necessary, by putting a Fixes: tag and adding Cc: stable@dpdk.org in the commitlog. LTS maintainers scripts will catch this fix later, and it will likely end up in 22.11 and 21.11 branches. -- David Marchand