From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33A0C41B7B; Thu, 12 Oct 2023 14:38:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98E454028C; Thu, 12 Oct 2023 14:38:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 251554028A for ; Thu, 12 Oct 2023 14:38:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697114299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CX4isnm1v4p0pFtMQZ3NlMKpmCUuIJtNI5A0rFscmTQ=; b=I7r1+HWP9/AyjyY8vHaA4FQwHms3ISZbiTH835oEPusrN8rxHOOk5XZsbc6ZSKFFNEPz7D CWY1xDqPxEgK2AHbvH7QgmJKT05XhiMEv5QuSInNREpxO0rxNKsfE574QMWVrpSatPqe+H 7g09v6Vx8ZuMYsagFF7k+F39dKQRO6w= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-rSMw63lONT2cKCrtAQChlQ-1; Thu, 12 Oct 2023 08:38:03 -0400 X-MC-Unique: rSMw63lONT2cKCrtAQChlQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2bff8e92054so7801161fa.2 for ; Thu, 12 Oct 2023 05:38:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697114281; x=1697719081; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CX4isnm1v4p0pFtMQZ3NlMKpmCUuIJtNI5A0rFscmTQ=; b=TrB6L6qLcs+r/7fnuyQpzVuxqGxPSRWhpou3EXjP2828EQVQ7UwKRC5Q8R0hgDWe9l JpeOy0jqs1x8ORaRCQ+yYWvXdY0LKUa99hhK0tW9tq19oIMK4wlNR9kiodPLjFFcfMni JKGv4++bGzA3k5vzQAhiH8gXaHf7om93tHt4FitwX6exHksw6aEvrmGX5hzC3cvLwRky 5DdqNMsUfFFH3P75k+sZQOiqFBPLy2s7OQN+POkt/40k9ugs3MIVlMNNkHdRz1usCR8c S8S2mxN05D6R64JSlFwfxf2pzyssOnioTQeGgrDc1iYDWdBzB3hMIjKTrjUXkkOiGK4J FBvQ== X-Gm-Message-State: AOJu0YyLiTOAw6QgErdsE8I8ei/A1w6/lF8GxNq5iqazbdx2QIkynaBP Y+Oo5rxDduVzX83aMgpOwVeId5y6qQsXwDApS4Y160106GdX14qAQFq4VecpiscrZ7RiLq3Y2nt huo+zXT2TLCAoYRuXKNo= X-Received: by 2002:a2e:a28a:0:b0:2b6:df71:cff1 with SMTP id k10-20020a2ea28a000000b002b6df71cff1mr20440595lja.52.1697114281672; Thu, 12 Oct 2023 05:38:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGpLAGyHbDEI5gQ0O7mkNduCtkJmeB0n21V33sahgIXrMf06NHVh14oaGlMdglAo7c1umCRzrjheqNPaSDkNOE= X-Received: by 2002:a2e:a28a:0:b0:2b6:df71:cff1 with SMTP id k10-20020a2ea28a000000b002b6df71cff1mr20440583lja.52.1697114281266; Thu, 12 Oct 2023 05:38:01 -0700 (PDT) MIME-Version: 1.0 References: <20230727093107.7242-1-bruce.richardson@intel.com> In-Reply-To: <20230727093107.7242-1-bruce.richardson@intel.com> From: David Marchand Date: Thu, 12 Oct 2023 14:37:49 +0200 Message-ID: Subject: Re: [PATCH 0/2] simplify building x86 code with AVX2 support To: Bruce Richardson Cc: dev@dpdk.org, Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Bruce, On Thu, Jul 27, 2023 at 11:31=E2=80=AFAM Bruce Richardson wrote: > > Inside our optimized vector drivers (and libs), there were always build > time checks for various levels of instruction set support, most > notably AVX2 and AVX-512 on x86 systems. One of the checks done in > each case was verifying that the compiler used was able to generate > AVX code appropriately. However, since this was originally done, > our minimum compiler support has been updated and so we no longer > need to check this - all supported compilers can generate AVX2. > This allows us to simplify the build logic for the x86 vector code. > > In future, we can do similarly for AVX-512. > > Bruce Richardson (2): > build/x86: remove conditional checks for AVX2 support > build: remove unnecessary AVX2 compiler flag > > drivers/net/bnxt/bnxt_ethdev.c | 8 ++++---- > drivers/net/bnxt/bnxt_rxr.h | 2 +- > drivers/net/bnxt/bnxt_txr.h | 2 +- > drivers/net/bnxt/meson.build | 26 +++++++++---------------- > drivers/net/enic/meson.build | 10 +++------- > drivers/net/i40e/i40e_rxtx.c | 14 ++++--------- > drivers/net/i40e/meson.build | 22 ++++++--------------- > drivers/net/iavf/iavf_rxtx_vec_common.h | 2 +- > drivers/net/iavf/meson.build | 22 ++++++--------------- > drivers/net/ice/meson.build | 21 ++++++-------------- > lib/acl/meson.build | 23 +++++----------------- > lib/acl/rte_acl.c | 10 +++------- > 12 files changed, 49 insertions(+), 113 deletions(-) Sorry, this series had fallen through the cracks... though I intended to apply with other build update series. It still applies fine, I ran my checks and I see nothing wrong with the ser= ies. Applied, thanks for the cleanup. --=20 David Marchand