From: David Marchand <david.marchand@redhat.com>
To: Muhammad Bilal <m.bilal@emumba.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: removed typing mistake
Date: Thu, 26 Nov 2020 12:01:51 +0100 [thread overview]
Message-ID: <CAJFAV8y-z6-dYrD15Qj5XoQqw_vQf4qEeJ631LJgATDgN80+Vg@mail.gmail.com> (raw)
In-Reply-To: <20200909213932.12480-1-m.bilal@emumba.com>
On Wed, Sep 9, 2020 at 11:39 PM Muhammad Bilal <m.bilal@emumba.com> wrote:
>
> Here I have removed 'that' from the sentence to make it grammatically
> correct, as it seems to be a typing mistake
>
> Fixes: d0dff9ba445e ("doc: sample application user guide")
> Cc: bernard.iremonger@intel.com
>
> Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
> ---
> doc/guides/prog_guide/multi_proc_support.rst | 2 +-
> doc/guides/sample_app_ug/multi_process.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
> index a84083b96..a0d71a81a 100644
> --- a/doc/guides/prog_guide/multi_proc_support.rst
> +++ b/doc/guides/prog_guide/multi_proc_support.rst
> @@ -136,7 +136,7 @@ can use).
> Running Multiple Independent Groups of DPDK Applications
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> -In the same way that it is possible to run independent DPDK applications side- by-side on a single system,
> +In the same way, it is possible to run independent DPDK applications side- by-side on a single system,
> this can be trivially extended to multi-process groups of DPDK applications running side-by-side.
> In this case, the secondary processes must use the same ``--file-prefix`` parameter
> as the primary process whose shared memory they are connecting to.
> diff --git a/doc/guides/sample_app_ug/multi_process.rst b/doc/guides/sample_app_ug/multi_process.rst
> index f2a79a639..87c703b83 100644
> --- a/doc/guides/sample_app_ug/multi_process.rst
> +++ b/doc/guides/sample_app_ug/multi_process.rst
> @@ -302,7 +302,7 @@ One additional enhancement in this sample application is that the server process
> This eliminates the need for the client processes to have the portmask parameter passed into them on the command line,
> as is done for the symmetric multi-process application, and therefore eliminates mismatched parameters as a potential source of errors.
>
> -In the same way that the server process is designed to be run as a primary process instance only,
> +In the same way, the server process is designed to be run as a primary process instance only,
> the client processes are designed to be run as secondary instances only.
> They have no code to attempt to create shared memory objects.
> Instead, handles to all needed rings and memory pools are obtained via calls to rte_ring_lookup() and rte_mempool_lookup().
Sorry, but I don't see what is wrong with the original form.
--
David Marchand
prev parent reply other threads:[~2020-11-26 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 21:39 [dpdk-dev] " Muhammad Bilal
2020-11-26 11:01 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8y-z6-dYrD15Qj5XoQqw_vQf4qEeJ631LJgATDgN80+Vg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=m.bilal@emumba.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).