From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D4BFA0C43; Tue, 19 Oct 2021 11:27:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDEF540142; Tue, 19 Oct 2021 11:27:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id C043E4003E for ; Tue, 19 Oct 2021 11:27:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634635675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6EQpMn9OZYJiztGJ/mC5DZVucCiUKNGExHozH2NZ2I=; b=RI+vffShRprTiTzbER9zVmyZgzOV1WLE7sVIb5ZPQ2wDDVYudqguRhzY8wAl0GsiBcDd9x uUsF8mDu5Z1Tg6l1lHeCyXXfjO2LY4fiQBOdY+BLKRpGzORhy7pQOjXHeUN6LWGad8JvEC zC/Sq6doQSY+TEWFdQkAp1kKkH+IO/M= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-571-_sLIvrsIMryFC9e0YGTSDg-1; Tue, 19 Oct 2021 05:27:54 -0400 X-MC-Unique: _sLIvrsIMryFC9e0YGTSDg-1 Received: by mail-lf1-f70.google.com with SMTP id k8-20020a0565123d8800b003fd6e160c77so1178435lfv.17 for ; Tue, 19 Oct 2021 02:27:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P6EQpMn9OZYJiztGJ/mC5DZVucCiUKNGExHozH2NZ2I=; b=K42R8qAhDzmhJjaS+WUdvsCj3Y515PRGFq8jkODpiRHoQA6o7AjMiC5ih1u3paGWrv 7dsZYPDNcsWHpdJ89+eoC6H1pw75kV3ic8AmpXuATfOEfrmolKUw0SzyFY0OoJJcJasu VfLbP4Y/5XQVxUClj+W3VrRZno1oediZv6e58QTIb1hIXgrhMa9iVuUUMkjE3/nw73ey dlCY/eAERp6wo2q7aZ7yVA9HRduziCIxQ6JZZq6pDNVplP570QMEKLPpkKr4mOqsXEf1 wVrkgXlD2PTu/8bXBSVaBPA5uMQHKXfcL2jvG4TtYOFa83hUGo82D/L+0AFCpWYN10mh 6R5A== X-Gm-Message-State: AOAM531OFbqkQkxNqnL+XUXAICum0XXcesUApXZOQm2i6U8MSfkYQB0e Im8UaGOmlNoGbMC0xRa2s1Un/NCLdyDWS02oix6oqOI/ZKvOm4HvfNohKUf0Llorrlqmjv2K8t9 23IDSfRodT0GNsArknkw= X-Received: by 2002:a2e:b6cc:: with SMTP id m12mr5346963ljo.297.1634635672619; Tue, 19 Oct 2021 02:27:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFzimzjncDSzSmdn11G4KZF8S0dYhlHtdaTR+dtUb8POWeEmzYQJuS1ki/949JsIKuRy4bVF9R/ISDfFkzrfc= X-Received: by 2002:a2e:b6cc:: with SMTP id m12mr5346939ljo.297.1634635672430; Tue, 19 Oct 2021 02:27:52 -0700 (PDT) MIME-Version: 1.0 References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211018144907.1145028-6-andrew.rybchenko@oktetlabs.ru> <86905833-5c40-76ce-3794-ec3c2e447242@oktetlabs.ru> In-Reply-To: <86905833-5c40-76ce-3794-ec3c2e447242@oktetlabs.ru> From: David Marchand Date: Tue, 19 Oct 2021 11:27:41 +0200 Message-ID: To: Andrew Rybchenko , Thomas Monjalon Cc: Olivier Matz , Ray Kinsella , "Artem V. Andreev" , Ashwin Sekhar T K , Pavan Nikhilesh , Hemant Agrawal , Sachin Saxena , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 5/6] mempool: add namespace to driver register macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 11:05 AM Andrew Rybchenko wrote: > > On 10/19/21 11:49 AM, David Marchand wrote: > > On Mon, Oct 18, 2021 at 4:50 PM Andrew Rybchenko > > wrote: > >> > >> Add RTE_ prefix to macro used to register mempool driver. > >> The old one is still available but deprecated. > > > > ODP seems to use its own mempools. > > > > $ git grep-all -w MEMPOOL_REGISTER_OPS > > OpenDataplane/platform/linux-generic/pktio/dpdk.c:MEMPOOL_REGISTER_OPS(odp_pool_ops); > > > > I'd say it counts as a driver macro. > > If so, we could hide it in a driver-only header, along with > > rte_mempool_register_ops getting marked as internal. > > > > $ git grep-all -w rte_mempool_register_ops > > FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); > > FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); > > Do I understand correctly that it is required to remove it from > stable ABI/API, but still allow external SW to use it? > > Should I add one more patch to the series? If we want to do the full job, we need to inspect driver-only symbols in rte_mempool.h. But this goes way further than a simple prefixing as this series intended. I just read your reply, I think we agree. Let's go with simple prefix and take a note to cleanup in the future. -- David Marchand