From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C52B3A04B3; Fri, 8 Nov 2019 12:05:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ABB61C10B; Fri, 8 Nov 2019 12:05:39 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 6AB1E1C0D3 for ; Fri, 8 Nov 2019 12:05:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573211136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k7JY1m6AYWvzQItaN4Vj8hQUXPZvwuOSZwYHsM5JcnE=; b=Rz4CluFEuHG60GvLOBimxupTrUkPX8Tn6O2wqc9b8J3ZS8SlcK0Iopf4h61Q4dObURZAJ5 VLIHV2Zn90IENzG5iLKOJ4intLRCWpXeEYKsDsdk9NTEbL7m/C+z8fBEm7SczhRts3NV0D BLEmbivK+8Mep7Df50i122ksKvMVsfU= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-BO1S09hSN2SBUm4oE2LlMw-1; Fri, 08 Nov 2019 06:05:35 -0500 Received: by mail-vk1-f199.google.com with SMTP id p77so2038398vkf.17 for ; Fri, 08 Nov 2019 03:05:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Iqec20+ODMRuUzJda+IF/S6PcapAzRhRixlMeENDJd8=; b=lDm8zlOOOUP0dGaLQTgPMpK+o+yFGvsUqZI4WHKGemFcUbUcCYhfZ2t8klcFTB4BL8 qJ/s5jaTriTChPBWxAPqL1+GTWp46avW8npCzg/ntPixGXtwaGYP2GITahYm0XEyawVi WP6UyojyJ9d8AYhrn2Ts/h+cC7G3IbPkd/+/31zfXQI6ioRZy+cnSkkTToQ/+GUOizOC bh6hQRRW0uxdFE+1VDlj8kLS9kQR+Mx8LtReeUkpOAipksMaQ9XO6BYxWgGrIP2eslXn NtOAlgcfBysRJ1Ooxo9n/tM0057LyzZb4ZvMLAuNDjChZQz7+t/x/itnNv9M8QYxdsIG ShUQ== X-Gm-Message-State: APjAAAWSjSUaGkSh3g5JgxGQU9kKtIccaV61uzZweDhRFBRAkWPHYlPV wgYi8xp2cHFG8j4PVOZdo7JJV5m0E8PRN6/fuAoGbyQqKjYtwGUhH9FbDB+NUGVzivuDgvBcYxF v5hixjxakVDCL+dgv/Qw= X-Received: by 2002:ab0:189a:: with SMTP id t26mr6642571uag.87.1573211135068; Fri, 08 Nov 2019 03:05:35 -0800 (PST) X-Google-Smtp-Source: APXvYqx7HCfCRFTgnrD6d40lABUg8bJzHqCL6+M/P+j4q9RlWyYiR1FhQiz6PdDlrbQqWRUVZ+bNxtdeEljoYikgRFk= X-Received: by 2002:ab0:189a:: with SMTP id t26mr6642537uag.87.1573211134553; Fri, 08 Nov 2019 03:05:34 -0800 (PST) MIME-Version: 1.0 References: <20191108102135.7249-1-kkanas@marvell.com> In-Reply-To: <20191108102135.7249-1-kkanas@marvell.com> From: David Marchand Date: Fri, 8 Nov 2019 12:05:23 +0100 Message-ID: To: Krzysztof Kanas , Bruce Richardson Cc: dev , "Yigit, Ferruh" X-MC-Unique: BO1S09hSN2SBUm4oE2LlMw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 8, 2019 at 11:21 AM wrote: > > Hi David, > > Thanks for review, hopefully this patch will addresses most of the sutff. > Rest I will address here. > > > > > > + const char *procdir =3D "/proc/self/fd/"; > > > > self is a Linux thing. > > This won't work on FreeBSD. > > IMHO original code didn't worked on FreeBSD as well. > I have created function to adress in third patch Indeed... Well, wait. Why do we need to close those file descriptors? FreeBSD has been like this for quite some time. Can't we just remove this code? Maybe someone from Intel has an idea of why it was like this? Adding Bruce. --=20 David Marchand