From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1639A0032; Fri, 21 Oct 2022 15:09:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C18DF42B9C; Fri, 21 Oct 2022 15:09:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1315441147 for ; Fri, 21 Oct 2022 15:09:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666357754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C9YF6vNloqldxAcu4PB/AyoSNrjMz/XLqGblUKQ0vC8=; b=e+JodN18RqUesxNPu632MzwMRvx4PKrUmdfwOfByWulFGzznEmc/PDjY7S69/FJqMQHnh+ /1Gxrba8A8vn9oBkXabV6dqgxAZbTYUt23QlHuT6udXtd2hkXtOx2OZ4F+SuvNW73Iv0Cu Qjd5Ab0Yi6iH4nzFuzO2x3/3VFJ5YLU= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-640-JZ2sL3-7Psiq6xZ8JTdglw-1; Fri, 21 Oct 2022 09:09:12 -0400 X-MC-Unique: JZ2sL3-7Psiq6xZ8JTdglw-1 Received: by mail-pl1-f199.google.com with SMTP id q12-20020a170902dacc00b00184ba4faf1cso1659443plx.23 for ; Fri, 21 Oct 2022 06:09:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C9YF6vNloqldxAcu4PB/AyoSNrjMz/XLqGblUKQ0vC8=; b=JIaIt/yuhHb9Z3Qg8YQbL7ozCbwqB9RyDqAk85fKOkMDjDRuCscJTAkC4YCInLJNmS MkPGM2CHVF7/+ut06s9jbqIIOJHlWFB5VKO9C4zyw1R2zZ6YDVs9ANEh3urAA7gysRNo rWqS0zYk6MJgqYlzy74XNCd12hcLpVwiZHiN3LHk9/z83cQu/5JVJNIDKFZjtxFZ46WH wdv6xhZMYjVtOqpRd/MGPbJNRH9hTDRnzjSXgKlVNCrx6IL05/Z3MgWbjETsuIkksk9m 4ARtRWC4pECCilo/P9MJgvHkgYLJ4/y5UyCfW7OoL95jmamZBtvQRRQ30Qsl0Wftt6lA V7UQ== X-Gm-Message-State: ACrzQf0YBrwfpJWOb09pbbjr1DjxVvit5iT02sZMNcxLlZEpZvtbqc8u /cFxyRHxcG3B75F3IxodjjMHVu+qN6IrfMkvgvBzUfVj9ZU33NcZV4610PP1ujJf2ss0iF0AE+a L3GOQ0I8roSlfW/R60R8= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr15721381pgm.223.1666357748946; Fri, 21 Oct 2022 06:09:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4MA/FgZvwniTtUoICVV4eMIFSQJiQTzg0+/a46PDCUSBbKVMWLZpVCPexr+wyGPahiXUG1N16WWlUpHzJ3Ulk= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr15721368pgm.223.1666357748699; Fri, 21 Oct 2022 06:09:08 -0700 (PDT) MIME-Version: 1.0 References: <1f5f87b63b94410fb651546d1b4a0937@b-plus.com> <20221019163733.68137-1-stephen@networkplumber.org> In-Reply-To: <20221019163733.68137-1-stephen@networkplumber.org> From: David Marchand Date: Fri, 21 Oct 2022 15:08:57 +0200 Message-ID: Subject: Re: [PATCH] pdump: do not allow enable/disable in primary process To: Stephen Hemminger Cc: dev@dpdk.org, =?UTF-8?Q?Sylvia_Grundw=C3=BCrmer?= , Reshma Pattan , Anatoly Burakov , Jianfeng Tan X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 19, 2022 at 6:37 PM Stephen Hemminger wrote: > > Attempts to enable or disable pdump in primary process > will fail with core dump because it is not valid to call > rte_mp_request_sync() unless in a secondary process. > > Trap the error in the common code used for both enable > and disable requests. > > Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Cc: stable@dpdk.org > Reported-by: Sylvia Grundw=C3=BCrmer > Signed-off-by: Stephen Hemminger Applied, thanks. --=20 David Marchand