* [PATCH] devtools: exclude common EAL header from attribute check
@ 2024-10-10 17:00 David Marchand
2024-10-10 17:40 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2024-10-10 17:00 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon
With the addition of SKIP_FILES in
commit 7e421ae345f4 ("devtools: support skipping forbid rule check"),
it is possible to avoid false positive on adding
attribute wrapper in rte_common.h.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 0ab841bd5a..c23792025a 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -89,6 +89,7 @@ check_forbidden_additions() { # <patch>
# refrain from using compiler attribute without defining a common macro
awk -v FOLDERS="lib drivers app examples" \
+ -v SKIP_FILES='lib/eal/include/rte_common.h' \
-v EXPRESSIONS="__attribute__" \
-v RET_ON_FAIL=1 \
-v MESSAGE='Using compiler attribute directly' \
--
2.46.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] devtools: exclude common EAL header from attribute check
2024-10-10 17:00 [PATCH] devtools: exclude common EAL header from attribute check David Marchand
@ 2024-10-10 17:40 ` Stephen Hemminger
2024-10-11 9:04 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2024-10-10 17:40 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Thomas Monjalon
On Thu, 10 Oct 2024 19:00:42 +0200
David Marchand <david.marchand@redhat.com> wrote:
> With the addition of SKIP_FILES in
> commit 7e421ae345f4 ("devtools: support skipping forbid rule check"),
> it is possible to avoid false positive on adding
> attribute wrapper in rte_common.h.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] devtools: exclude common EAL header from attribute check
2024-10-10 17:40 ` Stephen Hemminger
@ 2024-10-11 9:04 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2024-10-11 9:04 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Thomas Monjalon, Stephen Hemminger
On Thu, Oct 10, 2024 at 7:41 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
> > With the addition of SKIP_FILES in
> > commit 7e421ae345f4 ("devtools: support skipping forbid rule check"),
> > it is possible to avoid false positive on adding
> > attribute wrapper in rte_common.h.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-11 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-10 17:00 [PATCH] devtools: exclude common EAL header from attribute check David Marchand
2024-10-10 17:40 ` Stephen Hemminger
2024-10-11 9:04 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).