From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4F7DA0A05; Wed, 20 Jan 2021 10:53:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61ECD140CC4; Wed, 20 Jan 2021 10:53:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id ADD6B140E31 for ; Wed, 20 Jan 2021 10:53:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611136433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vXy+GazLe/NQmpk8P+I7taJkHbYnF1FdsdOEe320Xd8=; b=Dlz1bi58NOweRQSooaNK7PWKYtBmfa99CB/bQ2NNgs/QEsN3CBpm1T29tMPa0OxA27mXiq R0k5HOgHUdhJWGsVIICpCwfp6p9k0NugWywiQ/+TzEQ4OsOB1PwgEeGeKBpwGPml1BOmaj ktviNv5Q3p5tU/nIFr6gKDMA1HcpFhg= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-rfBiZ6FKOyux-AR40xcECQ-1; Wed, 20 Jan 2021 04:53:39 -0500 X-MC-Unique: rfBiZ6FKOyux-AR40xcECQ-1 Received: by mail-ua1-f69.google.com with SMTP id r13so8763892uao.5 for ; Wed, 20 Jan 2021 01:53:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vXy+GazLe/NQmpk8P+I7taJkHbYnF1FdsdOEe320Xd8=; b=TgMHk8DUIGJH1kG8hMmyAhVvL5u7MI9OJAAfYuqA/BJGRFjk3mR3BgyWdGz3ql22Ui CAdo2eW9d/6+D3fAeAdCfNjqmUl54wF20EKdu1rrfmL9l1nlJQKbm/mWPJjoPUVO3lsr kv6q9U3lVWRXMOYKiQCXQickWsY/ntGrRIwVwr8Z5jhkPhHmQ71a/nIwjNk3bWQNVo4I 8BaSKoUJcKq1D+JPIFq8qEjWVLXg6mvKwXt8NS+NitVh2jPZfGFwtZh80+jXJNr5JyLH 7xgyrffp1W2lS+Oq+mHJnaY59cuP1SKa64rg4Z/CskzsWqTahCm4j/Myt6q+Y0y+CZFT 2G3A== X-Gm-Message-State: AOAM532oGr7j5p6geA7XQ06FgxZ2r7EdJ3/VjOZj63UetMmuBQ/LHL0J BYSj/xZzT97QEkJUoyi6vqXmR0Itj8zU+uWoHBaYOeqCj4baDMUHJRsaBiUF89zZH1iOaPaFKJ1 H/KJvK/vqjkifY2aYWWQ= X-Received: by 2002:a67:6943:: with SMTP id e64mr6017803vsc.10.1611136418817; Wed, 20 Jan 2021 01:53:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzv9AhxcLfh4gIYs427Gm/SY2OLB5eHRbrlnCjS/iK6MxzMZWjwksrkgpA4SD2VDPGN5K75MiKouY9zcVh8n70= X-Received: by 2002:a67:6943:: with SMTP id e64mr6017784vsc.10.1611136418464; Wed, 20 Jan 2021 01:53:38 -0800 (PST) MIME-Version: 1.0 References: <20201215021945.103396-1-leyi.rong@intel.com> <5859779.zrh4IzKrC7@thomas> In-Reply-To: <5859779.zrh4IzKrC7@thomas> From: David Marchand Date: Wed, 20 Jan 2021 10:53:27 +0100 Message-ID: To: Thomas Monjalon Cc: Tal Shnaiderman , Ali Alnubani , Ferruh Yigit , Odi Assli , "Rong, Leyi" , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Xing, Beilei" , "Kadam, Pallavi" , "Menon, Ranjit" , "dev@dpdk.org" , Raslan Darawsheh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 20, 2021 at 10:23 AM Thomas Monjalon wrote: > > 20/01/2021 09:36, David Marchand: > > On Wed, Jan 20, 2021 at 7:26 AM Tal Shnaiderman wrote: > > > > The patch "add AVX512 vector path" also caused a build failure when cross > > > > compiling on Linux using mingw, and it's still reproducing in next-net > > > > (517969c95). > > > > > > > > ``` > > > > $ meson --werror --buildtype=debugoptimized --cross-file config/x86/cross- > > > > mingw -Dexamples=helloworld build && ninja-build -C build -j32 > > > > > > > > [221/232] Generating symbol file lib/librte_mbuf-21.dll.p/librte_mbuf- > > > > 21.dll.symbols > > > > [222/232] Generating symbol file lib/librte_hash-21.dll.p/librte_hash- > > > > 21.dll.symbols > > > > [223/232] Linking target lib/librte_net-21.dll [224/232] Compiling C object > > > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj > > > > FAILED: drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj > > > > ... > > > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj.d -o > > > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj -c > > > > ../../root/dpdk/drivers/net/i40e/i40e_rxtx_vec_avx512.c > > > > {standard input}: Assembler messages: > > > > {standard input}:112: Error: invalid register for .seh_savexmm {standard > > > > input}:114: Error: invalid register for .seh_savexmm ... > > > > ... > > > > {standard input}:25351: Error: invalid register for .seh_savexmm {standard > > > > input}:25352: Error: invalid register for .seh_savexmm [225/232] Generating > > > > symbol file lib/librte_net-21.dll.p/librte_net-21.dll.symbols > > > > ninja: build stopped: subcommand failed. > > > > ``` > > > > > > > > OS: Fedora 32 > > > > Meson: 0.55.3 > > > > MinGW: Fedora MinGW 9.2.1-6.fc32 > > > > > > > > - Ali > > > > > > Those errors were detected in the CI tests for this patch [1], we should pay more attention to those now that 2 PMDs are supported on Windows. > > > > > > [1]: https://lab.dpdk.org/results/dashboard/patchsets/15164/ > > > > I won't grmbl about how CI reports are not being looked at (or maybe I > > just did :)). > > > > This simple patch seems to work for me: > > > > diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build > > index c0acdf4fd4..c9a1a50407 100644 > > --- a/drivers/net/i40e/meson.build > > +++ b/drivers/net/i40e/meson.build > > @@ -54,7 +54,7 @@ if arch_subdir == 'x86' > > cc.has_argument('-mavx512f') and > > cc.has_argument('-mavx512bw')) > > > > - if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true > > + if not is_windows and (i40e_avx512_cpu_support == true or > > i40e_avx512_cc_support == true) > > cflags += ['-DCC_AVX512_SUPPORT'] > > avx512_args = [cflags, '-mavx512f', '-mavx512bw'] > > if cc.has_argument('-march=skylake-avx512') > > > > > > If nobody has a better fix, I'll send it later. > > > For info, I don't reproduce the compilation issue on my machine. My build system has been upgraded from fc31 to fc32 so I guess this has something to do with it. -- David Marchand