From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F57F43034; Fri, 11 Aug 2023 15:32:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B77F42D3F; Fri, 11 Aug 2023 15:32:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1045540E03 for ; Fri, 11 Aug 2023 15:32:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691760728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=et2vc5nz0ULJ2rh9g0PH/vKIZyW09n5RA+ZfAS+9TbY=; b=KwF6aMozkume0jukDK4/AFzs3n1V+rFSNZKEVIGWpt/g82FPyvvW8IKKxD4w2m5padVvFR gG5dLbMi2JiSbfpvFlS2ibQL7DqZCgzwrI21XA5+neMet/wo+3Jqu2txHvyjGXYOa45VZQ ej49xoV6VyljsV6Piro74SL8mvmKsn8= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-01VUTfYyPjSlamOQkwq5bw-1; Fri, 11 Aug 2023 09:32:07 -0400 X-MC-Unique: 01VUTfYyPjSlamOQkwq5bw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4fe0fe8dfe0so1832017e87.0 for ; Fri, 11 Aug 2023 06:32:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691760725; x=1692365525; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=et2vc5nz0ULJ2rh9g0PH/vKIZyW09n5RA+ZfAS+9TbY=; b=Ob0E0c5SoiTV8xrQ2lLQMi5DTXZ76kBj98aaHmUB76bXLqXrrv6y7gObKCdpauf20I SmeiHmo403JNZOiVM1zPIgbc2r4zawNV3cfEJ1EpWv30yuCv7lQVL2RiKQ7vKNTcgD1v BueAYahQG/0iANBjgkbbeQpSjU4r7pXijAF6HTO3HWgAI9ce3DdoKSu4xw/O5dLqo60I /pFRaehMDU0/4Ahg1gqI9D3WjShZF1css2S0SvJYYkf0i02CXJDcNbdhwWtbZXvV1zgn ADBHZodndVhM/xo4/NfoAV6/64yoaJoQrHBcQ3PHZYySSHcV4LDMKWTO9LJUEsj9FX0h gFKA== X-Gm-Message-State: AOJu0YyB0iAqnIaqAdvu0NlP2I5aAwKvapsUeLtqr/8uXB448rDW4Sf0 6/QEMzNyXmCJWGRxK8X/6BwVaLxMsJ/kESyHdqhbETEfQZ8S4LSUyTZcROWqhjWMg1hk6MhHVMa W8EaXn+jQnbj+VZtNHEY1oGoF/1I= X-Received: by 2002:a05:6512:3713:b0:4fd:c8fb:eb71 with SMTP id z19-20020a056512371300b004fdc8fbeb71mr697099lfr.11.1691760725426; Fri, 11 Aug 2023 06:32:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG53xyuL7p6io0FXGq7ktFWB4Zupi7VeYiU/T8CGQGjiopFoVLwzp4F+FA0DVjpHr54l1Ic6MIZ98AbuMnOR7A= X-Received: by 2002:a05:6512:3713:b0:4fd:c8fb:eb71 with SMTP id z19-20020a056512371300b004fdc8fbeb71mr697094lfr.11.1691760725208; Fri, 11 Aug 2023 06:32:05 -0700 (PDT) MIME-Version: 1.0 References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1682453329-20435-1-git-send-email-roretzla@linux.microsoft.com> <1682453329-20435-4-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1682453329-20435-4-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Fri, 11 Aug 2023 15:31:53 +0200 Message-ID: Subject: Re: [PATCH v3 3/4] build: limit what is built when using MSVC compiler To: Tyler Retzlaff Cc: dev@dpdk.org, bruce.richardson@intel.com, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 25, 2023 at 10:08=E2=80=AFPM Tyler Retzlaff wrote: > > Build only kvargs and telemetry when is_ms_compiler. > > Signed-off-by: Tyler Retzlaff > Acked-by: Bruce Richardson > --- > app/meson.build | 5 +++++ > drivers/meson.build | 4 ++++ > lib/meson.build | 7 +++++++ > usertools/meson.build | 4 ++++ > 4 files changed, 20 insertions(+) > > diff --git a/app/meson.build b/app/meson.build > index 74d2420..94fd7c9 100644 > --- a/app/meson.build > +++ b/app/meson.build > @@ -1,6 +1,11 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017-2019 Intel Corporation > > +if is_ms_compiler > + enabled_apps =3D [] Nit: This could be moved to the top of the tree meson.build: https://patchwork.dpdk.org/project/dpdk/patch/20230811132805.2434448-1-davi= d.marchand@redhat.com/ > + subdir_done() > +endif > + > disable_apps =3D ',' + get_option('disable_apps') > disable_apps =3D run_command(list_dir_globs, disable_apps, check: true).= stdout().split() > > diff --git a/drivers/meson.build b/drivers/meson.build > index 74ae8cb..749ec20 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -1,6 +1,10 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017-2019 Intel Corporation > > +if is_ms_compiler > + subdir_done() > +endif > + > fs =3D import('fs') > > # Defines the order of dependencies evaluation > diff --git a/lib/meson.build b/lib/meson.build > index 40c632a..777d3d3 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -66,6 +66,13 @@ libraries =3D [ > 'node', > ] > > +if is_ms_compiler > + libraries =3D [ The log library must be added here, now that telemetry depends on it. > + 'kvargs', > + 'telemetry', > + ] > +endif > + > optional_libs =3D [ > 'bitratestats', > 'cfgfile', > diff --git a/usertools/meson.build b/usertools/meson.build > index b6271a2..1a56248 100644 > --- a/usertools/meson.build > +++ b/usertools/meson.build > @@ -1,6 +1,10 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > +if is_ms_compiler > + subdir_done() > +endif > + > install_data([ > 'dpdk-devbind.py', > 'dpdk-pmdinfo.py', > -- > 1.8.3.1 > --=20 David Marchand