From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCC79A0C53; Wed, 3 Nov 2021 14:43:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5F16426F6; Wed, 3 Nov 2021 14:43:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AA60941134 for ; Wed, 3 Nov 2021 14:43:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635946988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1kwAxDeFTo+KprEEVwsP0WA5FOw20ezyOi5dCoTW4i0=; b=KRyOtXrmZxelpEAQxl/erDojtBVur+6N9f8Qe/l6/vNk/Aqo7l5VUJLypc7dtUOiCIWzO7 GnUfGqDWiJZf0uFKbmZgbi+NjuFoP5G5nmwWTb2gpQY3Sd8KcT+MvFqP4rokJtgNBrzq8s ZzLH1JnUJUPYtNX2u+pFqu0zktTqKUQ= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-KYQMdnk0MYmL5_tuvd_-eg-1; Wed, 03 Nov 2021 09:43:03 -0400 X-MC-Unique: KYQMdnk0MYmL5_tuvd_-eg-1 Received: by mail-lj1-f200.google.com with SMTP id f17-20020a2e9751000000b00211a1367c68so1090253ljj.16 for ; Wed, 03 Nov 2021 06:43:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1kwAxDeFTo+KprEEVwsP0WA5FOw20ezyOi5dCoTW4i0=; b=dpyfYzmXCY04kI3X5h0Xm8gOHE7ruEqH+w+I6IRcdkbfkbqvAybLF0oenUjRqZWOHO ktq0u4flK9VPvTSianK54xzgDfMXNlQxWn9hpTNLyT/pB04PsnN9mulri/84sfYFXZhr fJQKg9fn0n8hKIHJwp13CUaHnpBkPs0gnR08ELVFjFvtqYws/SFLTN0VFdRUHt24Mj0h nJ3+fUIUJ7IF33vhd364Hh2xYJ2zGsGfz9iRXVWnbbi70T3NWh9QQgIDBBoR2/I9V1RQ FGgKUYTPF51dw2TWVHj3oiuvTzaS7u3BG5AL/Rj7b5B/42X+UsD6qqKLxkP+c7CMA3xZ HCUw== X-Gm-Message-State: AOAM530xHlz5ZBB/7QxJxvRr1aC6mGi7wk9QRHwAT3UK+/pw5BVTzVmT F59MaItIQhfyX+xTlWh1O+bbqNtFIzdfI5oks9o08dL6B4YIVSzMbnl0TW5JhAOG04wa+E8c4VK RUXfTwT+JjrDTS/DKViI= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr38998048lfq.553.1635946981757; Wed, 03 Nov 2021 06:43:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkfLAoZhlUX2iKIDm1ZktiAHFYfeg1KX6FKGtX1mpsn1UEQdxp2qPmZb0fTM6VuH3JgLT3jDTTmtkHMAgvChs= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr38998026lfq.553.1635946981536; Wed, 03 Nov 2021 06:43:01 -0700 (PDT) MIME-Version: 1.0 References: <20211103105155.3556048-1-radu.nicolau@intel.com> <20211103115618.3559996-1-radu.nicolau@intel.com> <2503525.8RzHhxm8q0@thomas> In-Reply-To: <2503525.8RzHhxm8q0@thomas> From: David Marchand Date: Wed, 3 Nov 2021 14:42:50 +0100 Message-ID: To: Thomas Monjalon , Radu Nicolau , Akhil Goyal Cc: dev , Declan Doherty , "Hemant Agrawal (OSS)" , Anoob Joseph , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] examples/ipsec-secgw: fix potential build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon wrote: > > 03/11/2021 12:56, Radu Nicolau: > > When STATS_INTERVAL is set to a non-zero value the core_statistics array > > will be defined in multiple compilation units and this can trigger a > > linker error on particular environments. In order to fix this the > > core_statistics definition was moved out of the header file. > > So it is not fixing compilation, > as we would never apply a patch which would completely break compilation. > I would say (in the title) that it moves global variable from header file. > > > Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet statistics") > > Cc: stable@dpdk.org > > > > Signed-off-by: Radu Nicolau I guess it has to do with series: https://patchwork.dpdk.org/project/dpdk/list/?series=20174 http://mails.dpdk.org/archives/test-report/2021-November/237332.html So it should be part of this series. -- David Marchand