From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEF21424D0; Mon, 17 Jun 2024 15:57:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52F1B4028B; Mon, 17 Jun 2024 15:57:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A1E124028A for ; Mon, 17 Jun 2024 15:57:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718632643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O0JUPirQNqI2sU1uefyA3Yit8Kc84wKus7JFkziy8ZU=; b=Kq93SelpTm15J8e4XiagSD3QLJtit4TNBspflM8UkchRRx1kSrllVvpv/bsT/L/GUxLt1f ZVPVv8o4dml/PFVmfql1AW4bQPOalxcr0v2kNnGR6R2BfbpvmSlTy0AgURaalaAPUjfO3r MyFW3PP06lkMjCM08M+ZLZKu1e0q9ps= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-1Eez0QkqOwSLyQPfT0hoIw-1; Mon, 17 Jun 2024 09:57:21 -0400 X-MC-Unique: 1Eez0QkqOwSLyQPfT0hoIw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ebfb986246so22161591fa.1 for ; Mon, 17 Jun 2024 06:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718632640; x=1719237440; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O0JUPirQNqI2sU1uefyA3Yit8Kc84wKus7JFkziy8ZU=; b=SjaFRRf6r/3lssLaVJmo44Nli1a/m+l+0XfOjNTVoMgKnGRhTOj2nSx5MYIzVwz/O7 ftn+5Qpn/wQWJ0sJirqFcD1ieuB2C0Hf5K+rgATc5XUilZg+13MlhTiJsUbgUiV44n71 PdUFOTyCEqu7i43QTRktCH6ptgMQcybx/odnoU9wkXQuvPjXkNLfURYXvB7LRE6o4S9d r41HdHuJAAV6PBtoQ4Xm7lgH8iiOe/olSUyD90aivlgNnzwyvxj5BzrWdG95iTjhWT/F 0GaByts5oFFsYx95i4sucpsXQ0kj/juQW0x6I+kifg9ZMnQKkW8eg7YjapMfJM64uFBP l4FA== X-Forwarded-Encrypted: i=1; AJvYcCUeFORFHXgNW9LOl8dOg3Z/TKA5L5VsiQW5Lnhz2K+FUbSCv1LBX5/1UAFwo2C+VkpPkZgjZQz99tKKt4o= X-Gm-Message-State: AOJu0Yx3WggvrK99sfyMXihXcFTd1l1arj3o0SYtxdijCvmCbJyq08S+ wwUK7h/wD0mqMn2R0rMvs17DJRiT5/FfBp75Q5M55b2jYNRXTyAcxlfB993wWG8hmlTToDv1kNS f9SYgESmpXw4PWQh65kBaGB/6EhRmvT+F8q/czEm9vCJiTayvyINwiNfvkOzBe++tdVe16sI+yg qu6+N7iNDVvmNi6bg= X-Received: by 2002:a2e:b0f7:0:b0:2ec:2b11:7d1 with SMTP id 38308e7fff4ca-2ec2b110833mr11730551fa.22.1718632640033; Mon, 17 Jun 2024 06:57:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkxNgjj/jQ1wnuc9jRivYGqRO7APi3zHIRuERfKmqmbpPYx5otDG4/OYKDmw7o22GVG4VCNrcsKeRzK4ZSHKM= X-Received: by 2002:a2e:b0f7:0:b0:2ec:2b11:7d1 with SMTP id 38308e7fff4ca-2ec2b110833mr11730451fa.22.1718632639686; Mon, 17 Jun 2024 06:57:19 -0700 (PDT) MIME-Version: 1.0 References: <20230927150854.3670391-1-paul.szczepanek@arm.com> <20240611125947.511243-1-paul.szczepanek@arm.com> <5a08b8ba-ec32-4f33-a2f7-cb12444c2ffc@arm.com> In-Reply-To: <5a08b8ba-ec32-4f33-a2f7-cb12444c2ffc@arm.com> From: David Marchand Date: Mon, 17 Jun 2024 15:57:08 +0200 Message-ID: Subject: Re: [PATCH v15 0/6] add pointer compression API To: Paul Szczepanek Cc: nd@arm.com, dev@dpdk.org, Honnappa Nagarahalli , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Konstantin Ananyev , Bruce Richardson , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 17, 2024 at 3:47=E2=80=AFPM Paul Szczepanek wrote: > This will solve it: > > diff --git a/lib/ptr_compress/rte_ptr_compress.h > b/lib/ptr_compress/rte_ptr_compress.h > index b9ab17b2db..a779f21fda 100644 > --- a/lib/ptr_compress/rte_ptr_compress.h > +++ b/lib/ptr_compress/rte_ptr_compress.h > @@ -141,7 +141,7 @@ rte_ptr_compress_32_shift(void *ptr_base, void * > const *src_table, > i +=3D svcntd(); > } while (i < n); > #elif defined __ARM_NEON && !defined RTE_ARCH_ARMv8_AARCH32 > - uint64_t ptr_diff; > + uintptr_t ptr_diff; > uint64x2_t v_ptr_table; > /* right shift is done by left shifting by negative int */ > int64x2_t v_shift =3D vdupq_n_s64(-bit_shift); > @@ -202,7 +202,7 @@ rte_ptr_decompress_32_shift(void *ptr_base, uint32_t > const *src_table, > i +=3D svcntd(); > } while (i < n); > #elif defined __ARM_NEON && !defined RTE_ARCH_ARMv8_AARCH32 > - uint64_t ptr_diff; > + uintptr_t ptr_diff; > uint64x2_t v_ptr_table; > int64x2_t v_shift =3D vdupq_n_s64(bit_shift); > uint64x2_t v_ptr_base =3D vdupq_n_u64((uint64_t)ptr_base); > @@ -215,7 +215,7 @@ rte_ptr_decompress_32_shift(void *ptr_base, uint32_t > const *src_table, > } > /* process leftover single item in case of odd number of n */ > if (unlikely(n & 0x1)) { > - ptr_diff =3D ((uint64_t) src_table[i]) << bit_shift; > + ptr_diff =3D ((uintptr_t) src_table[i]) << bit_shift; > dest_table[i] =3D RTE_PTR_ADD(ptr_base, ptr_diff); > } > #else > > Do you want me to make a separate patch? Yes please. --=20 David Marchand