From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75E4342CFC; Mon, 19 Jun 2023 16:11:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 027C940E0F; Mon, 19 Jun 2023 16:11:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C69D140DF8 for ; Mon, 19 Jun 2023 16:11:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687183913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aQapyEvSCRmCBgASzTx3rxpH8bVqjg9QYaQY729G+Hk=; b=dalPqv/NRLO2byol5HrtL5CbHq7aNSafYT6YX51sSGORS3X+p3+P0OysUYOI0eqVK0QUPg ff/KR1VcgvfbR4ly7oe62CDnBdrPiq8dAbtb4C4sDIYTCK7SNDx/eU4glwXJl3sBYaLaBU 9jNo/m6o7s8HvD54QpbgZnC4jlcxiS4= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-yeuToJAdNZWE4GgaGJeDZQ-1; Mon, 19 Jun 2023 10:11:51 -0400 X-MC-Unique: yeuToJAdNZWE4GgaGJeDZQ-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-51a5c1e9fbdso1051204a12.1 for ; Mon, 19 Jun 2023 07:11:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687183910; x=1689775910; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aQapyEvSCRmCBgASzTx3rxpH8bVqjg9QYaQY729G+Hk=; b=M+HKlG76pDRr7q/MY3FG1Z5XNT4DG5N98od4WIKdD4WEhnr9JPAMeSZN9JMRT/th6U myawD0MSYM3lsMNNCxxGSTSnMRSsZwm6O91/xtny6t19FIs6imSkxuvsIlqTBjeMnOEn FFsN/O4YfOF/ElBS2Zbjo5MrjI93NO2gThsMwnxHKOST8CqZgOsgDmNZlX8DA7qNNCiD 30ltZVCJH/moywwRQ/qN8fImLGIhfdVyK8OKh+wz50pWEBfeSpTbALsXa7NUvu3qA2T0 1mgjaTHkGStH4a7+cC9ve0RTBMWS+5iVKGsiS+TdNTzxejBS1wo+IJdMI9Da7jILzr56 rBqg== X-Gm-Message-State: AC+VfDxVyVAgtW6zdujJJ9mV2uXbrY+aKkUpXcEU+cGhaw19HQSTiJY1 vCFnwKxMOD1ww76fcinU6D+5+dLkrpJsPEb01cRUnb4KF2y26mbPKKqTdXxt1m91c6J4/j7tWui iZt/bygtDgLL/0j4Z3PHCxE/EZho= X-Received: by 2002:a50:ee14:0:b0:51a:4d20:3b1c with SMTP id g20-20020a50ee14000000b0051a4d203b1cmr4687246eds.18.1687183910385; Mon, 19 Jun 2023 07:11:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dARC3sb5etAVrASf94QCqQu1lDQb/sfzaQOo03nli/rtc6o94gtGhRIRu+sAhYxwuxKJOu0P6eWhNCZV7i9M= X-Received: by 2002:a50:ee14:0:b0:51a:4d20:3b1c with SMTP id g20-20020a50ee14000000b0051a4d203b1cmr4687229eds.18.1687183910102; Mon, 19 Jun 2023 07:11:50 -0700 (PDT) MIME-Version: 1.0 References: <20211117112847.7362-6-david.marchand@redhat.com> <20230616071450.3542479-1-david.marchand@redhat.com> In-Reply-To: <20230616071450.3542479-1-david.marchand@redhat.com> From: David Marchand Date: Mon, 19 Jun 2023 16:11:37 +0200 Message-ID: Subject: Re: [PATCH v3] build: select optional libraries To: dev@dpdk.org, Bruce Richardson Cc: thomas@monjalon.net, bluca@debian.org, tredaelli@redhat.com, i.maximets@ovn.org, james.r.harris@intel.com, mohammed@hawari.fr, Aaron Conole , Michael Santana X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 16, 2023 at 9:21=E2=80=AFAM David Marchand wrote: > @@ -141,13 +137,25 @@ foreach l:libraries > deps +=3D ['eal'] > endif > > - if disabled_libs.contains(l) > + if not enable_libs.contains(l) > + build =3D false > + reason =3D 'not in enabled libraries build config' > + elif disable_libs.contains(l) > build =3D false > reason =3D 'explicitly disabled via build config' > - if dpdk_libs_deprecated.contains(l) > + endif There is also a change in behavior for current users of the -Ddisable_libs=3D configuration (which was used for enabling deprecated libraries, for example). My current solution resides in making disable_libs and enable_libs options being mutually exclusive (meaning that presence of a value for enable_libs will ignore any configuration around disable_libs). Does it look ok to you? --=20 David Marchand