From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06E78A0A05; Wed, 20 Jan 2021 09:36:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A221140DE9; Wed, 20 Jan 2021 09:36:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 594AD140DE2 for ; Wed, 20 Jan 2021 09:36:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611131785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4KsCSA2dWxUMBVKvyaASNYhBGQgWhxrUvem1xgjRTY8=; b=MEwineM/JSZA2FzEW0ZI87Vcx6YqGpS4L8qsMmRuGdzE4cpQW3wr1bLk6Dx2SKgkrNQ/n3 LDREIxlGt99iMpHLzCBUNW8wUMEcLnZUPrqCqvAR72EDc74U+IQaU4ldSDopKfgKnAj+2m Yf3XR/b8WlPStahOGQXau9D2Jf3iAmo= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-UwaDJDq-M42uxXGOrdEyXA-1; Wed, 20 Jan 2021 03:36:12 -0500 X-MC-Unique: UwaDJDq-M42uxXGOrdEyXA-1 Received: by mail-ua1-f72.google.com with SMTP id 9so8656019uas.17 for ; Wed, 20 Jan 2021 00:36:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4KsCSA2dWxUMBVKvyaASNYhBGQgWhxrUvem1xgjRTY8=; b=Ofr1qEnLRWUpabvLIzuotmW1vqtGAv6B8yXAnQbWdHlhcoarrJuC5UMhlDciEQNZpR N2Y6COhH9bG+ajuNhAZOqGIcsgtSfVPdCx963KbC+aSruDP7ryboYtT1ktZ1nqWVOJAH O0aV2hZWaaXjmUXh7FOQnue6RxvqFszRs/VyXTZIMGWiybTHxh6I+uIjdU0LCL/9U6Az R02YusAFo3/0V8WSlsMYVzne337CHtN7pge/09CQ+ZGVTspYemttPdTbYlOcVDLTYEdN nFfNWW1zfequwwHTSc2a3ehqrEr1VF7pRHn7KuP2JHz23KLUTFNYVZas+gDYWOtBx648 swqg== X-Gm-Message-State: AOAM530x45cD9w5HfPw5VKltLBI5jDHUbAbtQvhlyX01tzadZbJW/vsT 99ZM5TqCVJsUkIUXglwxep86rj7BcmBLXB5sVf48vxQ/yhHBlX8ADh6HDiRITrPrLw/bOvxw16o FbB3FwLwB9TCtqSeLhQU= X-Received: by 2002:ab0:44c6:: with SMTP id n64mr5347885uan.53.1611131771609; Wed, 20 Jan 2021 00:36:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1lcpnjkOHXv3SpuPDYOYTktqr934/12uwjIS9snQ9RMgr1HxIWPvGN/S0VuaBCmtTIvxYHqskEwAw4Nt2l0k= X-Received: by 2002:ab0:44c6:: with SMTP id n64mr5347880uan.53.1611131771376; Wed, 20 Jan 2021 00:36:11 -0800 (PST) MIME-Version: 1.0 References: <20201215021945.103396-1-leyi.rong@intel.com> <20210114063951.2580-1-leyi.rong@intel.com> <2f4e5455-2c11-9f90-fc8e-ac5d1601536e@intel.com> In-Reply-To: From: David Marchand Date: Wed, 20 Jan 2021 09:36:00 +0100 Message-ID: To: Tal Shnaiderman Cc: Ali Alnubani , Ferruh Yigit , Odi Assli , "Rong, Leyi" , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Xing, Beilei" , "Kadam, Pallavi" , "Menon, Ranjit" , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Raslan Darawsheh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 20, 2021 at 7:26 AM Tal Shnaiderman wrote: > > The patch "add AVX512 vector path" also caused a build failure when cross > > compiling on Linux using mingw, and it's still reproducing in next-net > > (517969c95). > > > > ``` > > $ meson --werror --buildtype=debugoptimized --cross-file config/x86/cross- > > mingw -Dexamples=helloworld build && ninja-build -C build -j32 > > > > [221/232] Generating symbol file lib/librte_mbuf-21.dll.p/librte_mbuf- > > 21.dll.symbols > > [222/232] Generating symbol file lib/librte_hash-21.dll.p/librte_hash- > > 21.dll.symbols > > [223/232] Linking target lib/librte_net-21.dll [224/232] Compiling C object > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj > > FAILED: drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj > > ... > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj.d -o > > drivers/net/i40e/libi40e_avx512_lib.a.p/i40e_rxtx_vec_avx512.c.obj -c > > ../../root/dpdk/drivers/net/i40e/i40e_rxtx_vec_avx512.c > > {standard input}: Assembler messages: > > {standard input}:112: Error: invalid register for .seh_savexmm {standard > > input}:114: Error: invalid register for .seh_savexmm ... > > ... > > {standard input}:25351: Error: invalid register for .seh_savexmm {standard > > input}:25352: Error: invalid register for .seh_savexmm [225/232] Generating > > symbol file lib/librte_net-21.dll.p/librte_net-21.dll.symbols > > ninja: build stopped: subcommand failed. > > ``` > > > > OS: Fedora 32 > > Meson: 0.55.3 > > MinGW: Fedora MinGW 9.2.1-6.fc32 > > > > - Ali > > Those errors were detected in the CI tests for this patch [1], we should pay more attention to those now that 2 PMDs are supported on Windows. > > [1]: https://lab.dpdk.org/results/dashboard/patchsets/15164/ I won't grmbl about how CI reports are not being looked at (or maybe I just did :)). This simple patch seems to work for me: diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build index c0acdf4fd4..c9a1a50407 100644 --- a/drivers/net/i40e/meson.build +++ b/drivers/net/i40e/meson.build @@ -54,7 +54,7 @@ if arch_subdir == 'x86' cc.has_argument('-mavx512f') and cc.has_argument('-mavx512bw')) - if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true + if not is_windows and (i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true) cflags += ['-DCC_AVX512_SUPPORT'] avx512_args = [cflags, '-mavx512f', '-mavx512bw'] if cc.has_argument('-march=skylake-avx512') If nobody has a better fix, I'll send it later. -- David Marchand