Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver

[David Marchand <david.marchand@redhat.com>]

On Mon, Nov 4, 2024 at 9:46 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 11/4/2024 2:42 AM, Junlong Wang wrote:
> >>>   net/zxdh: add zxdh get device backend infos
> >>>   net/zxdh: add configure zxdh intr implementation
> >>>   net/zxdh: add zxdh dev infos get ops
> >>>   net/zxdh: add zxdh dev configure ops
> >>>
> >
> >> Hi Junlong,
> >
> >> I can see not all of the eth_dev_ops implemented, and datapath not
> >> implemented, so driver is not functional right now.
> >
> >> What happens if you want to run testpmd with the current state of the
> >> driver, I assume it crashes?
> >
> >> And what is the plan for the driver? Are you planning to upstream
> >> remaining support in this release or in future releases?
> >
> >> As the driver is not functional yet, to set the expectation right for
> >> the users, I suggest marking driver as experimental in the maintainers
> >> file and document the restrictions in the driver documentation, also
> >> clarify this in the release notes update, what do you think?
> >
> > Hi Ferruh,
> >       The complete driver function has been implemented. At present, the driver function is integrated in batches.
> >       The integrated PMD does not cause the crash but cannot support all PMD functions.We plan to integrate the driver in this version and finally provide a complete and available driver.
> >       In the current phase, we will marking driver as experimental in the maintainers file and document the restrictions in the driver documentation, also clarify this in the release notes update.
> >       Thanks.
>
> Sounds good, thanks.
>
>
> Btw, build should be fine after each patch, but in this patch series
> there are warnings in some early patches, can you please fix them in
> next version?
>
> @Aaron, @David, what do you think to add patch by patch build to the CI?
> I hit the same issue in multiple series in this release.

I would love to have patch by patch tests too, but I don't think UNH
can handle such load.
We could limit at doing this patch by patch in GHA / ovsrobot only
(which I think it is done for OVS CI).


-- 
David Marchand