From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD85045C75; Mon, 4 Nov 2024 10:52:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE0A3402AF; Mon, 4 Nov 2024 10:52:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0E1DC4021F for ; Mon, 4 Nov 2024 10:52:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730713957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/LdMBVKeM/T7uYmAnE9m416bptSAcY5e1WzQktOGMu8=; b=avsBzucYFOrlqgP8wVZj7PcOgOlosW4pmG5hbznxCxXkTczCtczAaLhazBVO9DatWx9iND 1F4X8xXqIz6YTSa5FuqmsnFtrV06wp4jh3qr6wIHmC8w58lE4Bo1fEUG8C7hWGU4nzd7Gw nQh5qReXRvnSyqRr4hdoK6u0ZAY+EI0= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-jT0EB0wJNUKeJccBpJHXHQ-1; Mon, 04 Nov 2024 04:52:34 -0500 X-MC-Unique: jT0EB0wJNUKeJccBpJHXHQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fb4c08c02cso12326381fa.1 for ; Mon, 04 Nov 2024 01:52:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730713953; x=1731318753; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/LdMBVKeM/T7uYmAnE9m416bptSAcY5e1WzQktOGMu8=; b=mCM6XSkv5JXjl5S9+UgeBsHWvAt24naNjWJNdAf7zg1tRPQP0d3xXv8uA7DnMq+YYX vfzd58OvC3QpQ9KNNlsSFMe+/EFr5aVmTXOlkExx79Zlk827d6rdofMq34v+bB5P6Zor SCJunQEYCSX5DE9HqIp/g/5qjbB63LopX07mwhkNkxQ6QHOOrZSD3/vnzV/vdlelTlhM VO9PCgYLQL2QOrU3cfb2uLRIWM4pYxdcO26RPq6PK0lO/aDVpBKgmBM1Kh5Skb+qBdf2 mpj7MoxoYHBP/Id88lOuxRA89RmoDMIGzWirqqSCg8ee3J3rMGv7a7Nc9giaVOAJFdAL P+DQ== X-Forwarded-Encrypted: i=1; AJvYcCUy8WkXMw62oThbPMbN8pI44taX1KUgK++uC4E2QB4yq+syVOI0Zl5in9mVakRCRGyqp0I=@dpdk.org X-Gm-Message-State: AOJu0YwGlX27XrpY2OMX1TmsNWO/jTW2ZmmtDvwpn2Hz9LMBJPcG/Noz gva7LMMDpGunoMzyw6PkSqiO700HNtRw4UA7/Ev1Z3tRLd1u8qziZZTa9zFj6V+U3e0Hhn/mAJm 12SZtAZ/J5ayTJn2EjsnF7tWbDZqfiBRBUIRRUee2qPoEh7N429pFjM0mZTnDIraQinpEuJ3Mex cJQIcY8YJnNPYMG9E= X-Received: by 2002:a2e:d1a:0:b0:2fa:fc3f:d603 with SMTP id 38308e7fff4ca-2fdecc2f1b2mr47365481fa.43.1730713952700; Mon, 04 Nov 2024 01:52:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFb3ek9Hdrq8iGGatvALSsCVRzWt7KQbm0VQUOnVDa0I3W356Ji+NRNXC7EZXfI0fjXq40mdHCUIwvAsI75pjc= X-Received: by 2002:a2e:d1a:0:b0:2fa:fc3f:d603 with SMTP id 38308e7fff4ca-2fdecc2f1b2mr47365391fa.43.1730713952205; Mon, 04 Nov 2024 01:52:32 -0800 (PST) MIME-Version: 1.0 References: <20241101062156.2637339-1-wang.junlong1@zte.com.cn> <20241104024233.2775676-1-wang.junlong1@zte.com.cn> <5668533d-4105-4803-9d99-b45a4a2b86e1@amd.com> In-Reply-To: <5668533d-4105-4803-9d99-b45a4a2b86e1@amd.com> From: David Marchand Date: Mon, 4 Nov 2024 10:52:21 +0100 Message-ID: Subject: Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver To: Ferruh Yigit , Aaron Conole Cc: Junlong Wang , dev@dpdk.org, dpdklab , Stephen Hemminger , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 4, 2024 at 9:46=E2=80=AFAM Ferruh Yigit = wrote: > > On 11/4/2024 2:42 AM, Junlong Wang wrote: > >>> net/zxdh: add zxdh get device backend infos > >>> net/zxdh: add configure zxdh intr implementation > >>> net/zxdh: add zxdh dev infos get ops > >>> net/zxdh: add zxdh dev configure ops > >>> > > > >> Hi Junlong, > > > >> I can see not all of the eth_dev_ops implemented, and datapath not > >> implemented, so driver is not functional right now. > > > >> What happens if you want to run testpmd with the current state of the > >> driver, I assume it crashes? > > > >> And what is the plan for the driver? Are you planning to upstream > >> remaining support in this release or in future releases? > > > >> As the driver is not functional yet, to set the expectation right for > >> the users, I suggest marking driver as experimental in the maintainers > >> file and document the restrictions in the driver documentation, also > >> clarify this in the release notes update, what do you think? > > > > Hi Ferruh, > > The complete driver function has been implemented. At present, th= e driver function is integrated in batches. > > The integrated PMD does not cause the crash but cannot support al= l PMD functions.We plan to integrate the driver in this version and finally= provide a complete and available driver. > > In the current phase, we will marking driver as experimental in t= he maintainers file and document the restrictions in the driver documentati= on, also clarify this in the release notes update. > > Thanks. > > Sounds good, thanks. > > > Btw, build should be fine after each patch, but in this patch series > there are warnings in some early patches, can you please fix them in > next version? > > @Aaron, @David, what do you think to add patch by patch build to the CI? > I hit the same issue in multiple series in this release. I would love to have patch by patch tests too, but I don't think UNH can handle such load. We could limit at doing this patch by patch in GHA / ovsrobot only (which I think it is done for OVS CI). --=20 David Marchand