[PATCH] config/arm: fix warning for native build with meson >= 0.55

[PATCH] config/arm: fix warning for native build with meson >= 0.55

[David Marchand]

Caught in UNH logs for native compilation on ARM:

Program /...../dpdk/config/arm/armv8_machine.py found: YES
	(/...../dpdk/config/arm/armv8_machine.py)
WARNING: Project targeting '>= 0.57' but tried to use feature deprecated
	since '0.55.0': ExternalProgram.path. use ExternalProgram.full_path()
	instead

There is nothing to search, nor a reason to call the script with an
absolute path.
The script can be directly pointed at with files().

Fixes: 200b88cbe0e6 ("build: detect micro-arch on ARM")
Fixes: 6f3dbd306de0 ("build: increase minimum meson version to 0.57")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 config/arm/meson.build | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 55be7c8711..95500c8ed3 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -784,9 +784,8 @@ else
             # native build
             # The script returns ['Implementer', 'Variant', 'Architecture',
             # 'Primary Part number', 'Revision']
-            detect_vendor = find_program(join_paths(meson.current_source_dir(),
-                                                    'armv8_machine.py'))
-            cmd = run_command(detect_vendor.path(), check: false)
+            detect_vendor = py3 + files('armv8_machine.py')
+            cmd = run_command(detect_vendor, check: false)
             if cmd.returncode() == 0
                 cmd_output = cmd.stdout().to_lower().strip().split(' ')
                 implementer_id = cmd_output[0]
-- 
2.46.2

Re: [PATCH] config/arm: fix warning for native build with meson >= 0.55

[Robin Jarry]

David Marchand, Oct 28, 2024 at 14:10:
> Caught in UNH logs for native compilation on ARM:
>
> Program /...../dpdk/config/arm/armv8_machine.py found: YES
> 	(/...../dpdk/config/arm/armv8_machine.py)
> WARNING: Project targeting '>= 0.57' but tried to use feature deprecated
> 	since '0.55.0': ExternalProgram.path. use ExternalProgram.full_path()
> 	instead
>
> There is nothing to search, nor a reason to call the script with an
> absolute path.
> The script can be directly pointed at with files().
>
> Fixes: 200b88cbe0e6 ("build: detect micro-arch on ARM")
> Fixes: 6f3dbd306de0 ("build: increase minimum meson version to 0.57")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Reviewed-by: Robin Jarry <rjarry@redhat.com>

Re: [PATCH] config/arm: fix warning for native build with meson >= 0.55

[fengchengwen]

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/10/28 21:10, David Marchand wrote:
> Caught in UNH logs for native compilation on ARM:
> 
> Program /...../dpdk/config/arm/armv8_machine.py found: YES
> 	(/...../dpdk/config/arm/armv8_machine.py)
> WARNING: Project targeting '>= 0.57' but tried to use feature deprecated
> 	since '0.55.0': ExternalProgram.path. use ExternalProgram.full_path()
> 	instead
> 
> There is nothing to search, nor a reason to call the script with an
> absolute path.
> The script can be directly pointed at with files().
> 
> Fixes: 200b88cbe0e6 ("build: detect micro-arch on ARM")
> Fixes: 6f3dbd306de0 ("build: increase minimum meson version to 0.57")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  config/arm/meson.build | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 55be7c8711..95500c8ed3 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -784,9 +784,8 @@ else
>              # native build
>              # The script returns ['Implementer', 'Variant', 'Architecture',
>              # 'Primary Part number', 'Revision']
> -            detect_vendor = find_program(join_paths(meson.current_source_dir(),
> -                                                    'armv8_machine.py'))
> -            cmd = run_command(detect_vendor.path(), check: false)
> +            detect_vendor = py3 + files('armv8_machine.py')
> +            cmd = run_command(detect_vendor, check: false)
>              if cmd.returncode() == 0
>                  cmd_output = cmd.stdout().to_lower().strip().split(' ')
>                  implementer_id = cmd_output[0]

Re: [PATCH] config/arm: fix warning for native build with meson >= 0.55

[David Marchand]

On Mon, Oct 28, 2024 at 2:11 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Caught in UNH logs for native compilation on ARM:
>
> Program /...../dpdk/config/arm/armv8_machine.py found: YES
>         (/...../dpdk/config/arm/armv8_machine.py)
> WARNING: Project targeting '>= 0.57' but tried to use feature deprecated
>         since '0.55.0': ExternalProgram.path. use ExternalProgram.full_path()
>         instead
>
> There is nothing to search, nor a reason to call the script with an
> absolute path.
> The script can be directly pointed at with files().
>
> Fixes: 200b88cbe0e6 ("build: detect micro-arch on ARM")
> Fixes: 6f3dbd306de0 ("build: increase minimum meson version to 0.57")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


-- 
David Marchand