From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 54455A0471 for ; Tue, 18 Jun 2019 13:09:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4740F1C0CE; Tue, 18 Jun 2019 13:09:13 +0200 (CEST) Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by dpdk.org (Postfix) with ESMTP id ECE011C00F for ; Tue, 18 Jun 2019 13:09:11 +0200 (CEST) Received: by mail-ua1-f65.google.com with SMTP id o19so5440607uap.13 for ; Tue, 18 Jun 2019 04:09:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=owbfucpjupnX73nEgY/yFkOnjrMf4lk7iBkTpurZ0qc=; b=UzRnUxUNjvgIqVzqJsNg8BTRsQ/YOghwgQtoHcYcbZGa7B7AByOwh6RQiIkMitLz+g DpBicAF8JO00/JyLWqaOPHCUVW1QHutdWH8Vp6vKbCf+/KCNPD6+7M6Y9fKRhFMRcrtr Q7vGqOh2VUWEhrkoCoIj9Eo4XwLCbbStv+UyT5pWOyWFbk44vhZhcqAnyfHfgSbnyMFJ qU6JqLREVov3oNiToBfEnoqFUiNrUeS8TN/i6pT9kJk8J0x9Mt4k/WEQTgJLt3xzjPah rO9XD1+MFXDZ4bcRe+tftqD/lC9XarYrvpgBVrx/mnbHVKMTYKz6ZGf3jPBe87l+46Hv Jncg== X-Gm-Message-State: APjAAAW98Pwk9mqVfdmZPfZMPvW8iJS+qzsXgD3YmpvLtaHzWyW3wT80 PWJs+wQy5h1qgUsXxyTZ5F+4xz3vOtNQxnQb9PyCWA== X-Google-Smtp-Source: APXvYqzL82xE3cPSPPLxePXQcnubLbkkrQ9T56rqxHGcHAQU0B/Iwibt3xKfvQy6IhoBanTL2c1+6geEBAZhGE/Eaf0= X-Received: by 2002:a67:688f:: with SMTP id d137mr53746465vsc.198.1560856151238; Tue, 18 Jun 2019 04:09:11 -0700 (PDT) MIME-Version: 1.0 References: <20190618105950.9599-1-andrius.sirvys@intel.com> In-Reply-To: <20190618105950.9599-1-andrius.sirvys@intel.com> From: David Marchand Date: Tue, 18 Jun 2019 13:09:00 +0200 Message-ID: To: Andrius Sirvys Cc: dpdk stable , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , "Yigit, Ferruh" , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 18, 2019 at 12:59 PM Andrius Sirvys wrote: > crc_strip was removed from lib/librte_ethdev/rte_ethdev.c as the > NICs carry out this operation themselves. However once removed, > the references to it we're forgotten to be taken out in test-pmd. > > Fixes: 323e7b667f18 ("ethdev: make default behavior CRC strip on Rx") > Cc: ferruh.yigit@intel.com > > Signed-off-by: Andrius Sirvys > --- > app/test-pmd/cmdline.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index d1e0d4402..cd3f33add 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -878,7 +878,7 @@ static void cmd_help_long_parsed(void *parsed_result, > "port config rx_offload vlan_strip|" > > "ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|" > "outer_ipv4_cksum|macsec_strip|header_split|" > - "vlan_filter|vlan_extend|jumbo_frame|crc_strip|" > + "vlan_filter|vlan_extend|jumbo_frame|" > "scatter|timestamp|security|keep_crc on|off\n" > " Enable or disable a per port Rx offloading" > " on all Rx queues of a port\n\n" > @@ -886,7 +886,7 @@ static void cmd_help_long_parsed(void *parsed_result, > "port (port_id) rxq (queue_id) rx_offload > vlan_strip|" > > "ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|" > "outer_ipv4_cksum|macsec_strip|header_split|" > - "vlan_filter|vlan_extend|jumbo_frame|crc_strip|" > + "vlan_filter|vlan_extend|jumbo_frame|" > "scatter|timestamp|security|keep_crc on|off\n" > " Enable or disable a per queue Rx offloading" > " only on a specific Rx queue\n\n" > @@ -17991,7 +17991,7 @@ cmdline_parse_token_string_t > cmd_config_per_port_rx_offload_result_offload = > offload, > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > - > "crc_strip#scatter#timestamp#security#keep_crc"); > + "scatter#timestamp#security#keep_crc"); > cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off > = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_port_rx_offload_result, > @@ -18067,7 +18067,7 @@ cmdline_parse_inst_t > cmd_config_per_port_rx_offload = { > .help_str = "port config rx_offload > vlan_strip|ipv4_cksum|" > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > "macsec_strip|header_split|vlan_filter|vlan_extend|" > - > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > + "jumbo_frame|scatter|timestamp|security|keep_crc " > "on|off", > .tokens = { > (void *)&cmd_config_per_port_rx_offload_result_port, > @@ -18117,7 +18117,7 @@ cmdline_parse_token_string_t > cmd_config_per_queue_rx_offload_result_offload = > offload, > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > "qinq_strip#outer_ipv4_cksum#macsec_strip#" > > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > - > "crc_strip#scatter#timestamp#security#keep_crc"); > + "scatter#timestamp#security#keep_crc"); > cmdline_parse_token_string_t > cmd_config_per_queue_rx_offload_result_on_off = > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_queue_rx_offload_result, > @@ -18169,7 +18169,7 @@ cmdline_parse_inst_t > cmd_config_per_queue_rx_offload = { > "vlan_strip|ipv4_cksum|" > > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > "macsec_strip|header_split|vlan_filter|vlan_extend|" > - > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > + "jumbo_frame|scatter|timestamp|security|keep_crc " > "on|off", > .tokens = { > (void *)&cmd_config_per_queue_rx_offload_result_port, > -- > 2.17.1 > Rather than fix this list in all those places, is it possible to use rte_rx_offload_names[] in a little wrapper in testpmd? The same would have to be done with the tx flags after this. -- David Marchand