From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0838045B51; Wed, 16 Oct 2024 17:37:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EFBD40150; Wed, 16 Oct 2024 17:37:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AEE48400D6 for ; Wed, 16 Oct 2024 17:37:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729093021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Tp5CciAm16cZCrhBtPhSfJ9KoBoJqUQGJR9tPAk9gk=; b=dWBsDHFsUxbIMiLhzr+VgRx6oYybY1vf1Iqx7aFyN+vqxvhj64YvFegWfF2W4p5fWe9Ozg z6PAdBJuW27qe3NjQvdUDbm7goSI6iTPxbJyCfRC65lPUATlF3d+f5xmGm2XDelCnoRa7K ncTRS7kB3uZnAz8QMfU6KErmQ+eM//s= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-QCy-S77HOge8syOxyu3xCg-1; Wed, 16 Oct 2024 11:36:59 -0400 X-MC-Unique: QCy-S77HOge8syOxyu3xCg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2fb3da343ceso31715871fa.0 for ; Wed, 16 Oct 2024 08:36:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729093018; x=1729697818; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Tp5CciAm16cZCrhBtPhSfJ9KoBoJqUQGJR9tPAk9gk=; b=qQjC0ZOnomFN1THSOr6OwGSkovg7Hcah8cJkd/a8+KHzNju3PwK7egVaUJBX7UCDjT eHyKgp22V6h6c/5XglGHYEaDh823wMQt3Q5NouAnUISWB5lClbxujxZUWeD1yUcbGwj0 tiL6AmLES3/p9bsS5iW8QuVBmCXZlbBPwbG3N4opaDTFUwfus3ASADHCVYaAzNX9g+24 k8HHU1BhbnV3n3AsxmycZoWzc63Mcti7D5Kv/vjP515FGiF5gY/w06+TxRmTpsiyvbsJ bQ57dKYzmv6CFdCjD8qJkuLfArMdp0EnLx/kJM8pthiblyd+OnX9pz175pNJEuyEkWPD TbqQ== X-Gm-Message-State: AOJu0YzIRXbsl0osSuOCSIQLtbFde+aztj6jPqHPKkX/Xt9fixcEAPyb Dmv6PFWqPR6tdIe2xcS+Tytzmc+dkgYTBdJvdecHf//bNEhTh+LagO/56uLyeSW7F+dlRIxB6HE 5IcmkIazqV/limVaB+w2SoN3FXsqUmN9ICfmmT9SukjwtH2A9pV6SqONjufDhA3jUsrJnJsSui6 gOvCdifID+BhXgv3M= X-Received: by 2002:a2e:6102:0:b0:2fb:441a:90d with SMTP id 38308e7fff4ca-2fb61b58749mr24313401fa.21.1729093018117; Wed, 16 Oct 2024 08:36:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFI3TV/F6hmhWnNGBaVFCqp2G0Oc2sy/Qv8LhVge0+ZoxYozZPNUTEhuTJu3AcXjzaPcOYkFGuBglpkN3yFETw= X-Received: by 2002:a2e:6102:0:b0:2fb:441a:90d with SMTP id 38308e7fff4ca-2fb61b58749mr24313181fa.21.1729093017608; Wed, 16 Oct 2024 08:36:57 -0700 (PDT) MIME-Version: 1.0 References: <20241015121046.2556695-1-david.marchand@redhat.com> <20241016113817.3956187-1-david.marchand@redhat.com> <20241016113817.3956187-3-david.marchand@redhat.com> <56a2edd6-b464-47af-a56f-a8766e57cb2c@lysator.liu.se> In-Reply-To: <56a2edd6-b464-47af-a56f-a8766e57cb2c@lysator.liu.se> From: David Marchand Date: Wed, 16 Oct 2024 17:36:46 +0200 Message-ID: Subject: Re: [PATCH v2 2/4] bitset: fix build for GCC without experimental API To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com, ktraynor@redhat.com, =?UTF-8?Q?Morten_Br=C3=B8rup?= , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Tyler Retzlaff X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 16, 2024 at 4:14=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > On 2024-10-16 13:38, David Marchand wrote: > > For a reason similar to the change on bitops header, hide bitset > > implementation relying on experimental API. > > > > Fixes: 99a1197647d8 ("eal: add bitset type") > > > > Signed-off-by: David Marchand > > Acked-by: Morten Br=C3=B8rup > > --- > > lib/eal/include/rte_bitset.h | 123 ++++++++++++++++++++++++++++++++++= + > > 1 file changed, 123 insertions(+) > > > > diff --git a/lib/eal/include/rte_bitset.h b/lib/eal/include/rte_bitset.= h > > index 74c643a72a..8ae8425fc2 100644 > > --- a/lib/eal/include/rte_bitset.h > > +++ b/lib/eal/include/rte_bitset.h > > @@ -255,7 +255,13 @@ __rte_experimental > > static inline bool > > rte_bitset_test(const uint64_t *bitset, size_t bit_num) > > { > > +#ifdef ALLOW_EXPERIMENTAL_API > > return __RTE_BITSET_DELEGATE(rte_bit_test, bitset, bit_num); > > +#else > > + RTE_SET_USED(bitset); > > + RTE_SET_USED(bit_num); > > + return false; > > This is no RTE_VERIFY(0) here, because this is just dummy code, that > will never be run. Is that correct? Adding a RTE_VERIFY(false) is an interesting idea. It is not supposed to be run, indeed. Do you prefer I respin with this? --=20 David Marchand