From: David Marchand <david.marchand@redhat.com>
To: Andre Muezerie <andremue@linux.microsoft.com>,
Wisam Jaddo <wisamm@nvidia.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] test-flow-perf: Enable to build on Windows
Date: Fri, 29 Aug 2025 15:04:10 +0200 [thread overview]
Message-ID: <CAJFAV8y5C3-TZ-m-xECRZi3=tMqUE1BUahpE=-UfTxPWaXWRdQ@mail.gmail.com> (raw)
In-Reply-To: <1754423992-24652-1-git-send-email-andremue@linux.microsoft.com>
Hello,
On Tue, 5 Aug 2025 at 22:00, Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> This patch fixes some issues which were preventing this test to be
> built on Windows:
>
> - Remove VLAs (not supported by msvc).
> - Replace strsep() (which is not natively available on Windows)
> with strtok_r().
> - Remove the "thousands" separator from printf() calls as it is
> not available on Windows.
Can we use rte_size_to_str() instead?
> - Include the test in the Windows build.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Otherwise it lgtm.
--
David Marchand
prev parent reply other threads:[~2025-08-29 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 19:59 Andre Muezerie
2025-08-29 13:04 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8y5C3-TZ-m-xECRZi3=tMqUE1BUahpE=-UfTxPWaXWRdQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wisamm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).