DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk stable <stable@dpdk.org>, dev <dev@dpdk.org>,
	Matan Azrad <matan@mellanox.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
	 Raslan <rasland@mellanox.com>, Luca Boccassi <bluca@debian.org>,
	Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net: fix mlx* glue libraries ABI version
Date: Thu, 7 May 2020 14:35:35 +0200	[thread overview]
Message-ID: <CAJFAV8y5FBDea2-dm8z=DdnyuHJQ-_-Fjr_juEC=MfQXynSeQQ@mail.gmail.com> (raw)
In-Reply-To: <9272526.6B3L8A1auC@xps>

On Thu, Dec 12, 2019 at 11:18 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 04/12/2019 11:05, David Marchand:
> > Those libraries have been missed when switching to global ABI version.
>
> The versioning of the glue libraries are for compatibility checks
> between the PMD and its dependency (rdma-core) packaged as a plugin,
> called glue library.
>
> This versioning is updated when there is a change in the verbs glue
> interface, in order to avoid issues in case of PMD and glue
> updated separately with a non-compatible version.
> I don't think the mlx glue libraries are part of the ABI policy
> which acts at the application level.
>
> Am I missing something?

Sorry, this patch fell into the cracks.

I agree that this is not part of the ABI policy.
This version only indicates something internal.

But what I am proposing here is just to remove this special case.
What is the point of exposing a special version, while the net drivers
are the only one depending on those glue libs?
Do you expect separate packaging for the net driver and its associated glue lib?

This special version also makes it impossible to install two versions
of dpdk if those versions of dpdk need the same glue version.

I still think it is better to align to the version of dpdk, though the
commitlog needs some work.


-- 
David Marchand


  reply	other threads:[~2020-05-07 12:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 10:05 [dpdk-dev] " David Marchand
2019-12-12 22:17 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-05-07 12:35   ` David Marchand [this message]
2020-05-07 20:04     ` Thomas Monjalon
2020-10-19  9:41 ` [dpdk-dev] [PATCH v2] drivers: remove mlx* glue libraries separate " David Marchand
2020-10-27 12:13   ` David Marchand
2020-11-01 14:48   ` Thomas Monjalon
2020-11-01 15:02     ` Slava Ovsiienko
2020-11-01 15:09   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8y5FBDea2-dm8z=DdnyuHJQ-_-Fjr_juEC=MfQXynSeQQ@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=mdr@ashroe.eu \
    --cc=rasland@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).