From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87E10A0093; Tue, 4 Jan 2022 16:06:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1690E40042; Tue, 4 Jan 2022 16:06:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4690240040 for ; Tue, 4 Jan 2022 16:06:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641308781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QduvTKSvX60xCDslaZdvV+TVoTR3Hy+6JfDJBDIDLPI=; b=YTDcow5GbYb5VZXUy8OescTHOi/O7VfI4ylsIBhO3awqblUNN/PJbzY9D4xp6v6WxwI6w3 XUWDouvNP/UHK3D4rXPhxyB+3G+Rfu4ofUAj7VLkJaz8Ta/9qOdd8y3fXHVyygkjs3f6Ss ox6Xlyl2c8V74TTaIclyW4u9bmH6rxI= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-364-027d0t2hNu2uED2Zy5Z6lg-1; Tue, 04 Jan 2022 10:06:20 -0500 X-MC-Unique: 027d0t2hNu2uED2Zy5Z6lg-1 Received: by mail-lf1-f69.google.com with SMTP id r21-20020ac25f95000000b004259e6ab262so8070240lfe.6 for ; Tue, 04 Jan 2022 07:06:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QduvTKSvX60xCDslaZdvV+TVoTR3Hy+6JfDJBDIDLPI=; b=2w6VfQe6fHS1lte/afidR9l8/iqrsGwFlj5iMqvvpywXnnRfkDTD5tQfZbJrXn9lbH natzetKaXyhFzg3yPG/y+sfcNUXiLeM/s9x+CMQ2NAOCNSljO1gKC97sPaYBSsOOWZyr QXf/IaPZ7BZ1OyZZV/UHXAXV+2v03VyRNvYDHv8/z+yK6pLKW64NH7+Fdy6a1CeD35dl PSI9cX3QoaWu2soDtvUp7hX+mNA+MXRkZRydXXcaC26H/u7aNqgs/WKFJg1fXYslvw09 GsdHwAXWBe/9Mnh9jBtVUla4rdTlXyuF7tWaJtIVe4Diaw7tXK6aXUErwUrWtijHEVF2 HXzA== X-Gm-Message-State: AOAM531vuBFPQTmoor3Q2ua1umT9KrnsXwnXISQ+tlmNknn91hQ2k344 XrMZaHTdbso1ye/4EibB2J45VJzbj6PQX6D1V4PZLPpmAEftVXRYMoyMmj+x9zpbUWxEN5oa1Y0 TB7fJK8Gn8CeS6ETg/uY= X-Received: by 2002:a2e:720a:: with SMTP id n10mr33765607ljc.333.1641308768613; Tue, 04 Jan 2022 07:06:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzC9eprxZEBUAwdiP8RP3yv4K9wMxmgd4NH8ukdUCW/S/OQnTLA0gIQJrEyn50Os5TZv8qw4eUqxMvkKS+If2w= X-Received: by 2002:a2e:720a:: with SMTP id n10mr33765601ljc.333.1641308768445; Tue, 04 Jan 2022 07:06:08 -0800 (PST) MIME-Version: 1.0 References: <20211223083659.245766-1-maxime.coquelin@redhat.com> In-Reply-To: <20211223083659.245766-1-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 4 Jan 2022 16:05:57 +0100 Message-ID: Subject: Re: [PATCH 0/7] vhost: improve logging To: Maxime Coquelin Cc: dev , "Xia, Chenbo" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 23, 2021 at 9:37 AM Maxime Coquelin wrote: > > This series aims at easing Vhost logs analysis, by > prepending the Vhost-user socket path to all logs and to > remove multi-line comments. Doing so, filtering Vhost-user > ports logs is much easier. > > Maxime Coquelin (7): > vhost: improve IOTLB logs > vhost: improve vDPA registration failure log > vhost: improve socket layer logs > vhost: improve Vhost layer logs > vhost: improve Vhost-user layer logs > vhost: improve Virtio-net layer logs > vhost: remove multi-line logs > > lib/vhost/iotlb.c | 26 +- > lib/vhost/iotlb.h | 10 +- > lib/vhost/socket.c | 131 ++++----- > lib/vhost/vdpa.c | 4 +- > lib/vhost/vhost.c | 106 ++++--- > lib/vhost/vhost_user.c | 653 ++++++++++++++++++++--------------------- > lib/vhost/virtio_net.c | 165 +++++------ > 7 files changed, 518 insertions(+), 577 deletions(-) Thanks for the series! I sent some comments. We can probably work more on those logs but this series is a good enhancement. -- David Marchand