From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 329FD43A99; Tue, 6 Feb 2024 11:29:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0975F402E1; Tue, 6 Feb 2024 11:29:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6C7C84025E for ; Tue, 6 Feb 2024 11:29:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707215385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HoGev3gwsmxoetbQ+Uwdl00cqf132T9zIdMEyXUjC/s=; b=VxcXlAr+/vChxRPmoapVE92v/1nXGHY3Xwmw/XErLiLLq/F/Ux/PluvsE2VKdfnTPTwSve 5L8Q3WUjth9zv5TBWLx6BXrPU9d7FTCy9uB8vZGYIGKpgzuzk62ZCQ/Zndheaa59kZmlZ+ uvFmCt+16JNr/+KDdrLBLcI8II5NlP8= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-Z5iXC7sOM_O9noqRTV92gg-1; Tue, 06 Feb 2024 05:29:42 -0500 X-MC-Unique: Z5iXC7sOM_O9noqRTV92gg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-511494630d8so2347622e87.0 for ; Tue, 06 Feb 2024 02:29:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707215381; x=1707820181; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HoGev3gwsmxoetbQ+Uwdl00cqf132T9zIdMEyXUjC/s=; b=Q6DvGGyFXxN09P3883c+vdW4J75ijdjw/EEJxlXrskJsdGegGBa44SWoot9hgBYNCy 7qlfyNo3Sg7KE2gqkxRkk+grvoBKrG26k+b37u5eiUtsWouxuWr708uE2lYl+t1Wefwk TTAsGPng6WeG0jW4UOi1uiDT9f0q9E9ZHFgiF5LGamUHDQrpD5SzN9FbbnDC/xZVhGpu QiYxzOIyghmpc5TDO6V2caHTcZOu+kGbFYdI82gCrxBoc1Z04Nxn6ZdkugvdH6eR4v6x rK4TtDcXGLBs1jqC19gLky67JnfKEOviMh9zuzpxL18ZMpoddks+z64rh0xsZJbTRabP 43Xw== X-Gm-Message-State: AOJu0YwQneceTQoxmQ0I0ebhYnALU4T7FjZlhjR9QZ8c748CKFf1BH8c kpNE9fd36x5KEFSQYgIodG4VxLa2/GDhbAK+uh6+MbHO6MX73HvTgQ3YlNQ9qHZ/kvhcDfyd0NR ArncmdveUKenCq99R/T57zC6XgCdP/Jthc1xXFdbKAsb3BZ6J9HnSNUe9gLaVCrarGOHqINcxfy ptz9xCbxJPBpN9yiI= X-Received: by 2002:a05:6512:401f:b0:510:161e:f04c with SMTP id br31-20020a056512401f00b00510161ef04cmr1627885lfb.62.1707215381129; Tue, 06 Feb 2024 02:29:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+LVobGmJthCWAlCDRSl8LoQcYL7WZnyO2sIAHP+KW9isz7RB+5nXqJB3KGvVxCv7O4rhcdnXJv2RlOA+l7vY= X-Received: by 2002:a05:6512:401f:b0:510:161e:f04c with SMTP id br31-20020a056512401f00b00510161ef04cmr1627872lfb.62.1707215380807; Tue, 06 Feb 2024 02:29:40 -0800 (PST) MIME-Version: 1.0 References: <20240131195309.2808015-1-maxime.coquelin@redhat.com> In-Reply-To: <20240131195309.2808015-1-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 6 Feb 2024 11:29:28 +0100 Message-ID: Subject: Re: [PATCH v2 1/2] vhost: fix memory leak in Virtio Tx split path To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com, bnemeth@redhat.com, echaudro@redhat.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 31, 2024 at 8:53=E2=80=AFPM Maxime Coquelin wrote: > > When vIOMMU is enabled and Virtio device is bound to kernel > driver in guest, rte_vhost_dequeue_burst() will often return > early because of IOTLB misses. In theory, we can hit this issue with a dpdk pmd too, as long as the vIOMMU is in use. But the consequence would be a "really small" leak which does not have the same impact as what was seen with the kernel driver which maps/unmaps pages associated with virtio-net skb way more often :-). So maybe rephrase this part emphasizing on the kernel case like: """ When vIOMMU is enabled, rte_vhost_dequeue_burst() can return early because of IOTLB misses. Such IOTLB misses are especially frequent when a Virtio device is bound to a kernel driver in guest. """ > > This patch fixes a mbuf leak occurring in this case. > > Fixes: 242695f6122a ("vhost: allocate and free packets in bulk in Tx spli= t") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin > Signed-off-by: David Marchand Reviewed-by: David Marchand --=20 David Marchand