From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CE1BA04B5; Wed, 4 Dec 2019 13:00:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 748481BE84; Wed, 4 Dec 2019 13:00:34 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 6FCA21BE83 for ; Wed, 4 Dec 2019 13:00:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575460831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dHYe38/SENauik6xnGz2ThKTFSJBkihZhlErnc7UGdo=; b=UbSY6RBGEqlDDsPpcw7pTDuMxgXgkYHPPtuh78vNzCHv2w+ZgJsOG+sVk67G2l+vAqthXT R4PCVgEmwo1uRmhpK5EWg+jJtkWRra1Y1opWWVkqrdEYwCX3Vt0zjIcDFKfuPDAZZsmo2l Ee6xQJy5KFa2+qd1YQZzHoia5wyw9D0= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-mA4uhvC-PUeqobM2CxZlbQ-1; Wed, 04 Dec 2019 07:00:25 -0500 Received: by mail-vk1-f199.google.com with SMTP id h14so2858913vke.10 for ; Wed, 04 Dec 2019 04:00:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fwrQZAsmqsTucMBBrb3R6G+AeTL4kBZ18fEQMnCVyww=; b=q9B5fJ5yJhA64bM/+aXryAlyvg30alSgBv1Vvlutbj5tIUPWRps6ne5UrFRug23EEr gVRrBXwSJr4OQUqL/MV4ZipJOsgCFQZyGZyUBYP3PPtqEs6lNLKqHhvGjvEuhIPMs9eZ vwoqBLzGZxjb/HgJByM9dENV1kgnPAR8a9MPG8rHfu3oqMBxVjukJbnfviOC3VJFf35S Zl4KPDXEpi5NHufxGlZ29wmwF3zyUbjXyxmtcMXfgEQ0kSw8CvBt1uLR0CiedxZ1Disj i740kPQeelaOlDxBuCFPXaY97QFll7o0h1OfngtiWPPoZvmzpDFPDWqgJp86U28AYYKU Y4VA== X-Gm-Message-State: APjAAAU2PRdDKFL+3w5aH+BUrokiFlMGCddIS703MP2n4wBcZhQbRJq9 qz6XSNb3h6NFewLcDQW3wraggoSy/L1wSrg49PZIQ42jA/1ESRVZYhV3lfMP40VctwOHh3TL4+k TZ3MzRSCtCqM2Fg9OIGs= X-Received: by 2002:a67:b303:: with SMTP id a3mr1227774vsm.141.1575460825158; Wed, 04 Dec 2019 04:00:25 -0800 (PST) X-Google-Smtp-Source: APXvYqzKQ8FJLvf+gLGZN9hrvJ2h+DmLu4xEJIgl7FWwOwE8n+9C8r6voKeUMBuqPDqVzZWhjR9P3BYjN4+ALzAGSt4= X-Received: by 2002:a67:b303:: with SMTP id a3mr1227760vsm.141.1575460824746; Wed, 04 Dec 2019 04:00:24 -0800 (PST) MIME-Version: 1.0 References: <20191129171024.56165-1-kevin.laatz@intel.com> <20191129210905.1865-1-kevin.laatz@intel.com> <20191204115631.GA2971@hmswarspite.think-freely.org> In-Reply-To: <20191204115631.GA2971@hmswarspite.think-freely.org> From: David Marchand Date: Wed, 4 Dec 2019 13:00:13 +0100 Message-ID: To: Neil Horman Cc: "Laatz, Kevin" , dev , Thomas Monjalon , Bruce Richardson , "Kinsella, Ray" X-MC-Unique: mA4uhvC-PUeqobM2CxZlbQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 0/7] Add ABI compatibility checks to the meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 4, 2019 at 12:56 PM Neil Horman wrote: > > On Wed, Dec 04, 2019 at 09:47:31AM +0100, David Marchand wrote: > > On Tue, Dec 3, 2019 at 4:27 PM Laatz, Kevin wro= te: > > > > Build targets in project: 1019 > > > > WARNING: Project specifies a minimum meson_version '>=3D 0.47.1' bu= t > > > > uses features which were added in newer versions: > > > > * 0.48.0: {'console arg in custom_target'} > > > > * 0.50.0: {'install arg in configure_file'} > > > > Found ninja-1.9.0 at /usr/bin/ninja > > > > ninja -C /home/dmarchan/builds/build-gcc-static > > > > ninja: Entering directory `/home/dmarchan/builds/build-gcc-static' > > > > [48/2291] Generating librte_kvargs.abi_chk with a meson_exe.py cust= om command. > > > > FAILED: lib/librte_kvargs.abi_chk > > > > /usr/bin/meson --internal exe > > > > /home/dmarchan/builds/build-gcc-static/meson-private/meson_exe_abid= iff_6511538ddd95d9672028017110fa45c67f01f7be.dat > > > > file /home/dmarchan/dpdk/lib/abi/librte_kvargs.dump does not exist > > > > [77/2291] Compiling C object > > > > 'lib/76b5a35@@rte_mbuf@sta/librte_mbuf_rte_mbuf.c.o'. > > > > ninja: build stopped: subcommand failed. > > > > > > This is failing as the .dump files have not been created yet. They ca= n > > > be generated with devtools/gen-abi-dump.sh . This will > > > generate a .dump file for each shared object in the builddir drivers = and > > > lib folders. > > > > Throwing an idea, I did not investigate. > > > > Could we refactor our tools/checks on the .map files to use the dump fi= les? > > We would then only maintain one file about symbols versioning. > > > Thats a chicken and egg problem. The map file is the canonical source fo= r > versioning information. Any information that is encoded in the output of = objdump > regarding versioning is sourced from the map files, so while you could us= e the > objdump output to check versioning, you can't remove the need for map fil= es to > encode it. Ah ah.. yes. ^U on this idea. --=20 David Marchand