DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Muhammad Asim Jamshed <asim.jamshed@gmail.com>
Cc: dev <dev@dpdk.org>,
	muhammad.jamshed@intel.com,  saikrishna.edupuganti@intel.com,
	 Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: Re: [dpdk-dev] [dpdk.org] [PATCH] fib: add "C" extern linkage for C++ programs
Date: Wed, 25 Mar 2020 14:21:50 +0100	[thread overview]
Message-ID: <CAJFAV8y6OgOZfNr54yNKLfUqEWej3=zdzpfg=kCqNnUcvC_DoQ@mail.gmail.com> (raw)
In-Reply-To: <20200316184236.15692-1-asim.jamshed@gmail.com>

Cc: maintainer.

On Mon, Mar 16, 2020 at 8:22 PM Muhammad Asim Jamshed
<asim.jamshed@gmail.com> wrote:
>
> This patch allows C++ programs to use librte_fib library routines.
> Previously C++ programs were not able to link this library and programs
> would fail to get linked. With this patch compilation and linking
> will be successful.
>
> Signed-off-by: Muhammad Asim Jamshed <asim.jamshed@gmail.com>
> Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
> ---
>  lib/librte_fib/rte_fib.h  | 8 ++++++++
>  lib/librte_fib/rte_fib6.h | 8 ++++++++
>  2 files changed, 16 insertions(+)
>
> diff --git a/lib/librte_fib/rte_fib.h b/lib/librte_fib/rte_fib.h
> index d06c5ef55..af3bbf07e 100644
> --- a/lib/librte_fib/rte_fib.h
> +++ b/lib/librte_fib/rte_fib.h
> @@ -14,6 +14,10 @@
>
>  #include <rte_compat.h>
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  struct rte_fib;
>  struct rte_rib;
>
> @@ -185,4 +189,8 @@ __rte_experimental
>  struct rte_rib *
>  rte_fib_get_rib(struct rte_fib *fib);
>
> +#ifdef __cplusplus
> +}
> +#endif
> +
>  #endif /* _RTE_FIB_H_ */
> diff --git a/lib/librte_fib/rte_fib6.h b/lib/librte_fib/rte_fib6.h
> index 426870403..66c71c84c 100644
> --- a/lib/librte_fib/rte_fib6.h
> +++ b/lib/librte_fib/rte_fib6.h
> @@ -14,6 +14,10 @@
>
>  #include <rte_compat.h>
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #define RTE_FIB6_IPV6_ADDR_SIZE                16
>  /** Maximum depth value possible for IPv6 FIB. */
>  #define RTE_FIB6_MAXDEPTH       128
> @@ -190,4 +194,8 @@ __rte_experimental
>  struct rte_rib6 *
>  rte_fib6_get_rib(struct rte_fib6 *fib);
>
> +#ifdef __cplusplus
> +}
> +#endif
> +
>  #endif /* _RTE_FIB6_H_ */
> --
> 2.17.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


  reply	other threads:[~2020-03-25 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 18:42 Muhammad Asim Jamshed
2020-03-25 13:21 ` David Marchand [this message]
2020-04-10  9:04   ` David Marchand
2020-03-26 10:40 ` Medvedkin, Vladimir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8y6OgOZfNr54yNKLfUqEWej3=zdzpfg=kCqNnUcvC_DoQ@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=asim.jamshed@gmail.com \
    --cc=dev@dpdk.org \
    --cc=muhammad.jamshed@intel.com \
    --cc=saikrishna.edupuganti@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).