From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8EF7A058B; Wed, 25 Mar 2020 14:22:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC8832BAE; Wed, 25 Mar 2020 14:22:09 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by dpdk.org (Postfix) with ESMTP id 930A33B5 for ; Wed, 25 Mar 2020 14:22:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585142527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B8LEukwgFxlj0mSrmJbGek0MbVCNKZPLV/knccBzfBY=; b=bmn8+J9uDgwkcGJuxpWCifQa9JXeqCSX40mDfLNH/3fZBDVCtduJH0RTLNwSLs7Bz0sgmo dEJOEx3kOmfhQJYFuJ7IFpnP+/HSqLOblm5I28cgERCnBwCJKaf3xngQFYmqPEHSFsmU4J D++maNqh3KwJWn6qnPLsBBJYAmiW81w= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-zY8qzca1NyqeCm2b9npGhA-1; Wed, 25 Mar 2020 09:22:02 -0400 X-MC-Unique: zY8qzca1NyqeCm2b9npGhA-1 Received: by mail-ua1-f70.google.com with SMTP id a30so832244uae.6 for ; Wed, 25 Mar 2020 06:22:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EVMPWRAkE9Xu/n58COV6XwsdDJFFO9WATaYK0+ApOOM=; b=MscIrWdEspsWxVNTL79wHXDLQkqQpn7t0zhwzU407Tyz6U9JaOq7p5vsQxRcOYWgZl 45ZdrBkwqG9RTCXkLpsK0TC6Uc1sv6k6IGaA11PfmUlcE8MsuSsQAzZi8hu5Pe0lTYcX ndCjIQD3iEg/QxMcNLKASq3IGlSRYjoCn9AAqw4JdYlMhlZ5ztlVBqMONXgzRrNGaeT+ bjy/utXg8J+IzJ+8qcxlFqn4VAcdzFBfw3BeLsovRaA/lCi2PBS/71JkTOTV1hEO1TYv aCMxyFyhjY1TNdzKzQW1BRjNsdWq9BQtaWpZiJFyDes3QoiYs+F0O7rD5/LNjcr+qbb5 +D4Q== X-Gm-Message-State: ANhLgQ1UKo5E5cUl5IUwGQoCQBXBumQrZhB5kc83IREDiRura970Qxgb sx3yU8FtwjsuNsRphcbGx1wTDnGBb2pZ+V0OzWgEaJpyX162O/IikAiLaFRwepicVeATjIcPDyk 3YfrqttZy2SyS27tU4Lk= X-Received: by 2002:a67:905:: with SMTP id 5mr2461347vsj.105.1585142522257; Wed, 25 Mar 2020 06:22:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vslBKkAdZ/viCpCTN4zfVPdPVtTeHxoSF3UHvsUKNPWT9EuXN74sQ/LqdHRWFOOkgEH7aaG/nHR3fWHoJzCnuM= X-Received: by 2002:a67:905:: with SMTP id 5mr2461318vsj.105.1585142521973; Wed, 25 Mar 2020 06:22:01 -0700 (PDT) MIME-Version: 1.0 References: <20200316184236.15692-1-asim.jamshed@gmail.com> In-Reply-To: <20200316184236.15692-1-asim.jamshed@gmail.com> From: David Marchand Date: Wed, 25 Mar 2020 14:21:50 +0100 Message-ID: To: Muhammad Asim Jamshed Cc: dev , muhammad.jamshed@intel.com, saikrishna.edupuganti@intel.com, Vladimir Medvedkin X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk.org] [PATCH] fib: add "C" extern linkage for C++ programs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Cc: maintainer. On Mon, Mar 16, 2020 at 8:22 PM Muhammad Asim Jamshed wrote: > > This patch allows C++ programs to use librte_fib library routines. > Previously C++ programs were not able to link this library and programs > would fail to get linked. With this patch compilation and linking > will be successful. > > Signed-off-by: Muhammad Asim Jamshed > Signed-off-by: Saikrishna Edupuganti > --- > lib/librte_fib/rte_fib.h | 8 ++++++++ > lib/librte_fib/rte_fib6.h | 8 ++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/lib/librte_fib/rte_fib.h b/lib/librte_fib/rte_fib.h > index d06c5ef55..af3bbf07e 100644 > --- a/lib/librte_fib/rte_fib.h > +++ b/lib/librte_fib/rte_fib.h > @@ -14,6 +14,10 @@ > > #include > > +#ifdef __cplusplus > +extern "C" { > +#endif > + > struct rte_fib; > struct rte_rib; > > @@ -185,4 +189,8 @@ __rte_experimental > struct rte_rib * > rte_fib_get_rib(struct rte_fib *fib); > > +#ifdef __cplusplus > +} > +#endif > + > #endif /* _RTE_FIB_H_ */ > diff --git a/lib/librte_fib/rte_fib6.h b/lib/librte_fib/rte_fib6.h > index 426870403..66c71c84c 100644 > --- a/lib/librte_fib/rte_fib6.h > +++ b/lib/librte_fib/rte_fib6.h > @@ -14,6 +14,10 @@ > > #include > > +#ifdef __cplusplus > +extern "C" { > +#endif > + > #define RTE_FIB6_IPV6_ADDR_SIZE 16 > /** Maximum depth value possible for IPv6 FIB. */ > #define RTE_FIB6_MAXDEPTH 128 > @@ -190,4 +194,8 @@ __rte_experimental > struct rte_rib6 * > rte_fib6_get_rib(struct rte_fib6 *fib); > > +#ifdef __cplusplus > +} > +#endif > + > #endif /* _RTE_FIB6_H_ */ > -- > 2.17.1 > Reviewed-by: David Marchand --=20 David Marchand