From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E8B642BF2; Wed, 31 May 2023 16:13:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5158540A89; Wed, 31 May 2023 16:13:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D2B3E40A82 for ; Wed, 31 May 2023 16:12:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685542379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pd/rsKcEN7HJdltT92yxXYaBNOKYgpQSeHhZ8M2ZvZ4=; b=daM6WfreVA7u97nybtLRr03eQaqy4mY6Cisrsa78yXeb6OlMRW/rspup1QCMh9pA/3wB7w T3tzFOBolTzl9jwdfSQ/ECZR/47Gr0Z8LQ5OiJc82M72IVQCqNREuyj7hveKIgwxsrK9bv Hb+T+JmdYnRHtTFn/6IvstAmKPQFd2w= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-Ruq4B4AZOAyTqztyCEt9Jw-1; Wed, 31 May 2023 10:12:58 -0400 X-MC-Unique: Ruq4B4AZOAyTqztyCEt9Jw-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1b0116fef51so31031245ad.0 for ; Wed, 31 May 2023 07:12:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685542377; x=1688134377; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pd/rsKcEN7HJdltT92yxXYaBNOKYgpQSeHhZ8M2ZvZ4=; b=jZKp6N4DRlgu0JcDBOC6HeqjpqKJXK5WrE2xGwnY+Jx7Gl8ariahwQ9VzkAj4yB8xa HcLqZnGG9BMlZvcC1EJdPuUheK/SGV6yiHd0jZupLCLZf/DcLiIBuwyacYvOBKMq0HRb DQHF/GAhnAvdQFLxJKMlIMxDxR/7DlIHTrW81/FL2fYvqyLnoL6N/ZyACUVIFg0cm+iH B3j0VZ24IzMLcCEd8Z4Kcv6Me9rDfIFd2cMjhm/goN6HKL8WF1QknBLocX67KMgqiW/j F7mQ1R0zf2mz8E10vedoARQZj1X+9dW0NmmeSJLjbr9pvsV+xAU0UR8KRNt9v+ReWv4Q tMVg== X-Gm-Message-State: AC+VfDySPPPTnHZ/JVmLfmiuicZTb+UcVc/nH5OLMjs0AVVkCjMFkAkJ bpwQQ0G+r55BPlMJPVgDdfRvydtLeLgAvFQZhiUSeHwci9SwhGg2sjOdYenexMDiLv1a/XGmcTh /AJixZRS1dvLWQoF/un8= X-Received: by 2002:a17:903:234c:b0:1b0:45e:fb02 with SMTP id c12-20020a170903234c00b001b0045efb02mr4786029plh.35.1685542377305; Wed, 31 May 2023 07:12:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ60+zdbWndWSs4yLbUOs0OI6XN2pKdu8PQ1v2t0eJ/vM/GUFt+YXFly7Ef2MmJnKaRAVb+j77Q8pDBybYSSXok= X-Received: by 2002:a17:903:234c:b0:1b0:45e:fb02 with SMTP id c12-20020a170903234c00b001b0045efb02mr4786005plh.35.1685542377023; Wed, 31 May 2023 07:12:57 -0700 (PDT) MIME-Version: 1.0 References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <168431455219.558450.14986601389394385835.stgit@ebuild.local> In-Reply-To: <168431455219.558450.14986601389394385835.stgit@ebuild.local> From: David Marchand Date: Wed, 31 May 2023 16:12:46 +0200 Message-ID: Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick To: maxime.coquelin@redhat.com Cc: Eelco Chaudron , chenbo.xia@intel.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Maxime, On Wed, May 17, 2023 at 11:09=E2=80=AFAM Eelco Chaudron wrote: > @@ -974,11 +994,8 @@ vhost_vring_call_packed(struct virtio_net *dev, stru= ct vhost_virtqueue *vq) > if (vhost_need_event(off, new, old)) > kick =3D true; > kick: > - if (kick && vq->callfd >=3D 0) { > - eventfd_write(vq->callfd, (eventfd_t)1); > - if (dev->notify_ops->guest_notified) > - dev->notify_ops->guest_notified(dev->vid); > - } > + if (kick && vq->callfd >=3D 0) > + vhost_vring_inject_irq(dev, vq); Thinking again about the VDUSE series overlap... This hunk here is implicitely fixing an issue. You addressed it in https://patchwork.dpdk.org/project/dpdk/patch/20230525162551.70359-2-maxime= .coquelin@redhat.com/ So I suggest you apply this patch of yours before Eelco patch 4. This way, the fix backport will be trivial. --=20 David Marchand