DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	 Harman Kalra <hkalra@marvell.com>
Subject: Re: [PATCH v5 0/2] build and install only one library type on Windows
Date: Fri, 14 Jun 2024 17:00:07 +0200	[thread overview]
Message-ID: <CAJFAV8y7N_VrCrkH8RiN4jcsGi_Q0jGTS1G9YAnex4_AsJUGVw@mail.gmail.com> (raw)
In-Reply-To: <1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com>

On Mon, Apr 15, 2024 at 7:13 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> MSVC is the only compiler that can produce usable shared libraries for
> DPDK on Windows because of the use of exported TLS variables.
>
> Disable building of shared libraries with LLVM and MinGW so that
> remaining __declspec macros needed for the functional libraries built by
> MSVC can be used without triggering errors in LLVM and MinGW builds.
>                                                                                                                              For Windows only install the default_library type to avoid confusion.
> Windows builds cannot build both shared and static in a single pass so
> install only the functional variant
>
> MSVC does not guarantee any kind of compatibility for static libraries so
> they should not be packaged and instead they should be rebuilt along with
> the application using the same version of the compiler & linker.  Because
> of this we have chosen to build only one library type at a time instead of
> compiling twice to produce both types in a single pass.
>
> thanks Bruce for all the discussion/feedback!
>
> Tyler Retzlaff (2):
>   build: build only one library type on Windows
>   buildtools: when building static library use static deps
>
>  buildtools/chkincs/meson.build |  5 ++--
>  config/meson.build             | 24 +++++++++++++++
>  drivers/meson.build            | 59 ++++++++++++++++---------------------
>  lib/meson.build                | 67 ++++++++++++++++--------------------------
>  4 files changed, 78 insertions(+), 77 deletions(-)

Series applied, thanks.


-- 
David Marchand


  parent reply	other threads:[~2024-06-14 15:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14 19:44 [PATCH] " Tyler Retzlaff
2024-03-14 19:44 ` [PATCH] build: build " Tyler Retzlaff
2024-03-15  6:30 ` [PATCH v2 0/2] build and install " Tyler Retzlaff
2024-03-15  6:30   ` [PATCH v2 1/2] build: build " Tyler Retzlaff
2024-04-12 13:00     ` Bruce Richardson
2024-04-12 23:04       ` Tyler Retzlaff
2024-04-15  9:42         ` Bruce Richardson
2024-03-15  6:30   ` [PATCH v2 2/2] buildtools: when building static library use static deps Tyler Retzlaff
2024-03-15  8:28     ` Bruce Richardson
2024-04-04 18:47       ` Tyler Retzlaff
2024-04-05  9:11         ` Bruce Richardson
2024-04-12 14:09     ` Bruce Richardson
2024-04-12 22:52       ` Tyler Retzlaff
2024-04-12 22:52 ` [PATCH v3 0/2] build and install only one library type on Windows Tyler Retzlaff
2024-04-12 22:52   ` [PATCH v3 1/2] build: build " Tyler Retzlaff
2024-04-15  9:55     ` Bruce Richardson
2024-04-12 22:52   ` [PATCH v3 2/2] buildtools: when building static library use static deps Tyler Retzlaff
2024-04-15  9:56     ` Bruce Richardson
2024-04-15 16:45 ` [PATCH v4 0/2] build and install only one library type on Windows Tyler Retzlaff
2024-04-15 16:45   ` [PATCH v4 1/2] build: build " Tyler Retzlaff
2024-04-15 16:45   ` [PATCH v4 2/2] buildtools: when building static library use static deps Tyler Retzlaff
2024-04-15 17:12 ` [PATCH v5 0/2] build and install only one library type on Windows Tyler Retzlaff
2024-04-15 17:12   ` [PATCH v5 1/2] build: build " Tyler Retzlaff
2024-04-15 17:24     ` Bruce Richardson
2024-04-15 17:12   ` [PATCH v5 2/2] buildtools: when building static library use static deps Tyler Retzlaff
2024-06-14 15:00   ` David Marchand [this message]
2024-06-14 15:15     ` [PATCH v5 0/2] build and install only one library type on Windows David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8y7N_VrCrkH8RiN4jcsGi_Q0jGTS1G9YAnex4_AsJUGVw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).